All of lore.kernel.org
 help / color / mirror / Atom feed
From: Can Guo <cang@codeaurora.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org,
	hongwus@codeaurora.org, rnayak@codeaurora.org,
	linux-scsi@vger.kernel.org, kernel-team@android.com,
	saravanak@google.com, salyzyn@google.com,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	Stanley Chu <stanley.chu@mediatek.com>,
	Bean Huo <beanhuo@micron.com>,
	Bart Van Assche <bvanassche@acm.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 8/9] scsi: ufs: Fix a racing problem btw error handler and runtime PM ops
Date: Thu, 06 Aug 2020 12:53:55 +0800	[thread overview]
Message-ID: <f6a49b77e381c274e1a4cfd11e088304@codeaurora.org> (raw)
In-Reply-To: <yq1r1slzxoh.fsf@ca-mkp.ca.oracle.com>

On 2020-08-05 09:31, Martin K. Petersen wrote:
> Can,
> 
>> Current IRQ handler blocks scsi requests before scheduling eh_work,
>> when error handler calls pm_runtime_get_sync, if ufshcd_suspend/resume
>> sends a scsi cmd, most likely the SSU cmd, since scsi requests are
>> blocked, pm_runtime_get_sync() will never return because
>> ufshcd_suspend/reusme is blocked by the scsi cmd. Some changes and
>> code re-arrangement can be made to resolve it.
> 
>   CC [M]  drivers/scsi/ufs/ufshcd.o
> drivers/scsi/ufs/ufshcd.c: In function ‘ufshcd_queuecommand’:
> drivers/scsi/ufs/ufshcd.c:2570:6: error: this statement may fall
> through [-Werror=implicit-fallthrough=]
>  2570 |   if (hba->pm_op_in_progress) {
>       |      ^
> drivers/scsi/ufs/ufshcd.c:2575:2: note: here
>  2575 |  case UFSHCD_STATE_RESET:
>       |  ^~~~
> cc1: all warnings being treated as errors
> make[3]: *** [scripts/Makefile.build:280: drivers/scsi/ufs/ufshcd.o] 
> Error 1
> make[2]: *** [scripts/Makefile.build:497: drivers/scsi/ufs] Error 2
> make[1]: *** [scripts/Makefile.build:497: drivers/scsi] Error 2
> make: *** [Makefile:1764: drivers] Error 2

Thanks Martin, will fix it in next version.

Can Guo.

  reply	other threads:[~2020-08-06 11:00 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-03  9:04 [PATCH v9 0/9] Fix up and simplify error recovery mechanism Can Guo
2020-08-03  9:04 ` [PATCH v9 1/9] scsi: ufs: Add checks before setting clk-gating states Can Guo
2020-08-03  9:04   ` Can Guo
2020-08-03  9:04   ` Can Guo
2020-08-03  9:04 ` [PATCH v9 2/9] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config Can Guo
2020-08-03  9:04 ` [PATCH v9 3/9] scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs Can Guo
2020-08-03  9:04 ` [PATCH v9 4/9] scsi: ufs: Add some debug infos to ufshcd_print_host_state Can Guo
2020-08-03  9:04   ` Can Guo
2020-08-03  9:04   ` Can Guo
2020-08-03  9:04 ` [PATCH v9 5/9] scsi: ufs: Fix concurrency of error handler and other error recovery paths Can Guo
2020-08-03  9:04 ` [PATCH v9 6/9] scsi: ufs: Recover hba runtime PM error in error handler Can Guo
2020-08-03  9:04 ` [PATCH v9 7/9] scsi: ufs: Move dumps in IRQ handler to " Can Guo
2020-08-03 16:02   ` Asutosh Das (asd)
2020-08-03  9:04 ` [PATCH v9 8/9] scsi: ufs: Fix a racing problem btw error handler and runtime PM ops Can Guo
2020-08-05  1:31   ` Martin K. Petersen
2020-08-06  4:53     ` Can Guo [this message]
2020-08-03  9:04 ` [PATCH v9 9/9] scsi: ufs: Properly release resources if a task is aborted successfully Can Guo
2020-08-03  9:04   ` Can Guo
2020-08-03  9:04   ` Can Guo
2020-08-03  9:44   ` Stanley Chu
2020-08-03  9:44     ` Stanley Chu
2020-08-03  9:44     ` Stanley Chu
2020-08-07 23:50 ` [PATCH v9 0/9] Fix up and simplify error recovery mechanism Asutosh Das (asd)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f6a49b77e381c274e1a4cfd11e088304@codeaurora.org \
    --to=cang@codeaurora.org \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=hongwus@codeaurora.org \
    --cc=jejb@linux.ibm.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nguyenb@codeaurora.org \
    --cc=rnayak@codeaurora.org \
    --cc=salyzyn@google.com \
    --cc=saravanak@google.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.