From: Stanley Chu <stanley.chu@mediatek.com>
To: Can Guo <cang@codeaurora.org>
Cc: <asutoshd@codeaurora.org>, <nguyenb@codeaurora.org>,
<hongwus@codeaurora.org>, <rnayak@codeaurora.org>,
<linux-scsi@vger.kernel.org>, <kernel-team@android.com>,
<saravanak@google.com>, <salyzyn@google.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Bean Huo" <beanhuo@micron.com>,
Bart Van Assche <bvanassche@acm.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v9 9/9] scsi: ufs: Properly release resources if a task is aborted successfully
Date: Mon, 3 Aug 2020 17:44:17 +0800 [thread overview]
Message-ID: <1596447857.32283.24.camel@mtkswgap22> (raw)
In-Reply-To: <1596445485-19834-10-git-send-email-cang@codeaurora.org>
On Mon, 2020-08-03 at 02:04 -0700, Can Guo wrote:
> In current UFS task abort hook, namely ufshcd_abort(), if a task is
> aborted successfully, clock scaling busy time statistics is not updated
> and, most important, clk_gating.active_reqs is not decreased, which makes
> clk_gating.active_reqs stay above zero forever, thus clock gating would
> never happen. To fix it, instead of releasing resources "mannually", use
> the existing func __ufshcd_transfer_req_compl(). This can also eliminate
> racing of scsi_dma_unmap() from the real completion in IRQ handler path.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> CC: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index d7d2758..9a48389 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6635,11 +6635,8 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
> goto out;
> }
>
> - scsi_dma_unmap(cmd);
> -
> spin_lock_irqsave(host->host_lock, flags);
> - ufshcd_outstanding_req_clear(hba, tag);
> - hba->lrb[tag].cmd = NULL;
> + __ufshcd_transfer_req_compl(hba, (1UL << tag));
> spin_unlock_irqrestore(host->host_lock, flags);
>
> out:
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: Can Guo <cang@codeaurora.org>
Cc: "moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
rnayak@codeaurora.org, saravanak@google.com,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
nguyenb@codeaurora.org, open list <linux-kernel@vger.kernel.org>,
Avri Altman <avri.altman@wdc.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
salyzyn@google.com, Alim Akhtar <alim.akhtar@samsung.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bean Huo <beanhuo@micron.com>,
kernel-team@android.com, Bart Van Assche <bvanassche@acm.org>,
hongwus@codeaurora.org, asutoshd@codeaurora.org
Subject: Re: [PATCH v9 9/9] scsi: ufs: Properly release resources if a task is aborted successfully
Date: Mon, 3 Aug 2020 17:44:17 +0800 [thread overview]
Message-ID: <1596447857.32283.24.camel@mtkswgap22> (raw)
In-Reply-To: <1596445485-19834-10-git-send-email-cang@codeaurora.org>
On Mon, 2020-08-03 at 02:04 -0700, Can Guo wrote:
> In current UFS task abort hook, namely ufshcd_abort(), if a task is
> aborted successfully, clock scaling busy time statistics is not updated
> and, most important, clk_gating.active_reqs is not decreased, which makes
> clk_gating.active_reqs stay above zero forever, thus clock gating would
> never happen. To fix it, instead of releasing resources "mannually", use
> the existing func __ufshcd_transfer_req_compl(). This can also eliminate
> racing of scsi_dma_unmap() from the real completion in IRQ handler path.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> CC: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index d7d2758..9a48389 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6635,11 +6635,8 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
> goto out;
> }
>
> - scsi_dma_unmap(cmd);
> -
> spin_lock_irqsave(host->host_lock, flags);
> - ufshcd_outstanding_req_clear(hba, tag);
> - hba->lrb[tag].cmd = NULL;
> + __ufshcd_transfer_req_compl(hba, (1UL << tag));
> spin_unlock_irqrestore(host->host_lock, flags);
>
> out:
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Stanley Chu <stanley.chu@mediatek.com>
To: Can Guo <cang@codeaurora.org>
Cc: "moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
rnayak@codeaurora.org, saravanak@google.com,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
nguyenb@codeaurora.org, open list <linux-kernel@vger.kernel.org>,
Avri Altman <avri.altman@wdc.com>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
salyzyn@google.com, Alim Akhtar <alim.akhtar@samsung.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Bean Huo <beanhuo@micron.com>,
kernel-team@android.com, Bart Van Assche <bvanassche@acm.org>,
hongwus@codeaurora.org, asutoshd@codeaurora.org
Subject: Re: [PATCH v9 9/9] scsi: ufs: Properly release resources if a task is aborted successfully
Date: Mon, 3 Aug 2020 17:44:17 +0800 [thread overview]
Message-ID: <1596447857.32283.24.camel@mtkswgap22> (raw)
In-Reply-To: <1596445485-19834-10-git-send-email-cang@codeaurora.org>
On Mon, 2020-08-03 at 02:04 -0700, Can Guo wrote:
> In current UFS task abort hook, namely ufshcd_abort(), if a task is
> aborted successfully, clock scaling busy time statistics is not updated
> and, most important, clk_gating.active_reqs is not decreased, which makes
> clk_gating.active_reqs stay above zero forever, thus clock gating would
> never happen. To fix it, instead of releasing resources "mannually", use
> the existing func __ufshcd_transfer_req_compl(). This can also eliminate
> racing of scsi_dma_unmap() from the real completion in IRQ handler path.
>
> Signed-off-by: Can Guo <cang@codeaurora.org>
> CC: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index d7d2758..9a48389 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6635,11 +6635,8 @@ static int ufshcd_abort(struct scsi_cmnd *cmd)
> goto out;
> }
>
> - scsi_dma_unmap(cmd);
> -
> spin_lock_irqsave(host->host_lock, flags);
> - ufshcd_outstanding_req_clear(hba, tag);
> - hba->lrb[tag].cmd = NULL;
> + __ufshcd_transfer_req_compl(hba, (1UL << tag));
> spin_unlock_irqrestore(host->host_lock, flags);
>
> out:
Reviewed-by: Stanley Chu <stanley.chu@mediatek.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-03 9:44 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 9:04 [PATCH v9 0/9] Fix up and simplify error recovery mechanism Can Guo
2020-08-03 9:04 ` [PATCH v9 1/9] scsi: ufs: Add checks before setting clk-gating states Can Guo
2020-08-03 9:04 ` Can Guo
2020-08-03 9:04 ` Can Guo
2020-08-03 9:04 ` [PATCH v9 2/9] ufs: ufs-qcom: Fix race conditions caused by func ufs_qcom_testbus_config Can Guo
2020-08-03 9:04 ` [PATCH v9 3/9] scsi: ufs-qcom: Remove testbus dump in ufs_qcom_dump_dbg_regs Can Guo
2020-08-03 9:04 ` [PATCH v9 4/9] scsi: ufs: Add some debug infos to ufshcd_print_host_state Can Guo
2020-08-03 9:04 ` Can Guo
2020-08-03 9:04 ` Can Guo
2020-08-03 9:04 ` [PATCH v9 5/9] scsi: ufs: Fix concurrency of error handler and other error recovery paths Can Guo
2020-08-03 9:04 ` [PATCH v9 6/9] scsi: ufs: Recover hba runtime PM error in error handler Can Guo
2020-08-03 9:04 ` [PATCH v9 7/9] scsi: ufs: Move dumps in IRQ handler to " Can Guo
2020-08-03 16:02 ` Asutosh Das (asd)
2020-08-03 9:04 ` [PATCH v9 8/9] scsi: ufs: Fix a racing problem btw error handler and runtime PM ops Can Guo
2020-08-05 1:31 ` Martin K. Petersen
2020-08-06 4:53 ` Can Guo
2020-08-03 9:04 ` [PATCH v9 9/9] scsi: ufs: Properly release resources if a task is aborted successfully Can Guo
2020-08-03 9:04 ` Can Guo
2020-08-03 9:04 ` Can Guo
2020-08-03 9:44 ` Stanley Chu [this message]
2020-08-03 9:44 ` Stanley Chu
2020-08-03 9:44 ` Stanley Chu
2020-08-07 23:50 ` [PATCH v9 0/9] Fix up and simplify error recovery mechanism Asutosh Das (asd)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1596447857.32283.24.camel@mtkswgap22 \
--to=stanley.chu@mediatek.com \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hongwus@codeaurora.org \
--cc=jejb@linux.ibm.com \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=nguyenb@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=salyzyn@google.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.