All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH net-next] net: remove eth_change_mtu
@ 2020-01-25 12:42 Heiner Kallweit
  2020-01-27 10:09 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2020-01-25 12:42 UTC (permalink / raw)
  To: David Miller; +Cc: netdev

All usage of this function was removed three years ago, and the
function was marked as deprecated:
a52ad514fdf3 ("net: deprecate eth_change_mtu, remove usage")
So I think we can remove it now.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 include/linux/etherdevice.h |  1 -
 net/ethernet/eth.c          | 16 ----------------
 2 files changed, 17 deletions(-)

diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h
index f6564b572..8801f1f98 100644
--- a/include/linux/etherdevice.h
+++ b/include/linux/etherdevice.h
@@ -43,7 +43,6 @@ __be16 eth_header_parse_protocol(const struct sk_buff *skb);
 int eth_prepare_mac_addr_change(struct net_device *dev, void *p);
 void eth_commit_mac_addr_change(struct net_device *dev, void *p);
 int eth_mac_addr(struct net_device *dev, void *p);
-int eth_change_mtu(struct net_device *dev, int new_mtu);
 int eth_validate_addr(struct net_device *dev);
 
 struct net_device *alloc_etherdev_mqs(int sizeof_priv, unsigned int txqs,
diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c
index 9040fe55e..c8b903302 100644
--- a/net/ethernet/eth.c
+++ b/net/ethernet/eth.c
@@ -335,22 +335,6 @@ int eth_mac_addr(struct net_device *dev, void *p)
 }
 EXPORT_SYMBOL(eth_mac_addr);
 
-/**
- * eth_change_mtu - set new MTU size
- * @dev: network device
- * @new_mtu: new Maximum Transfer Unit
- *
- * Allow changing MTU size. Needs to be overridden for devices
- * supporting jumbo frames.
- */
-int eth_change_mtu(struct net_device *dev, int new_mtu)
-{
-	netdev_warn(dev, "%s is deprecated\n", __func__);
-	dev->mtu = new_mtu;
-	return 0;
-}
-EXPORT_SYMBOL(eth_change_mtu);
-
 int eth_validate_addr(struct net_device *dev)
 {
 	if (!is_valid_ether_addr(dev->dev_addr))
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net-next] net: remove eth_change_mtu
  2020-01-25 12:42 [PATCH net-next] net: remove eth_change_mtu Heiner Kallweit
@ 2020-01-27 10:09 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-01-27 10:09 UTC (permalink / raw)
  To: hkallweit1; +Cc: netdev

From: Heiner Kallweit <hkallweit1@gmail.com>
Date: Sat, 25 Jan 2020 13:42:14 +0100

> All usage of this function was removed three years ago, and the
> function was marked as deprecated:
> a52ad514fdf3 ("net: deprecate eth_change_mtu, remove usage")
> So I think we can remove it now.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Applied, thanks Heiner.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-01-27 10:09 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-25 12:42 [PATCH net-next] net: remove eth_change_mtu Heiner Kallweit
2020-01-27 10:09 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.