* DEFAULT_PREFERENCE no longer used?
@ 2021-07-22 8:55 Michael Opdenacker
2021-07-22 8:59 ` [docs] " Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Michael Opdenacker @ 2021-07-22 8:55 UTC (permalink / raw)
To: BitBake developer list; +Cc: YP docs mailing list
Greetings,
Looking at the code, it seems that the DEFAULT_PREFERENCE variable is no
longer in use. Unless I missed something, the variable is still read,
but not taken into account any more, and there are just two recipes that
set it.
The BitBake documentation still refers to it though.
May I propose documentation and code patches to remove it for good?
Cheers
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [docs] DEFAULT_PREFERENCE no longer used?
2021-07-22 8:55 DEFAULT_PREFERENCE no longer used? Michael Opdenacker
@ 2021-07-22 8:59 ` Richard Purdie
2021-07-22 9:04 ` [bitbake-devel] " Michael Opdenacker
0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2021-07-22 8:59 UTC (permalink / raw)
To: Michael Opdenacker, BitBake developer list; +Cc: YP docs mailing list
On Thu, 2021-07-22 at 10:55 +0200, Michael Opdenacker wrote:
> Greetings,
>
> Looking at the code, it seems that the DEFAULT_PREFERENCE variable is no
> longer in use. Unless I missed something, the variable is still read,
> but not taken into account any more, and there are just two recipes that
> set it.
>
> The BitBake documentation still refers to it though.
>
> May I propose documentation and code patches to remove it for good?
I think it is still used:
lib/bb/cache.py: self.defaultpref = self.intvar('DEFAULT_PREFERENCE', metadata)
lib/bb/cache.py: cachedata.pkg_dp[fn] = self.defaultpref
lib/bb/providers.py: preference = dataCache.pkg_dp[f]
[in sortPriorities()]
Cheers,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [bitbake-devel] [docs] DEFAULT_PREFERENCE no longer used?
2021-07-22 8:59 ` [docs] " Richard Purdie
@ 2021-07-22 9:04 ` Michael Opdenacker
0 siblings, 0 replies; 3+ messages in thread
From: Michael Opdenacker @ 2021-07-22 9:04 UTC (permalink / raw)
To: Richard Purdie, BitBake developer list; +Cc: YP docs mailing list
Hi Richard,
On 7/22/21 10:59 AM, Richard Purdie wrote:
> On Thu, 2021-07-22 at 10:55 +0200, Michael Opdenacker wrote:
>> Greetings,
>>
>> Looking at the code, it seems that the DEFAULT_PREFERENCE variable is no
>> longer in use. Unless I missed something, the variable is still read,
>> but not taken into account any more, and there are just two recipes that
>> set it.
>>
>> The BitBake documentation still refers to it though.
>>
>> May I propose documentation and code patches to remove it for good?
> I think it is still used:
>
> lib/bb/cache.py: self.defaultpref = self.intvar('DEFAULT_PREFERENCE', metadata)
> lib/bb/cache.py: cachedata.pkg_dp[fn] = self.defaultpref
> lib/bb/providers.py: preference = dataCache.pkg_dp[f]
Oops, I read too quickly then, overlooking the second line.
Thanks for proving me wrong :)
Michael.
--
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-07-22 9:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-22 8:55 DEFAULT_PREFERENCE no longer used? Michael Opdenacker
2021-07-22 8:59 ` [docs] " Richard Purdie
2021-07-22 9:04 ` [bitbake-devel] " Michael Opdenacker
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.