* [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
@ 2018-10-03 17:52 Srinivas Kandagatla
2018-10-15 18:32 ` Greg KH
0 siblings, 1 reply; 6+ messages in thread
From: Srinivas Kandagatla @ 2018-10-03 17:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Niklas Cassel, Srinivas Kandagatla
From: Niklas Cassel <niklas.cassel@linaro.org>
QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
to select it, not depend upon it.
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/slimbus/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
index 9d73ad806698..9cca2c3559f2 100644
--- a/drivers/slimbus/Kconfig
+++ b/drivers/slimbus/Kconfig
@@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL
config SLIM_QCOM_NGD_CTRL
tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
- depends on QCOM_QMI_HELPERS
depends on HAS_IOMEM && DMA_ENGINE
+ select QCOM_QMI_HELPERS
help
Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
Component is programmed using Linux kernel.
--
2.19.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
2018-10-03 17:52 [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected Srinivas Kandagatla
@ 2018-10-15 18:32 ` Greg KH
2018-10-15 19:44 ` [PATCH v2] " Niklas Cassel
0 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2018-10-15 18:32 UTC (permalink / raw)
To: Srinivas Kandagatla; +Cc: linux-kernel, Niklas Cassel
On Wed, Oct 03, 2018 at 06:52:36PM +0100, Srinivas Kandagatla wrote:
> From: Niklas Cassel <niklas.cassel@linaro.org>
>
> QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
> to select it, not depend upon it.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Reviewed-by: Alex Elder <elder@linaro.org>
> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> drivers/slimbus/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
> index 9d73ad806698..9cca2c3559f2 100644
> --- a/drivers/slimbus/Kconfig
> +++ b/drivers/slimbus/Kconfig
> @@ -22,8 +22,8 @@ config SLIM_QCOM_CTRL
>
> config SLIM_QCOM_NGD_CTRL
> tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
> - depends on QCOM_QMI_HELPERS
> depends on HAS_IOMEM && DMA_ENGINE
> + select QCOM_QMI_HELPERS
> help
> Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
> Component is programmed using Linux kernel.
> --
> 2.19.0
>
This adds the following build warning when applied:
WARNING: unmet direct dependencies detected for QCOM_QMI_HELPERS
Depends on [n]: ARCH_QCOM && NET [=y]
Selected by [m]:
- SLIM_QCOM_NGD_CTRL [=m] && SLIMBUS [=m] && HAS_IOMEM [=y] && DMA_ENGINE [=y]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
2018-10-15 18:32 ` Greg KH
@ 2018-10-15 19:44 ` Niklas Cassel
2018-10-16 9:35 ` Srinivas Kandagatla
2018-11-07 13:59 ` Greg KH
0 siblings, 2 replies; 6+ messages in thread
From: Niklas Cassel @ 2018-10-15 19:44 UTC (permalink / raw)
To: srinivas.kandagatla, gregkh; +Cc: linux-kernel, Niklas Cassel
QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
to select it, not depend upon it.
Because of this change, we now also need to depend on the same
Kconfigs as QCOM_QMI_HELPERS depends on.
Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
---
Hello Greg, Srini,
I'm sorry for this.
(Although I'm a bit curious why 0-day test bot didn't catch this.)
Considering that I've just changed QCOM_QMI_HELPERS in:
ccfb464cd106 ("soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs")
which is currently in linux-next, and that this Kconfig should
depend on the same Kconfigs as QCOM_QMI_HELPERS depends on,
I chose to have this Kconfig match the QCOM_QMI_HELPERS that is
currently in linux-next.
drivers/slimbus/Kconfig | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
index 9d73ad806698..8cd595148d17 100644
--- a/drivers/slimbus/Kconfig
+++ b/drivers/slimbus/Kconfig
@@ -22,8 +22,9 @@ config SLIM_QCOM_CTRL
config SLIM_QCOM_NGD_CTRL
tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
- depends on QCOM_QMI_HELPERS
- depends on HAS_IOMEM && DMA_ENGINE
+ depends on HAS_IOMEM && DMA_ENGINE && NET
+ depends on ARCH_QCOM || COMPILE_TEST
+ select QCOM_QMI_HELPERS
help
Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
Component is programmed using Linux kernel.
--
2.17.2
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
2018-10-15 19:44 ` [PATCH v2] " Niklas Cassel
@ 2018-10-16 9:35 ` Srinivas Kandagatla
2018-11-07 13:59 ` Greg KH
1 sibling, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2018-10-16 9:35 UTC (permalink / raw)
To: Niklas Cassel, gregkh; +Cc: linux-kernel
Thanks Niklas for quick v2 patch!
On 15/10/18 20:44, Niklas Cassel wrote:
> QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
> to select it, not depend upon it.
>
> Because of this change, we now also need to depend on the same
> Kconfigs as QCOM_QMI_HELPERS depends on.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
LGTM
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> Hello Greg, Srini,
>
> I'm sorry for this.
> (Although I'm a bit curious why 0-day test bot didn't catch this.)
>
> Considering that I've just changed QCOM_QMI_HELPERS in:
> ccfb464cd106 ("soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs")
> which is currently in linux-next, and that this Kconfig should
> depend on the same Kconfigs as QCOM_QMI_HELPERS depends on,
> I chose to have this Kconfig match the QCOM_QMI_HELPERS that is
> currently in linux-next.
>
> drivers/slimbus/Kconfig | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
> index 9d73ad806698..8cd595148d17 100644
> --- a/drivers/slimbus/Kconfig
> +++ b/drivers/slimbus/Kconfig
> @@ -22,8 +22,9 @@ config SLIM_QCOM_CTRL
>
> config SLIM_QCOM_NGD_CTRL
> tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
> - depends on QCOM_QMI_HELPERS
> - depends on HAS_IOMEM && DMA_ENGINE
> + depends on HAS_IOMEM && DMA_ENGINE && NET
> + depends on ARCH_QCOM || COMPILE_TEST
> + select QCOM_QMI_HELPERS
> help
> Select driver if Qualcomm's SLIMbus Satellite Non-Generic Device
> Component is programmed using Linux kernel.
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
2018-10-15 19:44 ` [PATCH v2] " Niklas Cassel
2018-10-16 9:35 ` Srinivas Kandagatla
@ 2018-11-07 13:59 ` Greg KH
2018-11-07 14:15 ` Srinivas Kandagatla
1 sibling, 1 reply; 6+ messages in thread
From: Greg KH @ 2018-11-07 13:59 UTC (permalink / raw)
To: Niklas Cassel; +Cc: srinivas.kandagatla, linux-kernel
On Mon, Oct 15, 2018 at 09:44:41PM +0200, Niklas Cassel wrote:
> QCOM_QMI_HELPERS is a hidden kconfig, so the proper usage is
> to select it, not depend upon it.
>
> Because of this change, we now also need to depend on the same
> Kconfigs as QCOM_QMI_HELPERS depends on.
>
> Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org>
> Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> Hello Greg, Srini,
>
> I'm sorry for this.
> (Although I'm a bit curious why 0-day test bot didn't catch this.)
>
> Considering that I've just changed QCOM_QMI_HELPERS in:
> ccfb464cd106 ("soc: qcom: Allow COMPILE_TEST of qcom SoC Kconfigs")
> which is currently in linux-next, and that this Kconfig should
> depend on the same Kconfigs as QCOM_QMI_HELPERS depends on,
> I chose to have this Kconfig match the QCOM_QMI_HELPERS that is
> currently in linux-next.
Really? I do this and then I get this build error on x86:
drivers/slimbus/qcom-ngd-ctrl.c: In function ‘of_qcom_slim_ngd_register’:
drivers/slimbus/qcom-ngd-ctrl.c:1333:63: warning: dereferencing ‘void *’ pointer
data = of_match_node(qcom_slim_ngd_dt_match, parent->of_node)->data;
^~
drivers/slimbus/qcom-ngd-ctrl.c:1333:63: error: request for member ‘data’ in something not a structure or union
So I can't take this, something else must be wrong here...
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH v2] slimbus: ngd: QCOM_QMI_HELPERS has to be selected
2018-11-07 13:59 ` Greg KH
@ 2018-11-07 14:15 ` Srinivas Kandagatla
0 siblings, 0 replies; 6+ messages in thread
From: Srinivas Kandagatla @ 2018-11-07 14:15 UTC (permalink / raw)
To: Greg KH, Niklas Cassel; +Cc: linux-kernel
On 07/11/18 13:59, Greg KH wrote:
> Really? I do this and then I get this build error on x86:
>
> drivers/slimbus/qcom-ngd-ctrl.c: In function ‘of_qcom_slim_ngd_register’:
> drivers/slimbus/qcom-ngd-ctrl.c:1333:63: warning: dereferencing ‘void *’ pointer
> data = of_match_node(qcom_slim_ngd_dt_match, parent->of_node)->data;
> ^~
> drivers/slimbus/qcom-ngd-ctrl.c:1333:63: error: request for member ‘data’ in something not a structure or union
>
>
> So I can't take this, something else must be wrong here...
That is fine!
Yes, there seems to be one more issue here, on non DT platforms
of_match_node is set to be NULL, which is why we are seeing this error I
guess!
I will fix this up, do some test and send both the fixes together.
thanks,
srini
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-11-07 14:15 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-03 17:52 [PATCH] slimbus: ngd: QCOM_QMI_HELPERS has to be selected Srinivas Kandagatla
2018-10-15 18:32 ` Greg KH
2018-10-15 19:44 ` [PATCH v2] " Niklas Cassel
2018-10-16 9:35 ` Srinivas Kandagatla
2018-11-07 13:59 ` Greg KH
2018-11-07 14:15 ` Srinivas Kandagatla
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.