From: Laurent Vivier <lvivier@redhat.com>
To: kvm-ppc@vger.kernel.org
Subject: Re: [kvm-unit-tests PATCH] powerpc: Make code compilable with -Wmissing-prototypes
Date: Mon, 11 Jun 2018 12:24:07 +0000 [thread overview]
Message-ID: <f6efcab4-2d86-bacf-5fb5-365f2d5ae775@redhat.com> (raw)
In-Reply-To: <1528717300-27112-1-git-send-email-thuth@redhat.com>
On 11/06/2018 13:41, Thomas Huth wrote:
> It's always better to check whether the implementations match the
> prototypes, so make the code compilable with the -Wmissing-prototypes
> compiler flag. (However, the flag is not turned on yet since the other
> architectures are not ready for this yet)
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> lib/powerpc/asm/setup.h | 2 ++
> lib/powerpc/hcall.c | 2 ++
> lib/powerpc/io.c | 3 ++-
> lib/powerpc/io.h | 8 ++++++++
> lib/powerpc/setup.c | 2 +-
> powerpc/reloc64.c | 2 ++
> 6 files changed, 17 insertions(+), 2 deletions(-)
> create mode 100644 lib/powerpc/io.h
Reviewed-by: Laurent Vivier <lvivier@redhat.com>
prev parent reply other threads:[~2018-06-11 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-11 11:41 [kvm-unit-tests PATCH] powerpc: Make code compilable with -Wmissing-prototypes Thomas Huth
2018-06-11 12:24 ` Laurent Vivier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6efcab4-2d86-bacf-5fb5-365f2d5ae775@redhat.com \
--to=lvivier@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.