From: Alexander Kanavin <alexander.kanavin@linux.intel.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] gettext.bbclass: do not add virtual/gettext to DEPENDS
Date: Tue, 29 Aug 2017 13:49:30 +0300 [thread overview]
Message-ID: <f73e1f08-4698-adba-0696-b0bb5f61a525@linux.intel.com> (raw)
In-Reply-To: <1504002777.32591.325.camel@linuxfoundation.org>
On 08/29/2017 01:32 PM, Richard Purdie wrote:
>
>> diff --git a/meta/classes/insane.bbclass
>> b/meta/classes/insane.bbclass
>> index b7177c9b329..a2ec466775f 100644
>> --- a/meta/classes/insane.bbclass
>> +++ b/meta/classes/insane.bbclass
>> @@ -1183,9 +1183,9 @@ Rerun configure task after fixing this.""")
>> elif bb.data.inherits_class('cross-canadian', d):
>> gt = "nativesdk-gettext"
>> else:
>> - gt = "virtual/" + ml + "gettext"
>> + gt = None
>
> Should this be gettext-native?
Yes; then this can be also merged with the first branch of the if-else
statement:
if bb.data.inherits_class('native', d) or
bb.data.inherits_class('cross', d) or bb.data.inherits_class('crosssdk',
d) or bb.data.inherits_class('nativesdk', d):
gt = "gettext-native"
I'll resend the patch.
Alex
prev parent reply other threads:[~2017-08-29 10:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 9:55 [PATCH] gettext.bbclass: do not add virtual/gettext to DEPENDS Alexander Kanavin
2017-08-29 10:32 ` Richard Purdie
2017-08-29 10:49 ` Alexander Kanavin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f73e1f08-4698-adba-0696-b0bb5f61a525@linux.intel.com \
--to=alexander.kanavin@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.