* [kvm-unit-tests PATCH v2 0/2] arm/powerpc: Makefile cleanup
@ 2016-05-10 16:55 Andrew Jones
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 1/2] arm/arm64: " Andrew Jones
` (2 more replies)
0 siblings, 3 replies; 10+ messages in thread
From: Andrew Jones @ 2016-05-10 16:55 UTC (permalink / raw)
To: kvm; +Cc: lvivier, thuth, richard.weiyang, pbonzini
Cleanup makefiles like 'x86: Makefile refine' does.
v2:
- no need for %.elf on powerpc patch
- commit message points out why .PRECIOUS is used
Andrew Jones (2):
arm/arm64: Makefile cleanup
powerpc/ppc64: Makefile cleanup
arm/Makefile.common | 8 ++++----
powerpc/Makefile.common | 13 ++++---------
2 files changed, 8 insertions(+), 13 deletions(-)
--
2.4.11
^ permalink raw reply [flat|nested] 10+ messages in thread
* [kvm-unit-tests PATCH v2 1/2] arm/arm64: Makefile cleanup
2016-05-10 16:55 [kvm-unit-tests PATCH v2 0/2] arm/powerpc: Makefile cleanup Andrew Jones
@ 2016-05-10 16:55 ` Andrew Jones
2016-05-10 17:03 ` Paolo Bonzini
2016-05-14 13:30 ` Wei Yang
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 2/2] powerpc/ppc64: " Andrew Jones
2016-05-10 17:04 ` [kvm-unit-tests PATCH v2 0/2] arm/powerpc: " Paolo Bonzini
2 siblings, 2 replies; 10+ messages in thread
From: Andrew Jones @ 2016-05-10 16:55 UTC (permalink / raw)
To: kvm; +Cc: lvivier, thuth, richard.weiyang, pbonzini
This does the same cleanup as 'x86: Makefile refine'. .PRECIOUS
is used (as opposed to .SECONDARY), because .SECONDARY doesn't
accept target patterns.
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
arm/Makefile.common | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arm/Makefile.common b/arm/Makefile.common
index 9a2d61fc88a27..a786fcf94154f 100644
--- a/arm/Makefile.common
+++ b/arm/Makefile.common
@@ -24,6 +24,9 @@ CFLAGS += -Wextra
CFLAGS += -O2
CFLAGS += -I lib -I lib/libfdt
+# We want to keep intermediate files
+.PRECIOUS: %.elf %.o
+
asm-offsets = lib/$(ARCH)/asm-offsets.h
include scripts/asm-offsets.mak
@@ -48,7 +51,7 @@ start_addr := $(shell printf "%x\n" $$(( $(phys_base) + $(kernel_offset) )))
FLATLIBS = $(libcflat) $(LIBFDT_archive) $(libgcc) $(libeabi)
%.elf: LDFLAGS = $(CFLAGS) -nostdlib
-%.elf: %.o $(FLATLIBS) arm/flat.lds
+%.elf: %.o $(FLATLIBS) arm/flat.lds $(cstart.o)
$(CC) $(LDFLAGS) -o $@ \
-Wl,-T,arm/flat.lds,--build-id=none,-Ttext=$(start_addr) \
$(filter %.o, $^) $(FLATLIBS)
@@ -69,7 +72,4 @@ generated_files = $(asm-offsets)
test_cases: $(generated_files) $(tests-common) $(tests)
-$(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
-$(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
-
$(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets)
--
2.4.11
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [kvm-unit-tests PATCH v2 2/2] powerpc/ppc64: Makefile cleanup
2016-05-10 16:55 [kvm-unit-tests PATCH v2 0/2] arm/powerpc: Makefile cleanup Andrew Jones
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 1/2] arm/arm64: " Andrew Jones
@ 2016-05-10 16:55 ` Andrew Jones
2016-05-14 13:32 ` Wei Yang
2016-05-10 17:04 ` [kvm-unit-tests PATCH v2 0/2] arm/powerpc: " Paolo Bonzini
2 siblings, 1 reply; 10+ messages in thread
From: Andrew Jones @ 2016-05-10 16:55 UTC (permalink / raw)
To: kvm; +Cc: lvivier, thuth, richard.weiyang, pbonzini
This does the same cleanup as 'x86: Makefile refine'. .PRECIOUS
is used (as opposed to .SECONDARY), because .SECONDARY doesn't
accept target patterns.
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
powerpc/Makefile.common | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common
index 4449aec616853..4ff1dc8f48d32 100644
--- a/powerpc/Makefile.common
+++ b/powerpc/Makefile.common
@@ -22,6 +22,9 @@ CFLAGS += -I lib -I lib/libfdt
CFLAGS += -Wa,-mregnames
CFLAGS += -fpie
+# We want to keep intermediate files
+.PRECIOUS: %.o
+
asm-offsets = lib/$(ARCH)/asm-offsets.h
include scripts/asm-offsets.mak
@@ -37,7 +40,7 @@ cflatobjs += lib/powerpc/processor.o
FLATLIBS = $(libcflat) $(LIBFDT_archive)
%.elf: CFLAGS += $(arch_CFLAGS)
%.elf: LDFLAGS = $(arch_LDFLAGS) -nostdlib -pie
-%.elf: %.o $(FLATLIBS) powerpc/flat.lds
+%.elf: %.o $(FLATLIBS) powerpc/flat.lds $(cstart.o) $(reloc.o)
$(LD) $(LDFLAGS) -o $@ \
-T powerpc/flat.lds --build-id=none \
$(filter %.o, $^) $(FLATLIBS)
@@ -69,11 +72,3 @@ generated_files = $(asm-offsets)
test_cases: $(generated_files) $(tests-common) $(tests)
$(cstart.o): $(asm-offsets)
-
-$(TEST_DIR)/selftest.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/selftest.o
-
-$(TEST_DIR)/spapr_hcall.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/spapr_hcall.o
-
-$(TEST_DIR)/rtas.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/rtas.o
-
-$(TEST_DIR)/emulator.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/emulator.o
--
2.4.11
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [kvm-unit-tests PATCH v2 1/2] arm/arm64: Makefile cleanup
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 1/2] arm/arm64: " Andrew Jones
@ 2016-05-10 17:03 ` Paolo Bonzini
2016-05-14 13:30 ` Wei Yang
1 sibling, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2016-05-10 17:03 UTC (permalink / raw)
To: Andrew Jones, kvm; +Cc: lvivier, thuth, richard.weiyang
On 10/05/2016 18:55, Andrew Jones wrote:
> This does the same cleanup as 'x86: Makefile refine'. .PRECIOUS
> is used (as opposed to .SECONDARY), because .SECONDARY doesn't
> accept target patterns.
Actually it should and, worst case, we could use .SECONDARY without
prerequisites. I'll change this to "doesn't seem to work reliably".
Paolo
> Signed-off-by: Andrew Jones <drjones@redhat.com>
> ---
> arm/Makefile.common | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arm/Makefile.common b/arm/Makefile.common
> index 9a2d61fc88a27..a786fcf94154f 100644
> --- a/arm/Makefile.common
> +++ b/arm/Makefile.common
> @@ -24,6 +24,9 @@ CFLAGS += -Wextra
> CFLAGS += -O2
> CFLAGS += -I lib -I lib/libfdt
>
> +# We want to keep intermediate files
> +.PRECIOUS: %.elf %.o
> +
> asm-offsets = lib/$(ARCH)/asm-offsets.h
> include scripts/asm-offsets.mak
>
> @@ -48,7 +51,7 @@ start_addr := $(shell printf "%x\n" $$(( $(phys_base) + $(kernel_offset) )))
>
> FLATLIBS = $(libcflat) $(LIBFDT_archive) $(libgcc) $(libeabi)
> %.elf: LDFLAGS = $(CFLAGS) -nostdlib
> -%.elf: %.o $(FLATLIBS) arm/flat.lds
> +%.elf: %.o $(FLATLIBS) arm/flat.lds $(cstart.o)
> $(CC) $(LDFLAGS) -o $@ \
> -Wl,-T,arm/flat.lds,--build-id=none,-Ttext=$(start_addr) \
> $(filter %.o, $^) $(FLATLIBS)
> @@ -69,7 +72,4 @@ generated_files = $(asm-offsets)
>
> test_cases: $(generated_files) $(tests-common) $(tests)
>
> -$(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
> -$(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
> -
> $(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets)
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kvm-unit-tests PATCH v2 0/2] arm/powerpc: Makefile cleanup
2016-05-10 16:55 [kvm-unit-tests PATCH v2 0/2] arm/powerpc: Makefile cleanup Andrew Jones
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 1/2] arm/arm64: " Andrew Jones
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 2/2] powerpc/ppc64: " Andrew Jones
@ 2016-05-10 17:04 ` Paolo Bonzini
2 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2016-05-10 17:04 UTC (permalink / raw)
To: Andrew Jones, kvm; +Cc: lvivier, thuth, richard.weiyang
On 10/05/2016 18:55, Andrew Jones wrote:
> Cleanup makefiles like 'x86: Makefile refine' does.
>
> v2:
> - no need for %.elf on powerpc patch
> - commit message points out why .PRECIOUS is used
>
> Andrew Jones (2):
> arm/arm64: Makefile cleanup
> powerpc/ppc64: Makefile cleanup
>
> arm/Makefile.common | 8 ++++----
> powerpc/Makefile.common | 13 ++++---------
> 2 files changed, 8 insertions(+), 13 deletions(-)
>
Applied, thanks.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kvm-unit-tests PATCH v2 1/2] arm/arm64: Makefile cleanup
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 1/2] arm/arm64: " Andrew Jones
2016-05-10 17:03 ` Paolo Bonzini
@ 2016-05-14 13:30 ` Wei Yang
2016-05-17 12:35 ` Paolo Bonzini
1 sibling, 1 reply; 10+ messages in thread
From: Wei Yang @ 2016-05-14 13:30 UTC (permalink / raw)
To: Andrew Jones; +Cc: kvm, lvivier, thuth, richard.weiyang, pbonzini
On Tue, May 10, 2016 at 06:55:43PM +0200, Andrew Jones wrote:
>This does the same cleanup as 'x86: Makefile refine'. .PRECIOUS
>is used (as opposed to .SECONDARY), because .SECONDARY doesn't
>accept target patterns.
>
>Signed-off-by: Andrew Jones <drjones@redhat.com>
Is it possible to add
Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
Now?
>---
> arm/Makefile.common | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/arm/Makefile.common b/arm/Makefile.common
>index 9a2d61fc88a27..a786fcf94154f 100644
>--- a/arm/Makefile.common
>+++ b/arm/Makefile.common
>@@ -24,6 +24,9 @@ CFLAGS += -Wextra
> CFLAGS += -O2
> CFLAGS += -I lib -I lib/libfdt
>
>+# We want to keep intermediate files
>+.PRECIOUS: %.elf %.o
>+
> asm-offsets = lib/$(ARCH)/asm-offsets.h
> include scripts/asm-offsets.mak
>
>@@ -48,7 +51,7 @@ start_addr := $(shell printf "%x\n" $$(( $(phys_base) + $(kernel_offset) )))
>
> FLATLIBS = $(libcflat) $(LIBFDT_archive) $(libgcc) $(libeabi)
> %.elf: LDFLAGS = $(CFLAGS) -nostdlib
>-%.elf: %.o $(FLATLIBS) arm/flat.lds
>+%.elf: %.o $(FLATLIBS) arm/flat.lds $(cstart.o)
> $(CC) $(LDFLAGS) -o $@ \
> -Wl,-T,arm/flat.lds,--build-id=none,-Ttext=$(start_addr) \
> $(filter %.o, $^) $(FLATLIBS)
>@@ -69,7 +72,4 @@ generated_files = $(asm-offsets)
>
> test_cases: $(generated_files) $(tests-common) $(tests)
>
>-$(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
>-$(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
>-
> $(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets)
>--
>2.4.11
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kvm-unit-tests PATCH v2 2/2] powerpc/ppc64: Makefile cleanup
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 2/2] powerpc/ppc64: " Andrew Jones
@ 2016-05-14 13:32 ` Wei Yang
0 siblings, 0 replies; 10+ messages in thread
From: Wei Yang @ 2016-05-14 13:32 UTC (permalink / raw)
To: Andrew Jones; +Cc: kvm, lvivier, thuth, richard.weiyang, pbonzini
On Tue, May 10, 2016 at 06:55:44PM +0200, Andrew Jones wrote:
>This does the same cleanup as 'x86: Makefile refine'. .PRECIOUS
>is used (as opposed to .SECONDARY), because .SECONDARY doesn't
>accept target patterns.
>
>Signed-off-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
Same as above.
>---
> powerpc/Makefile.common | 13 ++++---------
> 1 file changed, 4 insertions(+), 9 deletions(-)
>
>diff --git a/powerpc/Makefile.common b/powerpc/Makefile.common
>index 4449aec616853..4ff1dc8f48d32 100644
>--- a/powerpc/Makefile.common
>+++ b/powerpc/Makefile.common
>@@ -22,6 +22,9 @@ CFLAGS += -I lib -I lib/libfdt
> CFLAGS += -Wa,-mregnames
> CFLAGS += -fpie
>
>+# We want to keep intermediate files
>+.PRECIOUS: %.o
>+
> asm-offsets = lib/$(ARCH)/asm-offsets.h
> include scripts/asm-offsets.mak
>
>@@ -37,7 +40,7 @@ cflatobjs += lib/powerpc/processor.o
> FLATLIBS = $(libcflat) $(LIBFDT_archive)
> %.elf: CFLAGS += $(arch_CFLAGS)
> %.elf: LDFLAGS = $(arch_LDFLAGS) -nostdlib -pie
>-%.elf: %.o $(FLATLIBS) powerpc/flat.lds
>+%.elf: %.o $(FLATLIBS) powerpc/flat.lds $(cstart.o) $(reloc.o)
> $(LD) $(LDFLAGS) -o $@ \
> -T powerpc/flat.lds --build-id=none \
> $(filter %.o, $^) $(FLATLIBS)
>@@ -69,11 +72,3 @@ generated_files = $(asm-offsets)
> test_cases: $(generated_files) $(tests-common) $(tests)
>
> $(cstart.o): $(asm-offsets)
>-
>-$(TEST_DIR)/selftest.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/selftest.o
>-
>-$(TEST_DIR)/spapr_hcall.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/spapr_hcall.o
>-
>-$(TEST_DIR)/rtas.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/rtas.o
>-
>-$(TEST_DIR)/emulator.elf: $(cstart.o) $(reloc.o) $(TEST_DIR)/emulator.o
>--
>2.4.11
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kvm-unit-tests PATCH v2 1/2] arm/arm64: Makefile cleanup
2016-05-14 13:30 ` Wei Yang
@ 2016-05-17 12:35 ` Paolo Bonzini
2016-05-18 22:40 ` Wei Yang
0 siblings, 1 reply; 10+ messages in thread
From: Paolo Bonzini @ 2016-05-17 12:35 UTC (permalink / raw)
To: Wei Yang, Andrew Jones; +Cc: kvm, lvivier, thuth
On 14/05/2016 15:30, Wei Yang wrote:
> On Tue, May 10, 2016 at 06:55:43PM +0200, Andrew Jones wrote:
>> This does the same cleanup as 'x86: Makefile refine'. .PRECIOUS
>> is used (as opposed to .SECONDARY), because .SECONDARY doesn't
>> accept target patterns.
>>
>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>
> Is it possible to add
>
> Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
Too late, sorry; the commit has been pushed already.
Paolo
> Now?
>
>> ---
>> arm/Makefile.common | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/arm/Makefile.common b/arm/Makefile.common
>> index 9a2d61fc88a27..a786fcf94154f 100644
>> --- a/arm/Makefile.common
>> +++ b/arm/Makefile.common
>> @@ -24,6 +24,9 @@ CFLAGS += -Wextra
>> CFLAGS += -O2
>> CFLAGS += -I lib -I lib/libfdt
>>
>> +# We want to keep intermediate files
>> +.PRECIOUS: %.elf %.o
>> +
>> asm-offsets = lib/$(ARCH)/asm-offsets.h
>> include scripts/asm-offsets.mak
>>
>> @@ -48,7 +51,7 @@ start_addr := $(shell printf "%x\n" $$(( $(phys_base) + $(kernel_offset) )))
>>
>> FLATLIBS = $(libcflat) $(LIBFDT_archive) $(libgcc) $(libeabi)
>> %.elf: LDFLAGS = $(CFLAGS) -nostdlib
>> -%.elf: %.o $(FLATLIBS) arm/flat.lds
>> +%.elf: %.o $(FLATLIBS) arm/flat.lds $(cstart.o)
>> $(CC) $(LDFLAGS) -o $@ \
>> -Wl,-T,arm/flat.lds,--build-id=none,-Ttext=$(start_addr) \
>> $(filter %.o, $^) $(FLATLIBS)
>> @@ -69,7 +72,4 @@ generated_files = $(asm-offsets)
>>
>> test_cases: $(generated_files) $(tests-common) $(tests)
>>
>> -$(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
>> -$(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
>> -
>> $(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets)
>> --
>> 2.4.11
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kvm-unit-tests PATCH v2 1/2] arm/arm64: Makefile cleanup
2016-05-17 12:35 ` Paolo Bonzini
@ 2016-05-18 22:40 ` Wei Yang
2016-05-19 10:35 ` Paolo Bonzini
0 siblings, 1 reply; 10+ messages in thread
From: Wei Yang @ 2016-05-18 22:40 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: Wei Yang, Andrew Jones, kvm, lvivier, thuth
On Tue, May 17, 2016 at 02:35:21PM +0200, Paolo Bonzini wrote:
>
>
>On 14/05/2016 15:30, Wei Yang wrote:
>> On Tue, May 10, 2016 at 06:55:43PM +0200, Andrew Jones wrote:
>>> This does the same cleanup as 'x86: Makefile refine'. .PRECIOUS
>>> is used (as opposed to .SECONDARY), because .SECONDARY doesn't
>>> accept target patterns.
>>>
>>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>>
>> Is it possible to add
>>
>> Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
>
>Too late, sorry; the commit has been pushed already.
>
OK, that's fine.
BTW, do I need to reply with Reviewed-by in each patch version? I thought just
reply to one of it and the following versions would contain it. Or I missed
the rule?
>Paolo
>
>> Now?
>>
>>> ---
>>> arm/Makefile.common | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/arm/Makefile.common b/arm/Makefile.common
>>> index 9a2d61fc88a27..a786fcf94154f 100644
>>> --- a/arm/Makefile.common
>>> +++ b/arm/Makefile.common
>>> @@ -24,6 +24,9 @@ CFLAGS += -Wextra
>>> CFLAGS += -O2
>>> CFLAGS += -I lib -I lib/libfdt
>>>
>>> +# We want to keep intermediate files
>>> +.PRECIOUS: %.elf %.o
>>> +
>>> asm-offsets = lib/$(ARCH)/asm-offsets.h
>>> include scripts/asm-offsets.mak
>>>
>>> @@ -48,7 +51,7 @@ start_addr := $(shell printf "%x\n" $$(( $(phys_base) + $(kernel_offset) )))
>>>
>>> FLATLIBS = $(libcflat) $(LIBFDT_archive) $(libgcc) $(libeabi)
>>> %.elf: LDFLAGS = $(CFLAGS) -nostdlib
>>> -%.elf: %.o $(FLATLIBS) arm/flat.lds
>>> +%.elf: %.o $(FLATLIBS) arm/flat.lds $(cstart.o)
>>> $(CC) $(LDFLAGS) -o $@ \
>>> -Wl,-T,arm/flat.lds,--build-id=none,-Ttext=$(start_addr) \
>>> $(filter %.o, $^) $(FLATLIBS)
>>> @@ -69,7 +72,4 @@ generated_files = $(asm-offsets)
>>>
>>> test_cases: $(generated_files) $(tests-common) $(tests)
>>>
>>> -$(TEST_DIR)/selftest.elf: $(cstart.o) $(TEST_DIR)/selftest.o
>>> -$(TEST_DIR)/spinlock-test.elf: $(cstart.o) $(TEST_DIR)/spinlock-test.o
>>> -
>>> $(TEST_DIR)/selftest.o $(cstart.o): $(asm-offsets)
>>> --
>>> 2.4.11
>>
--
Wei Yang
Help you, Help me
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [kvm-unit-tests PATCH v2 1/2] arm/arm64: Makefile cleanup
2016-05-18 22:40 ` Wei Yang
@ 2016-05-19 10:35 ` Paolo Bonzini
0 siblings, 0 replies; 10+ messages in thread
From: Paolo Bonzini @ 2016-05-19 10:35 UTC (permalink / raw)
To: Wei Yang; +Cc: Andrew Jones, kvm, lvivier, thuth
On 19/05/2016 00:40, Wei Yang wrote:
> On Tue, May 17, 2016 at 02:35:21PM +0200, Paolo Bonzini wrote:
>>
>>
>> On 14/05/2016 15:30, Wei Yang wrote:
>>> On Tue, May 10, 2016 at 06:55:43PM +0200, Andrew Jones wrote:
>>>> This does the same cleanup as 'x86: Makefile refine'. .PRECIOUS
>>>> is used (as opposed to .SECONDARY), because .SECONDARY doesn't
>>>> accept target patterns.
>>>>
>>>> Signed-off-by: Andrew Jones <drjones@redhat.com>
>>>
>>> Is it possible to add
>>>
>>> Reviewed-by: Wei Yang <richard.weiyang@gmail.com>
>>
>> Too late, sorry; the commit has been pushed already.
>>
>
> OK, that's fine.
>
> BTW, do I need to reply with Reviewed-by in each patch version? I thought just
> reply to one of it and the following versions would contain it. Or I missed
> the rule?
Usually it's enough to reply once. However, the submitter may drop
Reviewed-by tags if he/she believes that there were large changes
compared to the reviewed version; or they might just forget to add it.
Paolo
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-05-19 10:35 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-05-10 16:55 [kvm-unit-tests PATCH v2 0/2] arm/powerpc: Makefile cleanup Andrew Jones
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 1/2] arm/arm64: " Andrew Jones
2016-05-10 17:03 ` Paolo Bonzini
2016-05-14 13:30 ` Wei Yang
2016-05-17 12:35 ` Paolo Bonzini
2016-05-18 22:40 ` Wei Yang
2016-05-19 10:35 ` Paolo Bonzini
2016-05-10 16:55 ` [kvm-unit-tests PATCH v2 2/2] powerpc/ppc64: " Andrew Jones
2016-05-14 13:32 ` Wei Yang
2016-05-10 17:04 ` [kvm-unit-tests PATCH v2 0/2] arm/powerpc: " Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.