From: Daniel Borkmann <daniel@iogearbox.net>
To: Alakesh Haloi <alakesh.haloi@gmail.com>,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Shuah Khan <shuah@kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>,
Yonghong Song <yhs@fb.com>, Stanislav Fomichev <sdf@google.com>
Subject: Re: [PATCH bpf v2] selftests: bpf: fix compiler warning
Date: Wed, 29 May 2019 16:07:18 +0200 [thread overview]
Message-ID: <f78082c5-6fd9-611d-0da3-969f076a97f8@iogearbox.net> (raw)
In-Reply-To: <20190528190218.GA6950@ip-172-31-44-144.us-west-2.compute.internal>
On 05/28/2019 09:02 PM, Alakesh Haloi wrote:
> Add missing header file following compiler warning
>
> prog_tests/flow_dissector.c: In function ‘tx_tap’:
> prog_tests/flow_dissector.c:175:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration]
> return writev(fd, iov, ARRAY_SIZE(iov));
> ^~~~~~
> write
>
> Fixes: 0905beec9f52 ("selftests/bpf: run flow dissector tests in skb-less mode")
> Signed-off-by: Alakesh Haloi <alakesh.haloi@gmail.com>
Applied, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: daniel at iogearbox.net (Daniel Borkmann)
Subject: [PATCH bpf v2] selftests: bpf: fix compiler warning
Date: Wed, 29 May 2019 16:07:18 +0200 [thread overview]
Message-ID: <f78082c5-6fd9-611d-0da3-969f076a97f8@iogearbox.net> (raw)
In-Reply-To: <20190528190218.GA6950@ip-172-31-44-144.us-west-2.compute.internal>
On 05/28/2019 09:02 PM, Alakesh Haloi wrote:
> Add missing header file following compiler warning
>
> prog_tests/flow_dissector.c: In function ‘tx_tap’:
> prog_tests/flow_dissector.c:175:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration]
> return writev(fd, iov, ARRAY_SIZE(iov));
> ^~~~~~
> write
>
> Fixes: 0905beec9f52 ("selftests/bpf: run flow dissector tests in skb-less mode")
> Signed-off-by: Alakesh Haloi <alakesh.haloi at gmail.com>
Applied, thanks!
WARNING: multiple messages have this Message-ID (diff)
From: daniel@iogearbox.net (Daniel Borkmann)
Subject: [PATCH bpf v2] selftests: bpf: fix compiler warning
Date: Wed, 29 May 2019 16:07:18 +0200 [thread overview]
Message-ID: <f78082c5-6fd9-611d-0da3-969f076a97f8@iogearbox.net> (raw)
Message-ID: <20190529140718.77Hs4OZrPXOBtS0sgeScphuET4ropEecvipXaKQANYE@z> (raw)
In-Reply-To: <20190528190218.GA6950@ip-172-31-44-144.us-west-2.compute.internal>
On 05/28/2019 09:02 PM, Alakesh Haloi wrote:
> Add missing header file following compiler warning
>
> prog_tests/flow_dissector.c: In function ‘tx_tap’:
> prog_tests/flow_dissector.c:175:9: warning: implicit declaration of function ‘writev’; did you mean ‘write’? [-Wimplicit-function-declaration]
> return writev(fd, iov, ARRAY_SIZE(iov));
> ^~~~~~
> write
>
> Fixes: 0905beec9f52 ("selftests/bpf: run flow dissector tests in skb-less mode")
> Signed-off-by: Alakesh Haloi <alakesh.haloi at gmail.com>
Applied, thanks!
next prev parent reply other threads:[~2019-05-29 14:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 19:02 [PATCH bpf v2] selftests: bpf: fix compiler warning Alakesh Haloi
2019-05-28 19:02 ` Alakesh Haloi
2019-05-28 19:02 ` alakesh.haloi
2019-05-28 20:57 ` Song Liu
2019-05-28 20:57 ` Song Liu
2019-05-28 20:57 ` liu.song.a23
2019-05-29 14:07 ` Daniel Borkmann [this message]
2019-05-29 14:07 ` Daniel Borkmann
2019-05-29 14:07 ` daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f78082c5-6fd9-611d-0da3-969f076a97f8@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=alakesh.haloi@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=kafai@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.