* kselftest-merge misses config's to merge
@ 2018-08-10 8:50 ` Anders Roxell
0 siblings, 0 replies; 6+ messages in thread
From: anders.roxell @ 2018-08-10 8:50 UTC (permalink / raw)
Hi,
I have a question about the config files in tools/testing/selftests/ .
The kselftest-merge target in the root Makefile assumes that the
config files are placed in
tools/testing/selftests/*/config and selftests/android/ion/config and
selftests/net/forwarding/config doesn't follow that. So either we move
those files up a level or do something like below in the top Makefile.
diff --git a/Makefile b/Makefile
index c88d56de7fda..06aeeca16917 100644
--- a/Makefile
+++ b/Makefile
@@ -1188,12 +1188,13 @@ PHONY += kselftest-clean
kselftest-clean:
$(Q)$(MAKE) -C $(srctree)/tools/testing/selftests clean
+KSFT_CONFIGS=$(shell find $(srctree)/tools/testing/selftests/ -type f
-name config)
PHONY += kselftest-merge
kselftest-merge:
$(if $(wildcard $(objtree)/.config),, $(error No .config exists,
config your kernel first!))
$(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh \
-m $(objtree)/.config \
- $(srctree)/tools/testing/selftests/*/config
+ $(KSFT_CONFIGS)
+$(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig
# ---------------------------------------------------------------------------
or do you have another way to solve this?
Cheers,
Anders
^ permalink raw reply related [flat|nested] 6+ messages in thread
* kselftest-merge misses config's to merge
@ 2018-08-10 8:50 ` Anders Roxell
0 siblings, 0 replies; 6+ messages in thread
From: Anders Roxell @ 2018-08-10 8:50 UTC (permalink / raw)
Hi,
I have a question about the config files in tools/testing/selftests/ .
The kselftest-merge target in the root Makefile assumes that the
config files are placed in
tools/testing/selftests/*/config and selftests/android/ion/config and
selftests/net/forwarding/config doesn't follow that. So either we move
those files up a level or do something like below in the top Makefile.
diff --git a/Makefile b/Makefile
index c88d56de7fda..06aeeca16917 100644
--- a/Makefile
+++ b/Makefile
@@ -1188,12 +1188,13 @@ PHONY += kselftest-clean
kselftest-clean:
$(Q)$(MAKE) -C $(srctree)/tools/testing/selftests clean
+KSFT_CONFIGS=$(shell find $(srctree)/tools/testing/selftests/ -type f
-name config)
PHONY += kselftest-merge
kselftest-merge:
$(if $(wildcard $(objtree)/.config),, $(error No .config exists,
config your kernel first!))
$(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh \
-m $(objtree)/.config \
- $(srctree)/tools/testing/selftests/*/config
+ $(KSFT_CONFIGS)
+$(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig
# ---------------------------------------------------------------------------
or do you have another way to solve this?
Cheers,
Anders
^ permalink raw reply related [flat|nested] 6+ messages in thread
* kselftest-merge misses config's to merge
@ 2018-08-17 17:15 ` Anders Roxell
0 siblings, 0 replies; 6+ messages in thread
From: anders.roxell @ 2018-08-17 17:15 UTC (permalink / raw)
On Fri, 10 Aug 2018 at 10:50, Anders Roxell <anders.roxell at linaro.org> wrote:
>
> Hi,
>
> I have a question about the config files in tools/testing/selftests/ .
> The kselftest-merge target in the root Makefile assumes that the
> config files are placed in
> tools/testing/selftests/*/config and selftests/android/ion/config and
> selftests/net/forwarding/config doesn't follow that. So either we move
> those files up a level or do something like below in the top Makefile.
>
> diff --git a/Makefile b/Makefile
> index c88d56de7fda..06aeeca16917 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1188,12 +1188,13 @@ PHONY += kselftest-clean
> kselftest-clean:
> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests clean
>
> +KSFT_CONFIGS=$(shell find $(srctree)/tools/testing/selftests/ -type f
> -name config)
> PHONY += kselftest-merge
> kselftest-merge:
> $(if $(wildcard $(objtree)/.config),, $(error No .config exists,
> config your kernel first!))
> $(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh \
> -m $(objtree)/.config \
> - $(srctree)/tools/testing/selftests/*/config
> + $(KSFT_CONFIGS)
> +$(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig
>
> # ---------------------------------------------------------------------------
>
>
> or do you have another way to solve this?
I will be happy to add it to the documentation in
Documentation/dev-tools/kselftest.rst with what we say if it
is needed.
Cheers,
Anders
^ permalink raw reply [flat|nested] 6+ messages in thread
* kselftest-merge misses config's to merge
@ 2018-08-17 17:15 ` Anders Roxell
0 siblings, 0 replies; 6+ messages in thread
From: Anders Roxell @ 2018-08-17 17:15 UTC (permalink / raw)
On Fri, 10 Aug 2018@10:50, Anders Roxell <anders.roxell@linaro.org> wrote:
>
> Hi,
>
> I have a question about the config files in tools/testing/selftests/ .
> The kselftest-merge target in the root Makefile assumes that the
> config files are placed in
> tools/testing/selftests/*/config and selftests/android/ion/config and
> selftests/net/forwarding/config doesn't follow that. So either we move
> those files up a level or do something like below in the top Makefile.
>
> diff --git a/Makefile b/Makefile
> index c88d56de7fda..06aeeca16917 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1188,12 +1188,13 @@ PHONY += kselftest-clean
> kselftest-clean:
> $(Q)$(MAKE) -C $(srctree)/tools/testing/selftests clean
>
> +KSFT_CONFIGS=$(shell find $(srctree)/tools/testing/selftests/ -type f
> -name config)
> PHONY += kselftest-merge
> kselftest-merge:
> $(if $(wildcard $(objtree)/.config),, $(error No .config exists,
> config your kernel first!))
> $(Q)$(CONFIG_SHELL) $(srctree)/scripts/kconfig/merge_config.sh \
> -m $(objtree)/.config \
> - $(srctree)/tools/testing/selftests/*/config
> + $(KSFT_CONFIGS)
> +$(Q)$(MAKE) -f $(srctree)/Makefile olddefconfig
>
> # ---------------------------------------------------------------------------
>
>
> or do you have another way to solve this?
I will be happy to add it to the documentation in
Documentation/dev-tools/kselftest.rst with what we say if it
is needed.
Cheers,
Anders
^ permalink raw reply [flat|nested] 6+ messages in thread
* kselftest-merge misses config's to merge
@ 2018-08-20 15:01 ` Shuah Khan
0 siblings, 0 replies; 6+ messages in thread
From: shuah @ 2018-08-20 15:01 UTC (permalink / raw)
Hi Anders,
On 08/17/2018 11:15 AM, Anders Roxell wrote:
> On Fri, 10 Aug 2018 at 10:50, Anders Roxell <anders.roxell at linaro.org> wrote:
>>
>> Hi,
>>
>> I have a question about the config files in tools/testing/selftests/ .
>> The kselftest-merge target in the root Makefile assumes that the
>> config files are placed in
>> tools/testing/selftests/*/config and selftests/android/ion/config and
>> selftests/net/forwarding/config doesn't follow that. So either we move
>> those files up a level or do something like below in the top Makefile.
Let's move them up to where they need to be and document it as well.
Sorry for the late reply. I was out on vacation all of last week.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 6+ messages in thread
* kselftest-merge misses config's to merge
@ 2018-08-20 15:01 ` Shuah Khan
0 siblings, 0 replies; 6+ messages in thread
From: Shuah Khan @ 2018-08-20 15:01 UTC (permalink / raw)
Hi Anders,
On 08/17/2018 11:15 AM, Anders Roxell wrote:
> On Fri, 10 Aug 2018@10:50, Anders Roxell <anders.roxell@linaro.org> wrote:
>>
>> Hi,
>>
>> I have a question about the config files in tools/testing/selftests/ .
>> The kselftest-merge target in the root Makefile assumes that the
>> config files are placed in
>> tools/testing/selftests/*/config and selftests/android/ion/config and
>> selftests/net/forwarding/config doesn't follow that. So either we move
>> those files up a level or do something like below in the top Makefile.
Let's move them up to where they need to be and document it as well.
Sorry for the late reply. I was out on vacation all of last week.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-08-20 15:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-10 8:50 kselftest-merge misses config's to merge anders.roxell
2018-08-10 8:50 ` Anders Roxell
2018-08-17 17:15 ` anders.roxell
2018-08-17 17:15 ` Anders Roxell
2018-08-20 15:01 ` shuah
2018-08-20 15:01 ` Shuah Khan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.