* [PATCH] leds: aat1290: Remove an unused field in struct aat1290_led
@ 2024-04-28 15:34 Christophe JAILLET
2024-05-02 17:09 ` (subset) " Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Christophe JAILLET @ 2024-04-28 15:34 UTC (permalink / raw)
To: Pavel Machek, Lee Jones
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, linux-leds
In "struct aat1290_led", the 'torch_brightness' field is unused.
Remove it.
Found with cppcheck, unusedStructMember.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
Compile tested only.
It was added added in commit 49c34b8e0f43 ("leds: Add driver for AAT1290
flash LED controller") and its only user was removed in commit 269e92da8b07
("leds: aat1290: Remove work queue").
---
drivers/leds/flash/leds-aat1290.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/leds/flash/leds-aat1290.c b/drivers/leds/flash/leds-aat1290.c
index 0195935a7c99..e8f9dd293592 100644
--- a/drivers/leds/flash/leds-aat1290.c
+++ b/drivers/leds/flash/leds-aat1290.c
@@ -77,8 +77,6 @@ struct aat1290_led {
int *mm_current_scale;
/* device mode */
bool movie_mode;
- /* brightness cache */
- unsigned int torch_brightness;
};
static struct aat1290_led *fled_cdev_to_led(
--
2.44.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: (subset) [PATCH] leds: aat1290: Remove an unused field in struct aat1290_led
2024-04-28 15:34 [PATCH] leds: aat1290: Remove an unused field in struct aat1290_led Christophe JAILLET
@ 2024-05-02 17:09 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2024-05-02 17:09 UTC (permalink / raw)
To: Pavel Machek, Lee Jones, Christophe JAILLET
Cc: linux-kernel, kernel-janitors, linux-leds
On Sun, 28 Apr 2024 17:34:55 +0200, Christophe JAILLET wrote:
> In "struct aat1290_led", the 'torch_brightness' field is unused.
> Remove it.
>
> Found with cppcheck, unusedStructMember.
>
>
Applied, thanks!
[1/1] leds: aat1290: Remove an unused field in struct aat1290_led
commit: 678ba7d25467c06850d0d2922108573ea7346a48
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-02 17:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-28 15:34 [PATCH] leds: aat1290: Remove an unused field in struct aat1290_led Christophe JAILLET
2024-05-02 17:09 ` (subset) " Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.