All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dilip Kota <eswara.kota@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: gustavo.pimentel@synopsys.com, lorenzo.pieralisi@arm.com,
	andrew.murray@arm.com, helgaas@kernel.org, jingoohan1@gmail.com,
	robh@kernel.org, martin.blumenstingl@googlemail.com,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, cheol.yong.kim@intel.com,
	chuanhua.lei@linux.intel.com, qi-ming.wu@intel.com
Subject: Re: [PATCH v5 2/3] dwc: PCI: intel: PCIe RC controller driver
Date: Tue, 12 Nov 2019 15:18:07 +0800	[thread overview]
Message-ID: <f7d2c4e6-101d-5f52-f3df-6adb0c8b8396@linux.intel.com> (raw)
In-Reply-To: <eee3e6ee-fd55-9c88-a628-34f883b19988@linux.intel.com>


On 11/11/2019 4:08 PM, Dilip Kota wrote:
>
> On 11/6/2019 8:24 PM, Andy Shevchenko wrote:
>> On Wed, Nov 06, 2019 at 11:44:02AM +0800, Dilip Kota wrote:
[...]
>>
>>> +    return ret;
>>> +}
>>> +    platform_set_drvdata(pdev, lpp);
>> I think it makes sense to setup at the end of the function (before 
>> dev_info()
>> call).
> I have done it immediately after the memory allocation.
> Ok, i will move it before dev_info().
>
I ran test with all the changes and kernel panic is hit due to NULL 
pointer access. It is because of platform_set_drvdata() moved before 
dev_info, which resulted in  intel_pcie_get_resources()  doing 
platform_get_drvdata and end up accessing NULL pointer. I will keep 
'platform_set_drvdata()' remain unchanged.

Regards,
Dilip

  reply	other threads:[~2019-11-12  7:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-06  3:44 [PATCH v5 0/3] PCI: Add Intel PCIe Driver and respective dt-binding yaml file Dilip Kota
2019-11-06  3:44 ` [PATCH v5 1/3] dt-bindings: PCI: intel: Add YAML schemas for the PCIe RC controller Dilip Kota
2019-11-12 19:17   ` Rob Herring
2019-11-13  2:39     ` Dilip Kota
2019-11-06  3:44 ` [PATCH v5 2/3] dwc: PCI: intel: PCIe RC controller driver Dilip Kota
2019-11-06 12:24   ` Andy Shevchenko
2019-11-11  8:08     ` Dilip Kota
2019-11-12  7:18       ` Dilip Kota [this message]
2019-11-08 10:42   ` Andrew Murray
2019-11-11  8:09     ` Dilip Kota
2019-11-06  3:44 ` [PATCH v5 3/3] PCI: artpec6: Configure FTS with dwc helper function Dilip Kota
2019-11-06  9:43   ` Gustavo Pimentel
2019-11-11  6:24     ` Dilip Kota
2019-11-07 21:03   ` Jingoo Han
2019-11-08 10:43     ` Andrew Murray
2019-11-11  8:10       ` Dilip Kota
2019-11-11  8:09     ` Dilip Kota

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7d2c4e6-101d-5f52-f3df-6adb0c8b8396@linux.intel.com \
    --to=eswara.kota@linux.intel.com \
    --cc=andrew.murray@arm.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=cheol.yong.kim@intel.com \
    --cc=chuanhua.lei@linux.intel.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gustavo.pimentel@synopsys.com \
    --cc=helgaas@kernel.org \
    --cc=jingoohan1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=qi-ming.wu@intel.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.