Re: [OE-core] [PATCH] python3-native: Drop opt-1 and opt-2 pyc files

Re: [OE-core] [PATCH] python3-native: Drop opt-1 and opt-2 pyc files

[Richard Purdie]

On Thu, 2022-03-03 at 14:28 +0000, Richard Purdie via lists.openembedded.org
wrote:
> There are over 3,000 of these in python3-native (of 8,000+ files total) and
> copying them to sysroots all the time seems pointless, particularly since
> they're only used if python is run with the -O or -OO parameters.
> 
> Get rid of them and save the overhead. This is particularly pronounced in
> builds using the api-documentation distro feature.
> 
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> ---
>  meta/recipes-devtools/python/python3_3.10.2.bb | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/meta/recipes-devtools/python/python3_3.10.2.bb b/meta/recipes-devtools/python/python3_3.10.2.bb
> index 429839b6226..b28aa6505a0 100644
> --- a/meta/recipes-devtools/python/python3_3.10.2.bb
> +++ b/meta/recipes-devtools/python/python3_3.10.2.bb
> @@ -152,6 +152,11 @@ do_install:append:class-native() {
>          # (these often end up too long for the #! parser in the kernel as the
>          # buffer is 128 bytes long).
>          ln -s python3-native/python3 ${D}${bindir}/nativepython3
> +
> +        # Remove the opt-1.pyc and opt-2.pyc files. There are over 3,000 of them
> +        # and the overhead in each recipe-sysroot-native isn't worth it, particularly
> +        # when they're only used for python called with -O or -OO.
> +        find ${D} -name *opt-*.pyc -delete
>  }
>  
>  do_install:append() {
> 

This does pose an interesting dilemma. We could just go this far, or should we
remove the remaining pyc files (~1,500 of them) and let python create them as
needed, or do we disable them from python entirely?

Cheers,

Richard

Re: [OE-core] [PATCH] python3-native: Drop opt-1 and opt-2 pyc files

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 2504 bytes --]

Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia quinta,
3/03/2022 à(s) 14:37:

> On Thu, 2022-03-03 at 14:28 +0000, Richard Purdie via
> lists.openembedded.org
> wrote:
> > There are over 3,000 of these in python3-native (of 8,000+ files total)
> and
> > copying them to sysroots all the time seems pointless, particularly since
> > they're only used if python is run with the -O or -OO parameters.
> >
> > Get rid of them and save the overhead. This is particularly pronounced in
> > builds using the api-documentation distro feature.
> >
> > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > ---
> >  meta/recipes-devtools/python/python3_3.10.2.bb | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/meta/recipes-devtools/python/python3_3.10.2.bb
> b/meta/recipes-devtools/python/python3_3.10.2.bb
> > index 429839b6226..b28aa6505a0 100644
> > --- a/meta/recipes-devtools/python/python3_3.10.2.bb
> > +++ b/meta/recipes-devtools/python/python3_3.10.2.bb
> > @@ -152,6 +152,11 @@ do_install:append:class-native() {
> >          # (these often end up too long for the #! parser in the kernel
> as the
> >          # buffer is 128 bytes long).
> >          ln -s python3-native/python3 ${D}${bindir}/nativepython3
> > +
> > +        # Remove the opt-1.pyc and opt-2.pyc files. There are over
> 3,000 of them
> > +        # and the overhead in each recipe-sysroot-native isn't worth
> it, particularly
> > +        # when they're only used for python called with -O or -OO.
> > +        find ${D} -name *opt-*.pyc -delete
> >  }
> >
> >  do_install:append() {
> >
>
> This does pose an interesting dilemma. We could just go this far, or
> should we
> remove the remaining pyc files (~1,500 of them) and let python create them
> as
> needed, or do we disable them from python entirely?
>

I think that for native recipes it can be created at runtime as needed.

Jose


> Cheers,
>
> Richard
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#162656):
> https://lists.openembedded.org/g/openembedded-core/message/162656
> Mute This Topic: https://lists.openembedded.org/mt/89525809/5052612
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> quaresma.jose@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Best regards,

José Quaresma

[-- Attachment #2: Type: text/html, Size: 4308 bytes --]