From: Doug Goldstein <cardoe@cardoe.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [PATCH for-4.7 1/7] tools/xenstat: Avoid comparing '0 <= unsigned integer'
Date: Wed, 27 Apr 2016 14:18:02 -0500 [thread overview]
Message-ID: <f7d9cbfc-c133-2528-49ec-7fcc0cf59f9c@cardoe.com> (raw)
In-Reply-To: <1461776486-31484-2-git-send-email-andrew.cooper3@citrix.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 446 bytes --]
On 4/27/16 12:01 PM, Andrew Cooper wrote:
> Clang points out that this is tautological.
>
> src/xenstat.c:325:8: warning: comparison of 0 <= unsigned expression is
> always true [-Wtautological-compare]
> if (0 <= index && index < node->num_domains)
> ~ ^ ~~~~~
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
--
Doug Goldstein
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 959 bytes --]
[-- Attachment #2: Type: text/plain, Size: 126 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-04-27 19:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 17:01 [PATCH for-4.7 0/7] More tools build fixes with clang Andrew Cooper
2016-04-27 17:01 ` [PATCH for-4.7 1/7] tools/xenstat: Avoid comparing '0 <= unsigned integer' Andrew Cooper
2016-04-27 18:00 ` Wei Liu
2016-04-27 19:18 ` Doug Goldstein [this message]
2016-04-27 17:01 ` [PATCH for-4.7 2/7] tools/blktap2: Use abort() instead of custom crash Andrew Cooper
2016-04-27 18:00 ` Wei Liu
2016-04-27 19:17 ` Doug Goldstein
2016-04-27 17:01 ` [PATCH for-4.7 3/7] tools/blktap2: Fix array initialisers for tapdisk_disk_{types, drivers}[] Andrew Cooper
2016-04-27 18:00 ` Wei Liu
2016-04-27 19:16 ` Doug Goldstein
2016-04-27 17:01 ` [PATCH for-4.7 4/7] tools/blktap2: Fix use of uninitialised variable in _tap_list_join3() Andrew Cooper
2016-04-27 18:00 ` Wei Liu
2016-04-27 19:16 ` Doug Goldstein
2016-04-27 17:01 ` [PATCH for-4.7 5/7] tools/kdd: Fix uninitialised variable warning Andrew Cooper
2016-04-27 18:01 ` Wei Liu
2016-04-27 19:15 ` Doug Goldstein
2016-04-27 17:01 ` [PATCH for-4.7 6/7] travis: Remove clang-3.8 build Andrew Cooper
2016-04-27 18:02 ` Wei Liu
2016-04-27 19:13 ` Doug Goldstein
2016-04-27 17:01 ` [PATCH for-4.7 7/7] travis: Enable tools when building with clang Andrew Cooper
2016-04-27 18:03 ` Wei Liu
2016-04-27 19:14 ` Doug Goldstein
2016-04-27 18:04 ` [PATCH for-4.7 0/7] More tools build fixes " Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7d9cbfc-c133-2528-49ec-7fcc0cf59f9c@cardoe.com \
--to=cardoe@cardoe.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.