[PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map

[PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map

[Paul Durrant]

Commit e3b93b3c595 "dmop: add xendevicemodel_modified_memory_bulk()" added
the implementation to the library almost 2 years ago, but the function
was not included in the map file, essentially making it useless. This
patch rectifies the situation.

Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 tools/libs/devicemodel/Makefile              | 2 +-
 tools/libs/devicemodel/libxendevicemodel.map | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/tools/libs/devicemodel/Makefile b/tools/libs/devicemodel/Makefile
index 5b2df7a18e..73cff6dbc4 100644
--- a/tools/libs/devicemodel/Makefile
+++ b/tools/libs/devicemodel/Makefile
@@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../..
 include $(XEN_ROOT)/tools/Rules.mk
 
 MAJOR    = 1
-MINOR    = 2
+MINOR    = 3
 SHLIB_LDFLAGS += -Wl,--version-script=libxendevicemodel.map
 
 CFLAGS   += -Werror -Wmissing-prototypes
diff --git a/tools/libs/devicemodel/libxendevicemodel.map b/tools/libs/devicemodel/libxendevicemodel.map
index 04797b239d..561c62deb4 100644
--- a/tools/libs/devicemodel/libxendevicemodel.map
+++ b/tools/libs/devicemodel/libxendevicemodel.map
@@ -33,3 +33,8 @@ VERS_1.2 {
 		xendevicemodel_relocate_memory;
 		xendevicemodel_pin_memory_cacheattr;
 } VERS_1.1;
+
+VERS_1.3 {
+	global:
+		xendevicemodel_modified_memory_bulk;
+} VERS_1.2;
-- 
2.20.1.2.gb21ebb671


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map

[Paul Durrant]

Cc-ing Juergen, in case this can make 4.12...

> -----Original Message-----
> From: Paul Durrant [mailto:paul.durrant@citrix.com]
> Sent: 15 February 2019 10:02
> To: xen-devel@lists.xenproject.org
> Cc: Paul Durrant <Paul.Durrant@citrix.com>; Ian Jackson
> <Ian.Jackson@citrix.com>; Wei Liu <wei.liu2@citrix.com>
> Subject: [PATCH] tools/libxendevicemodel: add
> xendevicemodel_modified_memory_bulk to map
> 
> Commit e3b93b3c595 "dmop: add xendevicemodel_modified_memory_bulk()" added
> the implementation to the library almost 2 years ago, but the function
> was not included in the map file, essentially making it useless. This
> patch rectifies the situation.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>  tools/libs/devicemodel/Makefile              | 2 +-
>  tools/libs/devicemodel/libxendevicemodel.map | 5 +++++
>  2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/libs/devicemodel/Makefile
> b/tools/libs/devicemodel/Makefile
> index 5b2df7a18e..73cff6dbc4 100644
> --- a/tools/libs/devicemodel/Makefile
> +++ b/tools/libs/devicemodel/Makefile
> @@ -2,7 +2,7 @@ XEN_ROOT = $(CURDIR)/../../..
>  include $(XEN_ROOT)/tools/Rules.mk
> 
>  MAJOR    = 1
> -MINOR    = 2
> +MINOR    = 3
>  SHLIB_LDFLAGS += -Wl,--version-script=libxendevicemodel.map
> 
>  CFLAGS   += -Werror -Wmissing-prototypes
> diff --git a/tools/libs/devicemodel/libxendevicemodel.map
> b/tools/libs/devicemodel/libxendevicemodel.map
> index 04797b239d..561c62deb4 100644
> --- a/tools/libs/devicemodel/libxendevicemodel.map
> +++ b/tools/libs/devicemodel/libxendevicemodel.map
> @@ -33,3 +33,8 @@ VERS_1.2 {
>  		xendevicemodel_relocate_memory;
>  		xendevicemodel_pin_memory_cacheattr;
>  } VERS_1.1;
> +
> +VERS_1.3 {
> +	global:
> +		xendevicemodel_modified_memory_bulk;
> +} VERS_1.2;
> --
> 2.20.1.2.gb21ebb671


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map

[Wei Liu]

On Fri, Feb 15, 2019 at 10:02:00AM +0000, Paul Durrant wrote:
> Commit e3b93b3c595 "dmop: add xendevicemodel_modified_memory_bulk()" added
> the implementation to the library almost 2 years ago, but the function
> was not included in the map file, essentially making it useless. This
> patch rectifies the situation.
> 
> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map

[Ian Jackson]

Paul Durrant writes ("RE: [PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map"):
> Cc-ing Juergen, in case this can make 4.12...

I think this should go into 4.12.  It is very low risk.

In another case there would possibly be questions about whether we
wanted to add an additional ABI/API stability promise, but in this
case this is not an issue.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map

[Paul Durrant]

> -----Original Message-----
> From: Ian Jackson [mailto:ian.jackson@citrix.com]
> Sent: 15 February 2019 11:27
> To: Paul Durrant <Paul.Durrant@citrix.com>
> Cc: xen-devel@lists.xenproject.org; Wei Liu <wei.liu2@citrix.com>;
> jgross@suse.com
> Subject: RE: [PATCH] tools/libxendevicemodel: add
> xendevicemodel_modified_memory_bulk to map
> 
> Paul Durrant writes ("RE: [PATCH] tools/libxendevicemodel: add
> xendevicemodel_modified_memory_bulk to map"):
> > Cc-ing Juergen, in case this can make 4.12...
> 
> I think this should go into 4.12.  It is very low risk.
> 
> In another case there would possibly be questions about whether we
> wanted to add an additional ABI/API stability promise, but in this
> case this is not an issue.

No, indeed.

Perhaps it would be possible to build some sort of cross-check that all functions listed in the public header of a library are actually *somewhere* in the map file, so this doesn't happen in future.

  Paul

> 
> Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map

[Ian Jackson]

Paul Durrant writes ("RE: [PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map"):
> Perhaps it would be possible to build some sort of cross-check that all functions listed in the public header of a library are actually *somewhere* in the map file, so this doesn't happen in future.

I wouldn't stand in the way of that, but presumably functions are
usually added because someone wants to call them so it would often be
spotted anyway, and the consequences of a mistake here are fairly
minor.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] tools/libxendevicemodel: add xendevicemodel_modified_memory_bulk to map

[Juergen Gross]

On 15/02/2019 11:31, Paul Durrant wrote:
> Cc-ing Juergen, in case this can make 4.12...
> 
>> -----Original Message-----
>> From: Paul Durrant [mailto:paul.durrant@citrix.com]
>> Sent: 15 February 2019 10:02
>> To: xen-devel@lists.xenproject.org
>> Cc: Paul Durrant <Paul.Durrant@citrix.com>; Ian Jackson
>> <Ian.Jackson@citrix.com>; Wei Liu <wei.liu2@citrix.com>
>> Subject: [PATCH] tools/libxendevicemodel: add
>> xendevicemodel_modified_memory_bulk to map
>>
>> Commit e3b93b3c595 "dmop: add xendevicemodel_modified_memory_bulk()" added
>> the implementation to the library almost 2 years ago, but the function
>> was not included in the map file, essentially making it useless. This
>> patch rectifies the situation.
>>
>> Signed-off-by: Paul Durrant <paul.durrant@citrix.com>

Release-acked-by: Juergen Gross <jgross@suse.com>


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel