All of lore.kernel.org
 help / color / mirror / Atom feed
From: Aaron Conole <aconole@redhat.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: Panu Matilainen <pmatilai@redhat.com>, "Lu\,
	Wenzhuo" <wenzhuo.lu@intel.com>, dev@dpdk.org, "Richardson\,
	Bruce" <bruce.richardson@intel.com>
Subject: Re: [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets
Date: Wed, 30 Mar 2016 09:14:40 -0400	[thread overview]
Message-ID: <f7tegas151b.fsf@redhat.com> (raw)
In-Reply-To: <2113478.WYverkV2By@xps13> (Thomas Monjalon's message of "Wed, 30 Mar 2016 12:51:07 +0200")

Thomas Monjalon <thomas.monjalon@6wind.com> writes:

> 2016-03-24 08:54, Panu Matilainen:
>> --- a/drivers/net/e1000/Makefile
>> +++ b/drivers/net/e1000/Makefile
>> @@ -54,6 +54,9 @@ else
>>   #
>>   CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter
>>   CFLAGS_BASE_DRIVER += -Wno-unused-variable
>> +ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)
>> +CFLAGS_BASE_DRIVER += -Wno-misleading-indentation
>> +endif
>
> Aaron, have you tested this solution?
> Are you going to provide a v3?

I haven't yet tested this solution, but if folks are that opposed to
changing the code, then I will test it and post a v3 of this particular
patch in the series. 

Thanks so much for the reviews and time on this (Panu AND Thomas :-)),
-Aaron

  reply	other threads:[~2016-03-30 13:14 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-22 21:37 [PATCH v2 0/7] Various fixes to compile with gcc6 Aaron Conole
2016-03-22 21:37 ` [PATCH v2 1/7] app/test/test: Fix missing brackets Aaron Conole
2016-03-22 21:37 ` [PATCH v2 2/7] drivers/net/e1000: " Aaron Conole
2016-03-23 10:38   ` Thomas Monjalon
2016-03-23 10:41     ` Thomas Monjalon
2016-03-24  0:35       ` Lu, Wenzhuo
2016-03-24  6:54         ` Panu Matilainen
2016-03-30 10:51           ` Thomas Monjalon
2016-03-30 13:14             ` Aaron Conole [this message]
2016-03-30 14:06             ` [PATCH v3 2/7] drivers/net/e1000: Suppress misleading indentation warning Aaron Conole
2016-03-30 16:36               ` Stephen Hemminger
2016-03-30 17:12                 ` Thomas Monjalon
2016-03-30 21:48                   ` Stephen Hemminger
2016-03-31  0:41               ` Lu, Wenzhuo
2016-03-22 21:37 ` [PATCH v2 3/7] drivers/net/e1000: Fix missing lsc interrupt check brackets Aaron Conole
2016-03-22 21:37 ` [PATCH v2 4/7] drivers/net/ixgbe: Fix vlan filter missing brackets Aaron Conole
2016-03-22 21:37 ` [PATCH v2 5/7] drivers/net/e1000/igb: Signed left shift operator Aaron Conole
2016-03-22 21:37 ` [PATCH v2 6/7] drivers/net/ixgbe: " Aaron Conole
2016-03-22 21:37 ` [PATCH v2 7/7] drivers/net/ixgbe: Fix uninitialized warning Aaron Conole
2016-03-31 15:02 ` [PATCH v2 0/7] Various fixes to compile with gcc6 Thomas Monjalon
2016-04-01  6:07   ` Panu Matilainen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f7tegas151b.fsf@redhat.com \
    --to=aconole@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=pmatilai@redhat.com \
    --cc=thomas.monjalon@6wind.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.