From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Wenzhuo Lu <wenzhuo.lu@intel.com>
Cc: Aaron Conole <aconole@redhat.com>,
dev@dpdk.org, bruce.richardson@intel.com
Subject: Re: [PATCH v2 2/7] drivers/net/e1000: Fix missing brackets
Date: Wed, 23 Mar 2016 11:41:26 +0100 [thread overview]
Message-ID: <1470283.VAKgtTzWav@xps13> (raw)
In-Reply-To: <5248499.WRMHcbhMjp@xps13>
fixing Wenzhuo email address...
2016-03-23 11:38, Thomas Monjalon:
> 2016-03-22 17:37, Aaron Conole:
> > The register read/write mphy functions have misleading whitespace around
> > the locked check. This cleanup merely preserves the existing functionality
> > while improving the ready check.
> >
> > Fixes commit 38db3f7f50bd ("e1000: update base driver")
> >
> > Signed-off-by: Aaron Conole <aconole@redhat.com>
> > ---
> > v2:
> > * Changed from "whitespace-only" fix to a functional change
> > moving the phy writes into protection of the `if (locked)`
> > code
> > * Added "Fixes" line.
>
> Wenzhuo, do you agree to fix the base driver here?
next prev parent reply other threads:[~2016-03-23 10:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 21:37 [PATCH v2 0/7] Various fixes to compile with gcc6 Aaron Conole
2016-03-22 21:37 ` [PATCH v2 1/7] app/test/test: Fix missing brackets Aaron Conole
2016-03-22 21:37 ` [PATCH v2 2/7] drivers/net/e1000: " Aaron Conole
2016-03-23 10:38 ` Thomas Monjalon
2016-03-23 10:41 ` Thomas Monjalon [this message]
2016-03-24 0:35 ` Lu, Wenzhuo
2016-03-24 6:54 ` Panu Matilainen
2016-03-30 10:51 ` Thomas Monjalon
2016-03-30 13:14 ` Aaron Conole
2016-03-30 14:06 ` [PATCH v3 2/7] drivers/net/e1000: Suppress misleading indentation warning Aaron Conole
2016-03-30 16:36 ` Stephen Hemminger
2016-03-30 17:12 ` Thomas Monjalon
2016-03-30 21:48 ` Stephen Hemminger
2016-03-31 0:41 ` Lu, Wenzhuo
2016-03-22 21:37 ` [PATCH v2 3/7] drivers/net/e1000: Fix missing lsc interrupt check brackets Aaron Conole
2016-03-22 21:37 ` [PATCH v2 4/7] drivers/net/ixgbe: Fix vlan filter missing brackets Aaron Conole
2016-03-22 21:37 ` [PATCH v2 5/7] drivers/net/e1000/igb: Signed left shift operator Aaron Conole
2016-03-22 21:37 ` [PATCH v2 6/7] drivers/net/ixgbe: " Aaron Conole
2016-03-22 21:37 ` [PATCH v2 7/7] drivers/net/ixgbe: Fix uninitialized warning Aaron Conole
2016-03-31 15:02 ` [PATCH v2 0/7] Various fixes to compile with gcc6 Thomas Monjalon
2016-04-01 6:07 ` Panu Matilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1470283.VAKgtTzWav@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=aconole@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.