From: <Mario.Limonciello@dell.com> To: <pali.rohar@gmail.com> Cc: <dvhart@infradead.org>, <andy.shevchenko@gmail.com>, <linux-kernel@vger.kernel.org>, <platform-driver-x86@vger.kernel.org>, <luto@kernel.org>, <quasisec@google.com>, <rjw@rjwysocki.net>, <mjg59@google.com>, <hch@lst.de>, <greg@kroah.com>, <gnomes@lxorguk.ukuu.org.uk> Subject: RE: [PATCH v9 07/17] platform/x86: dell-smbios: only run if proper oem string is detected Date: Tue, 17 Oct 2017 19:10:40 +0000 [thread overview] Message-ID: <f8132fa7a90a4954831fc3ee30be4329@ausx13mpc120.AMER.DELL.COM> (raw) In-Reply-To: <20171017190336.iqhzmdsimx4f7mfw@pali> > -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@gmail.com] > Sent: Tuesday, October 17, 2017 2:04 PM > To: Limonciello, Mario <Mario_Limonciello@Dell.com> > Cc: dvhart@infradead.org; Andy Shevchenko <andy.shevchenko@gmail.com>; > LKML <linux-kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org; Andy > Lutomirski <luto@kernel.org>; quasisec@google.com; rjw@rjwysocki.net; > mjg59@google.com; hch@lst.de; Greg KH <greg@kroah.com>; Alan Cox > <gnomes@lxorguk.ukuu.org.uk> > Subject: Re: [PATCH v9 07/17] platform/x86: dell-smbios: only run if proper oem > string is detected > > On Tuesday 17 October 2017 13:21:51 Mario Limonciello wrote: > > The proper way to indicate that a system is a 'supported' Dell System > > is by the presence of this string in OEM strings. > > > > Allowing the driver to load on non-Dell systems will have undefined > > results. > > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > > Reviewed-by: Edward O'Callaghan <quasisec@google.com> > > --- > > drivers/platform/x86/dell-smbios.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell- > smbios.c > > index e9b1ca07c872..7e779278d054 100644 > > --- a/drivers/platform/x86/dell-smbios.c > > +++ b/drivers/platform/x86/dell-smbios.c > > @@ -172,8 +172,15 @@ static void __init find_tokens(const struct dmi_header > *dm, void *dummy) > > > > static int __init dell_smbios_init(void) > > { > > + const struct dmi_device *valid; > > int ret; > > > > + valid = dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", > NULL); > > Are you sure that all Dell machines have exactly this string? IIRC this > smbios interface via SMM is supported by machines back to 2005... Also > in other DMI tables in dell-latop there is e.g. "Dell Inc." or "Dell > Computer Corporation". > I checked the spec and it's been there since systems 1999 onward. > > + if (!valid) { > > + pr_err("Unable to run on non-Dell system\n"); > > + return -ENODEV; > > + } > > + > > dmi_walk(find_tokens, NULL); > > > > if (!da_tokens) { > > -- > Pali Rohár > pali.rohar@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: <Mario.Limonciello@dell.com> To: pali.rohar@gmail.com Cc: dvhart@infradead.org, andy.shevchenko@gmail.com, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, luto@kernel.org, quasisec@google.com, rjw@rjwysocki.net, mjg59@google.com, hch@lst.de, greg@kroah.com, gnomes@lxorguk.ukuu.org.uk Subject: RE: [PATCH v9 07/17] platform/x86: dell-smbios: only run if proper oem string is detected Date: Tue, 17 Oct 2017 19:10:40 +0000 [thread overview] Message-ID: <f8132fa7a90a4954831fc3ee30be4329@ausx13mpc120.AMER.DELL.COM> (raw) In-Reply-To: <20171017190336.iqhzmdsimx4f7mfw@pali> > -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@gmail.com] > Sent: Tuesday, October 17, 2017 2:04 PM > To: Limonciello, Mario <Mario_Limonciello@Dell.com> > Cc: dvhart@infradead.org; Andy Shevchenko <andy.shevchenko@gmail.com>; > LKML <linux-kernel@vger.kernel.org>; platform-driver-x86@vger.kernel.org; Andy > Lutomirski <luto@kernel.org>; quasisec@google.com; rjw@rjwysocki.net; > mjg59@google.com; hch@lst.de; Greg KH <greg@kroah.com>; Alan Cox > <gnomes@lxorguk.ukuu.org.uk> > Subject: Re: [PATCH v9 07/17] platform/x86: dell-smbios: only run if proper oem > string is detected > > On Tuesday 17 October 2017 13:21:51 Mario Limonciello wrote: > > The proper way to indicate that a system is a 'supported' Dell System > > is by the presence of this string in OEM strings. > > > > Allowing the driver to load on non-Dell systems will have undefined > > results. > > > > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com> > > Reviewed-by: Edward O'Callaghan <quasisec@google.com> > > --- > > drivers/platform/x86/dell-smbios.c | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell- > smbios.c > > index e9b1ca07c872..7e779278d054 100644 > > --- a/drivers/platform/x86/dell-smbios.c > > +++ b/drivers/platform/x86/dell-smbios.c > > @@ -172,8 +172,15 @@ static void __init find_tokens(const struct dmi_header > *dm, void *dummy) > > > > static int __init dell_smbios_init(void) > > { > > + const struct dmi_device *valid; > > int ret; > > > > + valid = dmi_find_device(DMI_DEV_TYPE_OEM_STRING, "Dell System", > NULL); > > Are you sure that all Dell machines have exactly this string? IIRC this > smbios interface via SMM is supported by machines back to 2005... Also > in other DMI tables in dell-latop there is e.g. "Dell Inc." or "Dell > Computer Corporation". > I checked the spec and it's been there since systems 1999 onward. > > + if (!valid) { > > + pr_err("Unable to run on non-Dell system\n"); > > + return -ENODEV; > > + } > > + > > dmi_walk(find_tokens, NULL); > > > > if (!da_tokens) { > > -- > Pali Rohár > pali.rohar@gmail.com
next prev parent reply other threads:[~2017-10-17 19:10 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-10-17 18:21 [PATCH v9 00/17] Introduce support for Dell SMBIOS over WMI Mario Limonciello 2017-10-17 18:21 ` [PATCH v9 01/17] platform/x86: wmi: Add new method wmidev_evaluate_method Mario Limonciello 2017-10-17 18:41 ` Pali Rohár 2017-10-17 18:21 ` [PATCH v9 02/17] platform/x86: dell-wmi: increase severity of some failures Mario Limonciello 2017-10-17 18:42 ` Pali Rohár 2017-10-17 18:21 ` [PATCH v9 03/17] platform/x86: dell-wmi: clean up wmi descriptor check Mario Limonciello 2017-10-17 18:44 ` Pali Rohár 2017-10-17 19:31 ` Mario.Limonciello 2017-10-17 19:31 ` Mario.Limonciello 2017-10-17 18:21 ` [PATCH v9 04/17] platform/x86: dell-wmi: allow 32k return size in the descriptor Mario Limonciello 2017-10-17 18:46 ` Pali Rohár 2017-10-17 18:56 ` Mario.Limonciello 2017-10-17 18:56 ` Mario.Limonciello 2017-10-17 18:21 ` [PATCH v9 05/17] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver Mario Limonciello 2017-10-17 18:59 ` Pali Rohár 2017-10-17 20:22 ` Mario.Limonciello 2017-10-17 20:22 ` Mario.Limonciello 2017-10-17 18:21 ` [PATCH v9 06/17] platform/x86: wmi: Don't allow drivers to get each other's GUIDs Mario Limonciello 2017-10-17 19:00 ` Pali Rohár 2017-10-17 18:21 ` [PATCH v9 07/17] platform/x86: dell-smbios: only run if proper oem string is detected Mario Limonciello 2017-10-17 19:03 ` Pali Rohár 2017-10-17 19:10 ` Mario.Limonciello [this message] 2017-10-17 19:10 ` Mario.Limonciello 2017-10-17 19:19 ` Mario.Limonciello 2017-10-17 19:19 ` Mario.Limonciello 2017-10-17 19:25 ` Pali Rohár 2017-10-17 19:29 ` Mario.Limonciello 2017-10-17 19:29 ` Mario.Limonciello 2017-10-17 18:21 ` [PATCH v9 08/17] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens Mario Limonciello 2017-10-17 18:21 ` [PATCH v9 09/17] platform/x86: dell-smbios: Introduce dispatcher for SMM calls Mario Limonciello 2017-10-17 18:21 ` [PATCH v9 10/17] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver Mario Limonciello 2017-10-17 19:10 ` Pali Rohár 2017-10-17 18:21 ` [PATCH v9 11/17] platform/x86: dell-smbios-smm: test for WSMT Mario Limonciello 2017-10-17 19:22 ` Pali Rohár 2017-10-18 19:09 ` Darren Hart 2017-10-18 19:10 ` Mario.Limonciello 2017-10-18 19:10 ` Mario.Limonciello 2017-10-17 18:21 ` [PATCH v9 12/17] platform/x86: dell-smbios: Add filtering support Mario Limonciello 2017-10-17 18:21 ` [PATCH v9 13/17] platform/x86: wmi: Add sysfs attribute for required_buffer_size Mario Limonciello 2017-10-17 18:21 ` [PATCH v9 14/17] platform/x86: wmi: create userspace interface for drivers Mario Limonciello 2017-10-17 18:21 ` [PATCH v9 15/17] platform/x86: dell-smbios-wmi: introduce userspace interface Mario Limonciello 2017-10-17 18:22 ` [PATCH v9 16/17] platform/x86: shuffle headers to export for userspace Mario Limonciello 2017-10-17 18:22 ` [PATCH v9 17/17] tools/wmi: add a sample for dell smbios communication over WMI Mario Limonciello 2017-10-18 2:33 ` Edward O'Callaghan 2017-10-18 7:29 ` Pali Rohár 2017-10-18 13:55 ` Mario.Limonciello 2017-10-18 13:55 ` Mario.Limonciello 2017-10-18 22:27 ` Mario.Limonciello 2017-10-18 22:27 ` Mario.Limonciello 2017-10-19 3:12 ` Edward O'Callaghan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f8132fa7a90a4954831fc3ee30be4329@ausx13mpc120.AMER.DELL.COM \ --to=mario.limonciello@dell.com \ --cc=andy.shevchenko@gmail.com \ --cc=dvhart@infradead.org \ --cc=gnomes@lxorguk.ukuu.org.uk \ --cc=greg@kroah.com \ --cc=hch@lst.de \ --cc=linux-kernel@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mjg59@google.com \ --cc=pali.rohar@gmail.com \ --cc=platform-driver-x86@vger.kernel.org \ --cc=quasisec@google.com \ --cc=rjw@rjwysocki.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.