All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kirti Wankhede <kwankhede@nvidia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: kvm@vger.kernel.org, kernel-janitors@vger.kernel.org,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [patch 2/3] vfio-mdev: buffer overflow in ioctl()
Date: Mon, 09 Jan 2017 18:51:36 +0000	[thread overview]
Message-ID: <f81db85d-6122-93ea-bcfd-bc899e9eea68@nvidia.com> (raw)
In-Reply-To: <20170107062840.GB26959@elgon.mountain>


CC+= Alex

Thanks Dan for fixing.

Reviewed by: Kirti Wankhede <kwankhede@nvidia.com>

Thanks,
Kirti

On 1/7/2017 11:58 AM, Dan Carpenter wrote:
> This is a sample driver for documentation so the impact is probably
> pretty low.  But we should check that bar_index is valid so we
> don't write beyond the end of the mdev_state->region_info[] array.
> 
> Fixes: 9d1a546c53b4 ("docs: Sample driver to demonstrate how to use Mediated device framework.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> index d2656ff569c1..353666d68207 100644
> --- a/samples/vfio-mdev/mtty.c
> +++ b/samples/vfio-mdev/mtty.c
> @@ -1073,7 +1073,7 @@ int mtty_get_region_info(struct mdev_device *mdev,
>  {
>  	unsigned int size = 0;
>  	struct mdev_state *mdev_state;
> -	int bar_index;
> +	u32 bar_index;
>  
>  	if (!mdev)
>  		return -EINVAL;
> @@ -1082,8 +1082,11 @@ int mtty_get_region_info(struct mdev_device *mdev,
>  	if (!mdev_state)
>  		return -EINVAL;
>  
> -	mutex_lock(&mdev_state->ops_lock);
>  	bar_index = region_info->index;
> +	if (bar_index >= VFIO_PCI_NUM_REGIONS)
> +		return -EINVAL;
> +
> +	mutex_lock(&mdev_state->ops_lock);
>  
>  	switch (bar_index) {
>  	case VFIO_PCI_CONFIG_REGION_INDEX:
> 

WARNING: multiple messages have this Message-ID (diff)
From: Kirti Wankhede <kwankhede@nvidia.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: <kvm@vger.kernel.org>, <kernel-janitors@vger.kernel.org>,
	Alex Williamson <alex.williamson@redhat.com>
Subject: Re: [patch 2/3] vfio-mdev: buffer overflow in ioctl()
Date: Tue, 10 Jan 2017 00:09:36 +0530	[thread overview]
Message-ID: <f81db85d-6122-93ea-bcfd-bc899e9eea68@nvidia.com> (raw)
In-Reply-To: <20170107062840.GB26959@elgon.mountain>


CC+= Alex

Thanks Dan for fixing.

Reviewed by: Kirti Wankhede <kwankhede@nvidia.com>

Thanks,
Kirti

On 1/7/2017 11:58 AM, Dan Carpenter wrote:
> This is a sample driver for documentation so the impact is probably
> pretty low.  But we should check that bar_index is valid so we
> don't write beyond the end of the mdev_state->region_info[] array.
> 
> Fixes: 9d1a546c53b4 ("docs: Sample driver to demonstrate how to use Mediated device framework.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/samples/vfio-mdev/mtty.c b/samples/vfio-mdev/mtty.c
> index d2656ff569c1..353666d68207 100644
> --- a/samples/vfio-mdev/mtty.c
> +++ b/samples/vfio-mdev/mtty.c
> @@ -1073,7 +1073,7 @@ int mtty_get_region_info(struct mdev_device *mdev,
>  {
>  	unsigned int size = 0;
>  	struct mdev_state *mdev_state;
> -	int bar_index;
> +	u32 bar_index;
>  
>  	if (!mdev)
>  		return -EINVAL;
> @@ -1082,8 +1082,11 @@ int mtty_get_region_info(struct mdev_device *mdev,
>  	if (!mdev_state)
>  		return -EINVAL;
>  
> -	mutex_lock(&mdev_state->ops_lock);
>  	bar_index = region_info->index;
> +	if (bar_index >= VFIO_PCI_NUM_REGIONS)
> +		return -EINVAL;
> +
> +	mutex_lock(&mdev_state->ops_lock);
>  
>  	switch (bar_index) {
>  	case VFIO_PCI_CONFIG_REGION_INDEX:
> 

  reply	other threads:[~2017-01-09 18:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-07  6:28 [patch 2/3] vfio-mdev: buffer overflow in ioctl() Dan Carpenter
2017-01-07  6:28 ` Dan Carpenter
2017-01-09 18:39 ` Kirti Wankhede [this message]
2017-01-09 18:51   ` Kirti Wankhede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f81db85d-6122-93ea-bcfd-bc899e9eea68@nvidia.com \
    --to=kwankhede@nvidia.com \
    --cc=alex.williamson@redhat.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.