* [MPTCP] Re: [MPTCP][PATCH v3 mptcp-next 0/2] Squash-to: "mptcp: remove addr and subflow in PM netlink v9"
@ 2020-09-16 13:17 Matthieu Baerts
0 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts @ 2020-09-16 13:17 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 2056 bytes --]
Hi Geliang,
On 16/09/2020 04:37, Geliang Tang wrote:
> Hi Matt, Paolo,
>
> Matthieu Baerts <matthieu.baerts(a)tessares.net> 于2020年9月16日周三 上午4:26写道：
>>
>> Hi Geliang, Paolo,
>>
>> On 15/09/2020 15:04, Paolo Abeni wrote:
>>> On Tue, 2020-09-15 at 19:59 +0800, Geliang Tang wrote:
>>>> v3:
>>>> - use "goto next" in mptcp_nl_remove_subflow_and_signal_addr
>>>> - update mptcp_destroy_common
>>>>
>>>> v2:
>>>> - add mptcp_pm_remove_anno_addr and update logic in
>>>> mptcp_nl_remove_subflow_and_signal_addr
>>>> - call mptcp_pm_free_anno_list in mptcp_destroy and mptcp_sock_destruct
>>>> - add mptcp_destroy_common helper
>>>>
>>>> Geliang Tang (2):
>>>> Squash-to: "mptcp: remove addr and subflow in PM netlink"
>>>> mptcp: add mptcp_destroy_common helper
>>>>
>>>> net/mptcp/pm.c | 1 +
>>>> net/mptcp/pm_netlink.c | 91 +++++++++++++++++++++++++++++++++++++++---
>>>> net/mptcp/protocol.c | 10 ++++-
>>>> net/mptcp/protocol.h | 3 ++
>>>> net/mptcp/subflow.c | 3 +-
>>>> 5 files changed, 98 insertions(+), 10 deletions(-)
>>>>
>>>
>>> Both patches LGTM, thanks!
>>
>> Thank you for the patches and the review!
>>
>> Just to be sure, can I squash the two of them in the same "mptcp: remove
>> addr and subflow in PM netlink" commit? (+ update the commit message as
>> written in 1/2 patch)
>
> Please only squash 1/2 patch to "mptcp: remove addr and subflow in PM netlink"
> commit. And apply patch 2/2 (mptcp: add mptcp_destroy_common helper) as a
> new commit.
Thank you for the clarification.
- 96141df51494: "squashed" patch 1/2 in "mptcp: remove addr and subflow
in PM netlink"
- 4c292fe817d5..79a312a49fee: result
The second patch has been added before your two commits modifying the
selftests.
- 6d043d6c3dc2: mptcp: add mptcp_destroy_common helper
- c3f59bbd90df..653f02bb3161: result
Tests + export are in progress.
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [MPTCP][PATCH v3 mptcp-next 0/2] Squash-to: "mptcp: remove addr and subflow in PM netlink v9"
@ 2020-09-17 5:16 Geliang Tang
0 siblings, 0 replies; 6+ messages in thread
From: Geliang Tang @ 2020-09-17 5:16 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 2854 bytes --]
Hi Matt,
Matthieu Baerts <matthieu.baerts(a)tessares.net> 于2020年9月17日周四 上午12:10写道：
>
> Hi Geliang,
>
> On 16/09/2020 15:17, Matthieu Baerts wrote:
> > Hi Geliang,
> >
> > On 16/09/2020 04:37, Geliang Tang wrote:
> >> Hi Matt, Paolo,
> >>
> >> Matthieu Baerts <matthieu.baerts(a)tessares.net> 于2020年9月16日周三 上
> >> 午4:26写道：
> >>>
> >>> Hi Geliang, Paolo,
> >>>
> >>> On 15/09/2020 15:04, Paolo Abeni wrote:
> >>>> On Tue, 2020-09-15 at 19:59 +0800, Geliang Tang wrote:
> >>>>> v3:
> >>>>> - use "goto next" in mptcp_nl_remove_subflow_and_signal_addr
> >>>>> - update mptcp_destroy_common
> >>>>>
> >>>>> v2:
> >>>>> - add mptcp_pm_remove_anno_addr and update logic in
> >>>>> mptcp_nl_remove_subflow_and_signal_addr
> >>>>> - call mptcp_pm_free_anno_list in mptcp_destroy and
> >>>>> mptcp_sock_destruct
> >>>>> - add mptcp_destroy_common helper
> >>>>>
> >>>>> Geliang Tang (2):
> >>>>> Squash-to: "mptcp: remove addr and subflow in PM netlink"
> >>>>> mptcp: add mptcp_destroy_common helper
> >>>>>
> >>>>> net/mptcp/pm.c | 1 +
> >>>>> net/mptcp/pm_netlink.c | 91
> >>>>> +++++++++++++++++++++++++++++++++++++++---
> >>>>> net/mptcp/protocol.c | 10 ++++-
> >>>>> net/mptcp/protocol.h | 3 ++
> >>>>> net/mptcp/subflow.c | 3 +-
> >>>>> 5 files changed, 98 insertions(+), 10 deletions(-)
> >>>>>
> >>>>
> >>>> Both patches LGTM, thanks!
> >>>
> >>> Thank you for the patches and the review!
> >>>
> >>> Just to be sure, can I squash the two of them in the same "mptcp: remove
> >>> addr and subflow in PM netlink" commit? (+ update the commit message as
> >>> written in 1/2 patch)
> >>
> >> Please only squash 1/2 patch to "mptcp: remove addr and subflow in PM
> >> netlink"
> >> commit. And apply patch 2/2 (mptcp: add mptcp_destroy_common helper) as a
> >> new commit.
> >
> > Thank you for the clarification.
> >
> > - 96141df51494: "squashed" patch 1/2 in "mptcp: remove addr and subflow
> > in PM netlink"
> > - 4c292fe817d5..79a312a49fee: result
> >
> > The second patch has been added before your two commits modifying the
> > selftests.
> > - 6d043d6c3dc2: mptcp: add mptcp_destroy_common helper
> > - c3f59bbd90df..653f02bb3161: result
> >
> > Tests + export are in progress.
>
> It looks like these two patches are causing a crash:
>
> https://github.com/multipath-tcp/mptcp_net-next/issues/90
>
> Sadly I always see that when I have to leave, I didn't investigate more
> so far nor removing the two patches.
Sorry. I have just sent out a patch named (Squash-to: "mptcp: remove addr
and subflow in PM netlink v9" Part 2) to fix this bug.
Thanks.
-Geliang
>
> Cheers,
> Matt
> --
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [MPTCP][PATCH v3 mptcp-next 0/2] Squash-to: "mptcp: remove addr and subflow in PM netlink v9"
@ 2020-09-16 16:10 Matthieu Baerts
0 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts @ 2020-09-16 16:10 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 2496 bytes --]
Hi Geliang,
On 16/09/2020 15:17, Matthieu Baerts wrote:
> Hi Geliang,
>
> On 16/09/2020 04:37, Geliang Tang wrote:
>> Hi Matt, Paolo,
>>
>> Matthieu Baerts <matthieu.baerts(a)tessares.net> 于2020年9月16日周三 上
>> 午4:26写道：
>>>
>>> Hi Geliang, Paolo,
>>>
>>> On 15/09/2020 15:04, Paolo Abeni wrote:
>>>> On Tue, 2020-09-15 at 19:59 +0800, Geliang Tang wrote:
>>>>> v3:
>>>>> - use "goto next" in mptcp_nl_remove_subflow_and_signal_addr
>>>>> - update mptcp_destroy_common
>>>>>
>>>>> v2:
>>>>> - add mptcp_pm_remove_anno_addr and update logic in
>>>>> mptcp_nl_remove_subflow_and_signal_addr
>>>>> - call mptcp_pm_free_anno_list in mptcp_destroy and
>>>>> mptcp_sock_destruct
>>>>> - add mptcp_destroy_common helper
>>>>>
>>>>> Geliang Tang (2):
>>>>> Squash-to: "mptcp: remove addr and subflow in PM netlink"
>>>>> mptcp: add mptcp_destroy_common helper
>>>>>
>>>>> net/mptcp/pm.c | 1 +
>>>>> net/mptcp/pm_netlink.c | 91
>>>>> +++++++++++++++++++++++++++++++++++++++---
>>>>> net/mptcp/protocol.c | 10 ++++-
>>>>> net/mptcp/protocol.h | 3 ++
>>>>> net/mptcp/subflow.c | 3 +-
>>>>> 5 files changed, 98 insertions(+), 10 deletions(-)
>>>>>
>>>>
>>>> Both patches LGTM, thanks!
>>>
>>> Thank you for the patches and the review!
>>>
>>> Just to be sure, can I squash the two of them in the same "mptcp: remove
>>> addr and subflow in PM netlink" commit? (+ update the commit message as
>>> written in 1/2 patch)
>>
>> Please only squash 1/2 patch to "mptcp: remove addr and subflow in PM
>> netlink"
>> commit. And apply patch 2/2 (mptcp: add mptcp_destroy_common helper) as a
>> new commit.
>
> Thank you for the clarification.
>
> - 96141df51494: "squashed" patch 1/2 in "mptcp: remove addr and subflow
> in PM netlink"
> - 4c292fe817d5..79a312a49fee: result
>
> The second patch has been added before your two commits modifying the
> selftests.
> - 6d043d6c3dc2: mptcp: add mptcp_destroy_common helper
> - c3f59bbd90df..653f02bb3161: result
>
> Tests + export are in progress.
It looks like these two patches are causing a crash:
https://github.com/multipath-tcp/mptcp_net-next/issues/90
Sadly I always see that when I have to leave, I didn't investigate more
so far nor removing the two patches.
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [MPTCP][PATCH v3 mptcp-next 0/2] Squash-to: "mptcp: remove addr and subflow in PM netlink v9"
@ 2020-09-16 2:37 Geliang Tang
0 siblings, 0 replies; 6+ messages in thread
From: Geliang Tang @ 2020-09-16 2:37 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1615 bytes --]
Hi Matt, Paolo,
Matthieu Baerts <matthieu.baerts(a)tessares.net> 于2020年9月16日周三 上午4:26写道：
>
> Hi Geliang, Paolo,
>
> On 15/09/2020 15:04, Paolo Abeni wrote:
> > On Tue, 2020-09-15 at 19:59 +0800, Geliang Tang wrote:
> >> v3:
> >> - use "goto next" in mptcp_nl_remove_subflow_and_signal_addr
> >> - update mptcp_destroy_common
> >>
> >> v2:
> >> - add mptcp_pm_remove_anno_addr and update logic in
> >> mptcp_nl_remove_subflow_and_signal_addr
> >> - call mptcp_pm_free_anno_list in mptcp_destroy and mptcp_sock_destruct
> >> - add mptcp_destroy_common helper
> >>
> >> Geliang Tang (2):
> >> Squash-to: "mptcp: remove addr and subflow in PM netlink"
> >> mptcp: add mptcp_destroy_common helper
> >>
> >> net/mptcp/pm.c | 1 +
> >> net/mptcp/pm_netlink.c | 91 +++++++++++++++++++++++++++++++++++++++---
> >> net/mptcp/protocol.c | 10 ++++-
> >> net/mptcp/protocol.h | 3 ++
> >> net/mptcp/subflow.c | 3 +-
> >> 5 files changed, 98 insertions(+), 10 deletions(-)
> >>
> >
> > Both patches LGTM, thanks!
>
> Thank you for the patches and the review!
>
> Just to be sure, can I squash the two of them in the same "mptcp: remove
> addr and subflow in PM netlink" commit? (+ update the commit message as
> written in 1/2 patch)
Please only squash 1/2 patch to "mptcp: remove addr and subflow in PM netlink"
commit. And apply patch 2/2 (mptcp: add mptcp_destroy_common helper) as a
new commit.
Thanks.
-Geliang
>
> Cheers,
> Matt
> --
> Tessares | Belgium | Hybrid Access Solutions
> www.tessares.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [MPTCP][PATCH v3 mptcp-next 0/2] Squash-to: "mptcp: remove addr and subflow in PM netlink v9"
@ 2020-09-15 20:26 Matthieu Baerts
0 siblings, 0 replies; 6+ messages in thread
From: Matthieu Baerts @ 2020-09-15 20:26 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 1232 bytes --]
Hi Geliang, Paolo,
On 15/09/2020 15:04, Paolo Abeni wrote:
> On Tue, 2020-09-15 at 19:59 +0800, Geliang Tang wrote:
>> v3:
>> - use "goto next" in mptcp_nl_remove_subflow_and_signal_addr
>> - update mptcp_destroy_common
>>
>> v2:
>> - add mptcp_pm_remove_anno_addr and update logic in
>> mptcp_nl_remove_subflow_and_signal_addr
>> - call mptcp_pm_free_anno_list in mptcp_destroy and mptcp_sock_destruct
>> - add mptcp_destroy_common helper
>>
>> Geliang Tang (2):
>> Squash-to: "mptcp: remove addr and subflow in PM netlink"
>> mptcp: add mptcp_destroy_common helper
>>
>> net/mptcp/pm.c | 1 +
>> net/mptcp/pm_netlink.c | 91 +++++++++++++++++++++++++++++++++++++++---
>> net/mptcp/protocol.c | 10 ++++-
>> net/mptcp/protocol.h | 3 ++
>> net/mptcp/subflow.c | 3 +-
>> 5 files changed, 98 insertions(+), 10 deletions(-)
>>
>
> Both patches LGTM, thanks!
Thank you for the patches and the review!
Just to be sure, can I squash the two of them in the same "mptcp: remove
addr and subflow in PM netlink" commit? (+ update the commit message as
written in 1/2 patch)
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 6+ messages in thread
* [MPTCP] Re: [MPTCP][PATCH v3 mptcp-next 0/2] Squash-to: "mptcp: remove addr and subflow in PM netlink v9"
@ 2020-09-15 13:04 Paolo Abeni
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Abeni @ 2020-09-15 13:04 UTC (permalink / raw)
To: mptcp
[-- Attachment #1: Type: text/plain, Size: 838 bytes --]
On Tue, 2020-09-15 at 19:59 +0800, Geliang Tang wrote:
> v3:
> - use "goto next" in mptcp_nl_remove_subflow_and_signal_addr
> - update mptcp_destroy_common
>
> v2:
> - add mptcp_pm_remove_anno_addr and update logic in
> mptcp_nl_remove_subflow_and_signal_addr
> - call mptcp_pm_free_anno_list in mptcp_destroy and mptcp_sock_destruct
> - add mptcp_destroy_common helper
>
> Geliang Tang (2):
> Squash-to: "mptcp: remove addr and subflow in PM netlink"
> mptcp: add mptcp_destroy_common helper
>
> net/mptcp/pm.c | 1 +
> net/mptcp/pm_netlink.c | 91 +++++++++++++++++++++++++++++++++++++++---
> net/mptcp/protocol.c | 10 ++++-
> net/mptcp/protocol.h | 3 ++
> net/mptcp/subflow.c | 3 +-
> 5 files changed, 98 insertions(+), 10 deletions(-)
>
Both patches LGTM, thanks!
Paolo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-17 5:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 13:17 [MPTCP] Re: [MPTCP][PATCH v3 mptcp-next 0/2] Squash-to: "mptcp: remove addr and subflow in PM netlink v9" Matthieu Baerts
-- strict thread matches above, loose matches on Subject: below --
2020-09-17 5:16 Geliang Tang
2020-09-16 16:10 Matthieu Baerts
2020-09-16 2:37 Geliang Tang
2020-09-15 20:26 Matthieu Baerts
2020-09-15 13:04 Paolo Abeni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.