From: guanjunxiong@huawei.com (Guan Junxiong)
Subject: [PATCH 4/4] libmultipath: fix over-long NVME WWIDs
Date: Mon, 17 Jul 2017 09:13:41 +0800 [thread overview]
Message-ID: <f82ac570-4d40-0c69-5c98-7eb2d8c9c875@huawei.com> (raw)
In-Reply-To: <20170714113209.17177-5-mwilck@suse.com>
Hi, Martin:
On 2017/7/14 19:32, Martin Wilck wrote:
> Fix for NVME wwids looking like this:
> nvme.0000-3163653363666438366239656630386200-4c696e75780000000000000000000000000000000000000000000000000000000000000000000000-00000002
I think the above line is too long and it's better to split it into two lines.
Otherwise , this patch looks good for me.
Reviewed-by: Guan Junxiong <guanjunxiong at huawei.com>
> which are encountered in some combinations of Linux NVME host and target,
> where the 2nd field represents the serial number (SN) and the 3rd the
> model number (MN).
WARNING: multiple messages have this Message-ID (diff)
From: Guan Junxiong <guanjunxiong@huawei.com>
To: Martin Wilck <mwilck@suse.com>
Cc: Martin Wilck <mwilck@suse.de>,
"Shenhong (C)" <shenhong09@huawei.com>,
Xose Vazquez Perez <xose.vazquez@gmail.com>,
tang.junhui@zte.com.cn, guanjunxiong@huawei.com,
Yang Feng <philip.yang@huawei.com>,
linux-nvme@lists.infradead.org, dm-devel@redhat.com,
"Hege (A)" <hege09@huawei.com>
Subject: Re: [PATCH 4/4] libmultipath: fix over-long NVME WWIDs
Date: Mon, 17 Jul 2017 09:13:41 +0800 [thread overview]
Message-ID: <f82ac570-4d40-0c69-5c98-7eb2d8c9c875@huawei.com> (raw)
In-Reply-To: <20170714113209.17177-5-mwilck@suse.com>
Hi, Martin:
On 2017/7/14 19:32, Martin Wilck wrote:
> Fix for NVME wwids looking like this:
> nvme.0000-3163653363666438366239656630386200-4c696e75780000000000000000000000000000000000000000000000000000000000000000000000-00000002
I think the above line is too long and it's better to split it into two lines.
Otherwise , this patch looks good for me.
Reviewed-by: Guan Junxiong <guanjunxiong@huawei.com>
> which are encountered in some combinations of Linux NVME host and target,
> where the 2nd field represents the serial number (SN) and the 3rd the
> model number (MN).
next prev parent reply other threads:[~2017-07-17 1:13 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-14 11:32 [PATCH 0/4] libmultipath: Fixes for NVME / NVMEoF Martin Wilck
2017-07-14 11:32 ` Martin Wilck
2017-07-14 11:32 ` [PATCH 1/4] libmultipath: get_udev_uid: make sure pp->wwid is 0-terminated Martin Wilck
2017-07-14 11:32 ` Martin Wilck
2017-07-14 14:56 ` [dm-devel] " Bart Van Assche
2017-07-14 14:56 ` Bart Van Assche
2017-07-14 19:21 ` [dm-devel] " Martin Wilck
2017-07-14 19:21 ` Martin Wilck
2017-07-14 20:21 ` [dm-devel] " Bart Van Assche
2017-07-14 20:21 ` Bart Van Assche
2017-07-14 21:21 ` [dm-devel] " Martin Wilck
2017-07-14 21:21 ` Martin Wilck
2017-07-14 21:27 ` [dm-devel] " Bart Van Assche
2017-07-14 21:27 ` Bart Van Assche
2017-07-14 22:17 ` Benjamin Marzinski
2017-07-14 22:17 ` Benjamin Marzinski
2017-07-14 11:32 ` [PATCH 2/4] libmultipath: drop uevent_can_discard_by_devpath Martin Wilck
2017-07-14 11:32 ` Martin Wilck
2017-07-14 22:18 ` [dm-devel] " Schremmer, Steven
2017-07-14 22:18 ` Schremmer, Steven
2017-07-14 22:29 ` Benjamin Marzinski
2017-07-14 22:29 ` Benjamin Marzinski
2017-07-17 1:12 ` Guan Junxiong
2017-07-17 1:12 ` Guan Junxiong
2017-07-14 11:32 ` [PATCH 3/4] libmultipath: only listen for uevents with DEVTYPE=disk Martin Wilck
2017-07-14 11:32 ` Martin Wilck
2017-07-14 22:16 ` [dm-devel] " Schremmer, Steven
2017-07-14 22:16 ` Schremmer, Steven
2017-07-14 22:29 ` Benjamin Marzinski
2017-07-14 22:29 ` Benjamin Marzinski
2017-07-17 1:12 ` Guan Junxiong
2017-07-17 1:12 ` Guan Junxiong
2017-07-14 11:32 ` [PATCH 4/4] libmultipath: fix over-long NVME WWIDs Martin Wilck
2017-07-14 11:32 ` Martin Wilck
2017-07-14 22:38 ` Benjamin Marzinski
2017-07-14 22:38 ` Benjamin Marzinski
2017-07-17 1:13 ` Guan Junxiong [this message]
2017-07-17 1:13 ` Guan Junxiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f82ac570-4d40-0c69-5c98-7eb2d8c9c875@huawei.com \
--to=guanjunxiong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.