* [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang
@ 2021-03-05 9:19 Gustavo A. R. Silva
2021-04-20 20:09 ` Gustavo A. R. Silva
2021-04-21 23:41 ` Jeffrey E Altman
0 siblings, 2 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2021-03-05 9:19 UTC (permalink / raw)
To: David Howells, David S. Miller, Jakub Kicinski
Cc: linux-afs, netdev, linux-kernel, Gustavo A. R. Silva, linux-hardening
In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
by explicitly adding a break statement instead of letting the code fall
through to the next case.
Link: https://github.com/KSPP/linux/issues/115
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
net/rxrpc/af_rxrpc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
index 41671af6b33f..2b5f89713e36 100644
--- a/net/rxrpc/af_rxrpc.c
+++ b/net/rxrpc/af_rxrpc.c
@@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
switch (rx->sk.sk_state) {
case RXRPC_UNBOUND:
rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
+ break;
case RXRPC_CLIENT_UNBOUND:
case RXRPC_CLIENT_BOUND:
break;
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang
2021-03-05 9:19 [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang Gustavo A. R. Silva
@ 2021-04-20 20:09 ` Gustavo A. R. Silva
2021-06-04 22:35 ` Gustavo A. R. Silva
2021-04-21 23:41 ` Jeffrey E Altman
1 sibling, 1 reply; 4+ messages in thread
From: Gustavo A. R. Silva @ 2021-04-20 20:09 UTC (permalink / raw)
To: Gustavo A. R. Silva, David Howells, David S. Miller, Jakub Kicinski
Cc: linux-afs, netdev, linux-kernel, linux-hardening
Hi all,
Friendly ping: who can take this, please?
Thanks
--
Gustavo
On 3/5/21 03:19, Gustavo A. R. Silva wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
> ---
> net/rxrpc/af_rxrpc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
> index 41671af6b33f..2b5f89713e36 100644
> --- a/net/rxrpc/af_rxrpc.c
> +++ b/net/rxrpc/af_rxrpc.c
> @@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
> switch (rx->sk.sk_state) {
> case RXRPC_UNBOUND:
> rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
> + break;
> case RXRPC_CLIENT_UNBOUND:
> case RXRPC_CLIENT_BOUND:
> break;
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang
2021-04-20 20:09 ` Gustavo A. R. Silva
@ 2021-06-04 22:35 ` Gustavo A. R. Silva
0 siblings, 0 replies; 4+ messages in thread
From: Gustavo A. R. Silva @ 2021-06-04 22:35 UTC (permalink / raw)
To: Gustavo A. R. Silva, David Howells, David S. Miller, Jakub Kicinski
Cc: linux-afs, netdev, linux-kernel, linux-hardening
Hi all,
If you don't mind, I'm taking this in my -next[1] branch for v5.14.
Thanks
--
Gustavo
[1] https://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git/log/?h=for-next/kspp
On 4/20/21 15:09, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping: who can take this, please?
>
> Thanks
> --
> Gustavo
>
> On 3/5/21 03:19, Gustavo A. R. Silva wrote:
>> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
>> by explicitly adding a break statement instead of letting the code fall
>> through to the next case.
>>
>> Link: https://github.com/KSPP/linux/issues/115
>> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
>> ---
>> net/rxrpc/af_rxrpc.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/rxrpc/af_rxrpc.c b/net/rxrpc/af_rxrpc.c
>> index 41671af6b33f..2b5f89713e36 100644
>> --- a/net/rxrpc/af_rxrpc.c
>> +++ b/net/rxrpc/af_rxrpc.c
>> @@ -471,6 +471,7 @@ static int rxrpc_connect(struct socket *sock, struct sockaddr *addr,
>> switch (rx->sk.sk_state) {
>> case RXRPC_UNBOUND:
>> rx->sk.sk_state = RXRPC_CLIENT_UNBOUND;
>> + break;
>> case RXRPC_CLIENT_UNBOUND:
>> case RXRPC_CLIENT_BOUND:
>> break;
>>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang
2021-03-05 9:19 [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:09 ` Gustavo A. R. Silva
@ 2021-04-21 23:41 ` Jeffrey E Altman
1 sibling, 0 replies; 4+ messages in thread
From: Jeffrey E Altman @ 2021-04-21 23:41 UTC (permalink / raw)
To: Gustavo A. R. Silva (gustavoars@kernel.org),
David Howells, David S. Miller, Jakub Kicinski
Cc: linux-afs, netdev, linux-kernel, linux-hardening
[-- Attachment #1.1.1: Type: text/plain, Size: 542 bytes --]
On 3/5/2021 4:19 AM, Gustavo A. R. Silva (gustavoars@kernel.org) wrote:
> In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning
> by explicitly adding a break statement instead of letting the code fall
> through to the next case.
>
> Link: https://github.com/KSPP/linux/issues/115
> Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
This change looks good to me. Although I would also be happy with a
fallthrough statement being added instead.
Reviewed-by: Jeffrey Altman <jaltman@auristor.com>
[-- Attachment #1.1.2: jaltman.vcf --]
[-- Type: text/x-vcard, Size: 283 bytes --]
begin:vcard
fn:Jeffrey Altman
n:Altman;Jeffrey
org:AuriStor, Inc.
adr:;;255 W 94TH ST STE 6B;New York;NY;10025-6985;United States
email;internet:jaltman@auristor.com
title:CEO
tel;work:+1-212-769-9018
url:https://www.linkedin.com/in/jeffreyaltman/
version:2.1
end:vcard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-04 22:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 9:19 [PATCH RESEND][next] rxrpc: Fix fall-through warnings for Clang Gustavo A. R. Silva
2021-04-20 20:09 ` Gustavo A. R. Silva
2021-06-04 22:35 ` Gustavo A. R. Silva
2021-04-21 23:41 ` Jeffrey E Altman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.