All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hui Tang <tanghui20@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <perex@perex.cz>, <tiwai@suse.com>,
	<ryan.lee.analog@gmail.com>, <ricardw@axis.com>, <steve@sk2.org>,
	<alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next 1/2] ASoC: max98396: Fix build error for implicit function declaration
Date: Thu, 12 May 2022 12:46:08 +0800	[thread overview]
Message-ID: <f84cbd0a-0a9e-fd72-b319-dfca8c19ce64@huawei.com> (raw)
In-Reply-To: <YnumrRUSkVCPONdl@sirena.org.uk>



On 2022/5/11 20:06, Mark Brown wrote:
> On Wed, May 11, 2022 at 09:23:47AM +0800, Hui Tang wrote:
>
>>                          devm_regulator_get_optional
>> sound/soc/codecs/max98396.c:1556:23: error: ‘GPIOD_OUT_HIGH’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_HIGH’?
>>               "reset", GPIOD_OUT_HIGH);
>>                        ^~~~~~~~~~~~~~
>>                        GPIOF_INIT_HIGH
>> sound/soc/codecs/max98396.c:1556:23: note: each undeclared identifier is reported only once for each function it appears in
>> sound/soc/codecs/max98396.c:1565:3: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration]
>>    gpiod_set_value_cansleep(max98396->reset_gpio, 0);
>>    ^~~~~~~~~~~~~~~~~~~~~~~~
>>    gpio_set_value_cansleep
>> cc1: all warnings being treated as errors
>>
>> Add depend on GPIOLIB for 'config SND_SOC_MAX98396'
>
> No, these issues are missing headers not dependencies.  In general
> gpiolib stubs out so drivers can optionally use GPIO functionality.
>

Ok, I will do that

thank you

WARNING: multiple messages have this Message-ID (diff)
From: Hui Tang <tanghui20@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, steve@sk2.org,
	linux-kernel@vger.kernel.org, tiwai@suse.com,
	lgirdwood@gmail.com, ricardw@axis.com, ryan.lee.analog@gmail.com
Subject: Re: [PATCH -next 1/2] ASoC: max98396: Fix build error for implicit function declaration
Date: Thu, 12 May 2022 12:46:08 +0800	[thread overview]
Message-ID: <f84cbd0a-0a9e-fd72-b319-dfca8c19ce64@huawei.com> (raw)
In-Reply-To: <YnumrRUSkVCPONdl@sirena.org.uk>



On 2022/5/11 20:06, Mark Brown wrote:
> On Wed, May 11, 2022 at 09:23:47AM +0800, Hui Tang wrote:
>
>>                          devm_regulator_get_optional
>> sound/soc/codecs/max98396.c:1556:23: error: ‘GPIOD_OUT_HIGH’ undeclared (first use in this function); did you mean ‘GPIOF_INIT_HIGH’?
>>               "reset", GPIOD_OUT_HIGH);
>>                        ^~~~~~~~~~~~~~
>>                        GPIOF_INIT_HIGH
>> sound/soc/codecs/max98396.c:1556:23: note: each undeclared identifier is reported only once for each function it appears in
>> sound/soc/codecs/max98396.c:1565:3: error: implicit declaration of function ‘gpiod_set_value_cansleep’; did you mean ‘gpio_set_value_cansleep’? [-Werror=implicit-function-declaration]
>>    gpiod_set_value_cansleep(max98396->reset_gpio, 0);
>>    ^~~~~~~~~~~~~~~~~~~~~~~~
>>    gpio_set_value_cansleep
>> cc1: all warnings being treated as errors
>>
>> Add depend on GPIOLIB for 'config SND_SOC_MAX98396'
>
> No, these issues are missing headers not dependencies.  In general
> gpiolib stubs out so drivers can optionally use GPIO functionality.
>

Ok, I will do that

thank you

  reply	other threads:[~2022-05-12  4:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-11  1:23 [PATCH -next 0/2] ASoC: codecs: Fix build error Hui Tang
2022-05-11  1:23 ` Hui Tang
2022-05-11  1:23 ` [PATCH -next 1/2] ASoC: max98396: Fix build error for implicit function declaration Hui Tang
2022-05-11  1:23   ` Hui Tang
2022-05-11 12:06   ` Mark Brown
2022-05-11 12:06     ` Mark Brown
2022-05-12  4:46     ` Hui Tang [this message]
2022-05-12  4:46       ` Hui Tang
2022-05-11  1:23 ` [PATCH -next 2/2] ASoC: tlv320adc3xxx: " Hui Tang
2022-05-11  1:23   ` Hui Tang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f84cbd0a-0a9e-fd72-b319-dfca8c19ce64@huawei.com \
    --to=tanghui20@huawei.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=ricardw@axis.com \
    --cc=ryan.lee.analog@gmail.com \
    --cc=steve@sk2.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.