* [PATCH] xfs_io: add missed inode command into man page
@ 2017-04-20 17:06 Zorro Lang
2017-04-20 17:23 ` Darrick J. Wong
0 siblings, 1 reply; 4+ messages in thread
From: Zorro Lang @ 2017-04-20 17:06 UTC (permalink / raw)
To: linux-xfs
There's an "inode" command in xfs_io, it's used to query physical
information about an inode. But there's not any information about
it in xfs_io and other related man pages. So document this command
in the xfs_io man page now.
Signed-off-by: Zorro Lang <zlang@redhat.com>
---
man/man8/xfs_io.8 | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
index 19e1ae4..ceb6cf4 100644
--- a/man/man8/xfs_io.8
+++ b/man/man8/xfs_io.8
@@ -650,6 +650,23 @@ sec uses UNIX timestamp notation and is the seconds elapsed since
nsec is the nanoseconds since the sec. This value needs to be in
the range 0-999999999 with UTIME_NOW and UTIME_OMIT being exceptions.
Each (sec, nsec) pair constitutes a single timestamp value.
+.RE
+.PD
+.TP
+.BI " inode [ [ -n ] " number " ] [ -v ]"
+The inode command querys physical information about an inode, it
+returns 1 if any inode number greater than 32 bits exists in the
+filesystem, or 0 if none exist by default. The
+.I number
+is used to specify an inode number, then inode command returns this
+inode number if it's in use, or 0 if not. But if use
+.B \-n
+with
+.I number
+, the next used inode number after this number will be returned, or 0
+if can't find the next one.
+.B \-v
+for verbose mode, the inode number's size in bits will be displayed.
.SH MEMORY MAPPED I/O COMMANDS
.TP
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs_io: add missed inode command into man page
2017-04-20 17:06 [PATCH] xfs_io: add missed inode command into man page Zorro Lang
@ 2017-04-20 17:23 ` Darrick J. Wong
2017-04-20 17:45 ` Eric Sandeen
0 siblings, 1 reply; 4+ messages in thread
From: Darrick J. Wong @ 2017-04-20 17:23 UTC (permalink / raw)
To: Zorro Lang; +Cc: linux-xfs
On Fri, Apr 21, 2017 at 01:06:57AM +0800, Zorro Lang wrote:
> There's an "inode" command in xfs_io, it's used to query physical
> information about an inode. But there's not any information about
> it in xfs_io and other related man pages. So document this command
> in the xfs_io man page now.
>
> Signed-off-by: Zorro Lang <zlang@redhat.com>
> ---
> man/man8/xfs_io.8 | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
> index 19e1ae4..ceb6cf4 100644
> --- a/man/man8/xfs_io.8
> +++ b/man/man8/xfs_io.8
> @@ -650,6 +650,23 @@ sec uses UNIX timestamp notation and is the seconds elapsed since
> nsec is the nanoseconds since the sec. This value needs to be in
> the range 0-999999999 with UTIME_NOW and UTIME_OMIT being exceptions.
> Each (sec, nsec) pair constitutes a single timestamp value.
> +.RE
> +.PD
> +.TP
> +.BI " inode [ [ -n ] " number " ] [ -v ]"
> +The inode command querys physical information about an inode, it
"queries"
> +returns 1 if any inode number greater than 32 bits exists in the
Technically, it returns 1 if any inode number would overflow 32 bits,
which is to say that it returns 1 if any inode number is greater than
2^32-1.
> +filesystem, or 0 if none exist by default. The
You could leave out "by default".
> +.I number
> +is used to specify an inode number, then inode command returns this
> +inode number if it's in use, or 0 if not. But if use
"If an inode /number/ is given, this command returns that inode number if
the inode is in use, or zero if not."?
> +.B \-n
> +with
> +.I number
> +, the next used inode number after this number will be returned, or 0
> +if can't find the next one.
"If -n is given with /number/, the next inode number in use will be
returned, or zero if there aren't any more"?
> +.B \-v
> +for verbose mode, the inode number's size in bits will be displayed.
(What a strange command...)
--D
>
> .SH MEMORY MAPPED I/O COMMANDS
> .TP
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs_io: add missed inode command into man page
2017-04-20 17:23 ` Darrick J. Wong
@ 2017-04-20 17:45 ` Eric Sandeen
2017-04-20 17:48 ` Eric Sandeen
0 siblings, 1 reply; 4+ messages in thread
From: Eric Sandeen @ 2017-04-20 17:45 UTC (permalink / raw)
To: Darrick J. Wong, Zorro Lang; +Cc: linux-xfs
On 4/20/17 12:23 PM, Darrick J. Wong wrote:
> On Fri, Apr 21, 2017 at 01:06:57AM +0800, Zorro Lang wrote:
>> There's an "inode" command in xfs_io, it's used to query physical
>> information about an inode. But there's not any information about
>> it in xfs_io and other related man pages. So document this command
>> in the xfs_io man page now.
>>
>> Signed-off-by: Zorro Lang <zlang@redhat.com>
>> ---
>> man/man8/xfs_io.8 | 17 +++++++++++++++++
>> 1 file changed, 17 insertions(+)
>>
>> diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8
>> index 19e1ae4..ceb6cf4 100644
>> --- a/man/man8/xfs_io.8
>> +++ b/man/man8/xfs_io.8
>> @@ -650,6 +650,23 @@ sec uses UNIX timestamp notation and is the seconds elapsed since
>> nsec is the nanoseconds since the sec. This value needs to be in
>> the range 0-999999999 with UTIME_NOW and UTIME_OMIT being exceptions.
>> Each (sec, nsec) pair constitutes a single timestamp value.
>> +.RE
>> +.PD
>> +.TP
>> +.BI " inode [ [ -n ] " number " ] [ -v ]"
>> +The inode command querys physical information about an inode, it
>
> "queries"
>
>> +returns 1 if any inode number greater than 32 bits exists in the
>
> Technically, it returns 1 if any inode number would overflow 32 bits,
> which is to say that it returns 1 if any inode number is greater than
> 2^32-1.
>
>> +filesystem, or 0 if none exist by default. The
>
> You could leave out "by default".
I think that the intent here was to say that by default (i.e. with no
other options given, this is what the command does - return 1 or 0 based on
whether or not any any inode number exceeding 32 bits is currently in use.
>> +.I number
>> +is used to specify an inode number, then inode command returns this
>> +inode number if it's in use, or 0 if not. But if use
>
> "If an inode /number/ is given, this command returns that inode number if
> the inode is in use, or zero if not."?
>
>> +.B \-n
>> +with
>> +.I number
>> +, the next used inode number after this number will be returned, or 0
>> +if can't find the next one.
>
> "If -n is given with /number/, the next inode number in use will be
> returned, or zero if there aren't any more"?
>
>> +.B \-v
>> +for verbose mode, the inode number's size in bits will be displayed.
This is how I would describe the behavior, feel free to use as much or
as little as you like:
With no arguments, the inode command will return 1 or 0, indicating whether
or not any inode numbers greater than 32 bits are currently in use in the
filesystem.
If given an inode /number/ as an argument, the command will return /number/ or
0, depending on whether or not inode /number/ is in use.
With -n /number/, the command will return the next inode number after /number/
which is in use.
With -v, the command will also report the number of bits (32 or 64) used
by the inode number printed in the result; if no inode /number/ was specified
on the commandline, the maximum possible inode number in the system will be
printed along with its size.
> (What a strange command...)
yup.
-Eric
> --D
>
>>
>> .SH MEMORY MAPPED I/O COMMANDS
>> .TP
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] xfs_io: add missed inode command into man page
2017-04-20 17:45 ` Eric Sandeen
@ 2017-04-20 17:48 ` Eric Sandeen
0 siblings, 0 replies; 4+ messages in thread
From: Eric Sandeen @ 2017-04-20 17:48 UTC (permalink / raw)
To: Darrick J. Wong, Zorro Lang; +Cc: linux-xfs
On 4/20/17 12:45 PM, Eric Sandeen wrote:
> On 4/20/17 12:23 PM, Darrick J. Wong wrote:
>> On Fri, Apr 21, 2017 at 01:06:57AM +0800, Zorro Lang wrote:
>>> There's an "inode" command in xfs_io, it's used to query physical
>>> information about an inode. But there's not any information about
>>> it in xfs_io and other related man pages. So document this command
>>> in the xfs_io man page now.
Oh, I would also put this in the "other commands" section, not the
"file I/O" section.
-Eric
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-20 17:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-20 17:06 [PATCH] xfs_io: add missed inode command into man page Zorro Lang
2017-04-20 17:23 ` Darrick J. Wong
2017-04-20 17:45 ` Eric Sandeen
2017-04-20 17:48 ` Eric Sandeen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.