All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] dccp: Fix memleak in __feat_register_sp
@ 2019-03-22 13:43 ` Yue Haibing
  0 siblings, 0 replies; 6+ messages in thread
From: Yue Haibing @ 2019-03-22 13:43 UTC (permalink / raw)
  To: davem, gerrit; +Cc: linux-kernel, netdev, dccp, YueHaibing

From: YueHaibing <yuehaibing@huawei.com>

If dccp_feat_push_change fails, we forget free the mem
which is alloced by kmemdup in dccp_feat_clone_sp_val.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: kfree 'val --> 'fval'
---
 net/dccp/feat.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/dccp/feat.c b/net/dccp/feat.c
index f227f00..03275b2 100644
--- a/net/dccp/feat.c
+++ b/net/dccp/feat.c
@@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local,
 	if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len))
 		return -ENOMEM;
 
-	return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval);
+	if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) {
+		kfree(fval->sp.vec);
+		return -ENOMEM;
+	}
+
+	return 0;
 }
 
 /**
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [PATCH v2] dccp: Fix memleak in __feat_register_sp
@ 2019-03-22 13:43 ` Yue Haibing
  0 siblings, 0 replies; 6+ messages in thread
From: Yue Haibing @ 2019-03-22 13:43 UTC (permalink / raw)
  To: dccp

From: YueHaibing <yuehaibing@huawei.com>

If dccp_feat_push_change fails, we forget free the mem
which is alloced by kmemdup in dccp_feat_clone_sp_val.

Reported-by: Hulk Robot <hulkci@huawei.com>
Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: kfree 'val --> 'fval'
---
 net/dccp/feat.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/net/dccp/feat.c b/net/dccp/feat.c
index f227f00..03275b2 100644
--- a/net/dccp/feat.c
+++ b/net/dccp/feat.c
@@ -738,7 +738,12 @@ static int __feat_register_sp(struct list_head *fn, u8 feat, u8 is_local,
 	if (dccp_feat_clone_sp_val(&fval, sp_val, sp_len))
 		return -ENOMEM;
 
-	return dccp_feat_push_change(fn, feat, is_local, mandatory, &fval);
+	if (dccp_feat_push_change(fn, feat, is_local, mandatory, &fval)) {
+		kfree(fval->sp.vec);
+		return -ENOMEM;
+	}
+
+	return 0;
 }
 
 /**
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] dccp: Fix memleak in __feat_register_sp
  2019-03-22 13:43 ` Yue Haibing
@ 2019-03-25  0:12   ` David Miller
  -1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2019-03-25  0:12 UTC (permalink / raw)
  To: yuehaibing; +Cc: gerrit, linux-kernel, netdev, dccp

From: Yue Haibing <yuehaibing@huawei.com>
Date: Fri, 22 Mar 2019 21:43:48 +0800

> From: YueHaibing <yuehaibing@huawei.com>
> 
> If dccp_feat_push_change fails, we forget free the mem
> which is alloced by kmemdup in dccp_feat_clone_sp_val.
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v2: kfree 'val --> 'fval'

Don't submit any patches for at least 2 days, I am getting really tired of
changes you don't even COMPILE TEST:

  CC [M]  net/dccp/feat.o
net/dccp/feat.c: In function ‘__feat_register_sp’:
net/dccp/feat.c:742:13: error: invalid type argument of ‘->’ (have ‘dccp_feat_val’ {aka ‘union <anonymous>’})
   kfree(fval->sp.vec);
             ^~

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] dccp: Fix memleak in __feat_register_sp
@ 2019-03-25  0:12   ` David Miller
  0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2019-03-25  0:12 UTC (permalink / raw)
  To: dccp

RnJvbTogWXVlIEhhaWJpbmcgPHl1ZWhhaWJpbmdAaHVhd2VpLmNvbT4NCkRhdGU6IEZyaSwgMjIg
TWFyIDIwMTkgMjE6NDM6NDggKzA4MDANCg0KPiBGcm9tOiBZdWVIYWliaW5nIDx5dWVoYWliaW5n
QGh1YXdlaS5jb20+DQo+IA0KPiBJZiBkY2NwX2ZlYXRfcHVzaF9jaGFuZ2UgZmFpbHMsIHdlIGZv
cmdldCBmcmVlIHRoZSBtZW0NCj4gd2hpY2ggaXMgYWxsb2NlZCBieSBrbWVtZHVwIGluIGRjY3Bf
ZmVhdF9jbG9uZV9zcF92YWwuDQo+IA0KPiBSZXBvcnRlZC1ieTogSHVsayBSb2JvdCA8aHVsa2Np
QGh1YXdlaS5jb20+DQo+IEZpeGVzOiBlOGVmOTY3YTU0ZjQgKCJkY2NwOiBSZWdpc3RyYXRpb24g
cm91dGluZXMgZm9yIGNoYW5naW5nIGZlYXR1cmUgdmFsdWVzIikNCj4gU2lnbmVkLW9mZi1ieTog
WXVlSGFpYmluZyA8eXVlaGFpYmluZ0BodWF3ZWkuY29tPg0KPiAtLS0NCj4gdjI6IGtmcmVlICd2
YWwgLS0+ICdmdmFsJw0KDQpEb24ndCBzdWJtaXQgYW55IHBhdGNoZXMgZm9yIGF0IGxlYXN0IDIg
ZGF5cywgSSBhbSBnZXR0aW5nIHJlYWxseSB0aXJlZCBvZg0KY2hhbmdlcyB5b3UgZG9uJ3QgZXZl
biBDT01QSUxFIFRFU1Q6DQoNCiAgQ0MgW01dICBuZXQvZGNjcC9mZWF0Lm8NCm5ldC9kY2NwL2Zl
YXQuYzogSW4gZnVuY3Rpb24goV9fZmVhdF9yZWdpc3Rlcl9zcKI6DQpuZXQvZGNjcC9mZWF0LmM6
NzQyOjEzOiBlcnJvcjogaW52YWxpZCB0eXBlIGFyZ3VtZW50IG9mIKEtPqIgKGhhdmUgoWRjY3Bf
ZmVhdF92YWyiIHtha2EgoXVuaW9uIDxhbm9ueW1vdXM+on0pDQogICBrZnJlZShmdmFsLT5zcC52
ZWMpOw0KICAgICAgICAgICAgIF5+DQo

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] dccp: Fix memleak in __feat_register_sp
  2019-03-22 13:43 ` Yue Haibing
@ 2019-03-25  2:51     ` YueHaibing
  -1 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-03-25  2:51 UTC (permalink / raw)
  To: David Miller; +Cc: gerrit, linux-kernel, netdev, dccp


On 2019/3/25 8:12, David Miller wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
> Date: Fri, 22 Mar 2019 21:43:48 +0800
> 
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> If dccp_feat_push_change fails, we forget free the mem
>> which is alloced by kmemdup in dccp_feat_clone_sp_val.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> v2: kfree 'val --> 'fval'
> 
> Don't submit any patches for at least 2 days, I am getting really tired of
> changes you don't even COMPILE TEST:
> 
>   CC [M]  net/dccp/feat.o
> net/dccp/feat.c: In function ‘__feat_register_sp’:
> net/dccp/feat.c:742:13: error: invalid type argument of ‘->’ (have ‘dccp_feat_val’ {aka ‘union <anonymous>’})
>    kfree(fval->sp.vec);
>       

I'm very sorry for this, will self-reflection.

       ^~
> 


^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH v2] dccp: Fix memleak in __feat_register_sp
@ 2019-03-25  2:51     ` YueHaibing
  0 siblings, 0 replies; 6+ messages in thread
From: YueHaibing @ 2019-03-25  2:51 UTC (permalink / raw)
  To: dccp


On 2019/3/25 8:12, David Miller wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
> Date: Fri, 22 Mar 2019 21:43:48 +0800
> 
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> If dccp_feat_push_change fails, we forget free the mem
>> which is alloced by kmemdup in dccp_feat_clone_sp_val.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> v2: kfree 'val --> 'fval'
> 
> Don't submit any patches for at least 2 days, I am getting really tired of
> changes you don't even COMPILE TEST:
> 
>   CC [M]  net/dccp/feat.o
> net/dccp/feat.c: In function ¡__feat_register_sp¢:
> net/dccp/feat.c:742:13: error: invalid type argument of ¡->¢ (have ¡dccp_feat_val¢ {aka ¡union <anonymous>¢})
>    kfree(fval->sp.vec);
>       

I'm very sorry for this, will self-reflection.

       ^~
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-25  2:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-22 13:43 [PATCH v2] dccp: Fix memleak in __feat_register_sp Yue Haibing
2019-03-22 13:43 ` Yue Haibing
2019-03-25  0:12 ` David Miller
2019-03-25  0:12   ` David Miller
2019-03-25  2:51   ` YueHaibing
2019-03-25  2:51     ` YueHaibing

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.