All of lore.kernel.org
 help / color / mirror / Atom feed
* [vgupta-arc:for-next 3/4] arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
@ 2022-04-26  0:41 ` kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2022-04-26  0:41 UTC (permalink / raw)
  To: Sergey Matyukevich; +Cc: kbuild-all, linux-kernel, linux-snps-arc, Vineet Gupta

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git for-next
head:   e88856183749fd59759cd4c617f9ecec8280d8fa
commit: b08a66fb680018b621fd8be641c537c625132ab3 [3/4] ARC: disasm: handle ARCv2 case in kprobe get/set functions
config: arc-randconfig-r012-20220425 (https://download.01.org/0day-ci/archive/20220426/202204260826.d9fdltJm-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git/commit/?id=b08a66fb680018b621fd8be641c537c625132ab3
        git remote add vgupta-arc https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git
        git fetch --no-tags vgupta-arc for-next
        git checkout b08a66fb680018b621fd8be641c537c625132ab3
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/arc/kernel/disasm.c: In function 'disasm_instr':
   arch/arc/kernel/disasm.c:28:19: warning: variable 'ins_ptr' set but not used [-Wunused-but-set-variable]
      28 |         uint16_t *ins_ptr;
         |                   ^~~~~~~
   arch/arc/kernel/disasm.c: In function 'set_reg':
>> arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
     494 |                 regs->gp = val;
         |                       ^~
         |                       fp


vim +494 arch/arc/kernel/disasm.c

   475	
   476	void __kprobes set_reg(int reg, long val, struct pt_regs *regs,
   477			struct callee_regs *cregs)
   478	{
   479		long *p;
   480	
   481	#if defined(CONFIG_ISA_ARCOMPACT)
   482		switch (reg) {
   483		case 0 ... 12:
   484			p = &regs->r0;
   485			p[-reg] = val;
   486			break;
   487		case 13 ... 25:
   488			if (cregs) {
   489				p = &cregs->r13;
   490				p[13 - reg] = val;
   491			}
   492			break;
   493		case 26:
 > 494			regs->gp = val;
   495			break;
   496		case 27:
   497			regs->fp = val;
   498			break;
   499		case 28:
   500			regs->sp = val;
   501			break;
   502		case 31:
   503			regs->blink = val;
   504			break;
   505		default:
   506			break;
   507		}
   508	#else /* CONFIG_ISA_ARCV2 */
   509		switch (reg) {
   510		case 0 ... 11:
   511			p = &regs->r0;
   512			p[reg] = val;
   513			break;
   514		case 12:
   515			regs->r12 = val;
   516			break;
   517		case 13 ... 25:
   518			if (cregs) {
   519				p = &cregs->r13;
   520				p[13 - reg] = val;
   521			}
   522			break;
   523		case 26:
   524			regs->r26 = val;
   525			break;
   526		case 27:
   527			regs->fp = val;
   528			break;
   529		case 28:
   530			regs->sp = val;
   531			break;
   532		case 30:
   533			regs->r30 = val;
   534			break;
   535		case 31:
   536			regs->blink = val;
   537			break;
   538	#ifdef CONFIG_ARC_HAS_ACCL_REGS
   539		case 58:
   540			regs->r58 = val;
   541			break;
   542		case 59:
   543			regs->r59 = val;
   544			break;
   545	#endif
   546		default:
   547			break;
   548		}
   549	#endif
   550	}
   551	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [vgupta-arc:for-next 3/4] arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
@ 2022-04-26  0:41 ` kernel test robot
  0 siblings, 0 replies; 6+ messages in thread
From: kernel test robot @ 2022-04-26  0:41 UTC (permalink / raw)
  To: Sergey Matyukevich; +Cc: kbuild-all, linux-kernel, linux-snps-arc, Vineet Gupta

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git for-next
head:   e88856183749fd59759cd4c617f9ecec8280d8fa
commit: b08a66fb680018b621fd8be641c537c625132ab3 [3/4] ARC: disasm: handle ARCv2 case in kprobe get/set functions
config: arc-randconfig-r012-20220425 (https://download.01.org/0day-ci/archive/20220426/202204260826.d9fdltJm-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git/commit/?id=b08a66fb680018b621fd8be641c537c625132ab3
        git remote add vgupta-arc https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git
        git fetch --no-tags vgupta-arc for-next
        git checkout b08a66fb680018b621fd8be641c537c625132ab3
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   arch/arc/kernel/disasm.c: In function 'disasm_instr':
   arch/arc/kernel/disasm.c:28:19: warning: variable 'ins_ptr' set but not used [-Wunused-but-set-variable]
      28 |         uint16_t *ins_ptr;
         |                   ^~~~~~~
   arch/arc/kernel/disasm.c: In function 'set_reg':
>> arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
     494 |                 regs->gp = val;
         |                       ^~
         |                       fp


vim +494 arch/arc/kernel/disasm.c

   475	
   476	void __kprobes set_reg(int reg, long val, struct pt_regs *regs,
   477			struct callee_regs *cregs)
   478	{
   479		long *p;
   480	
   481	#if defined(CONFIG_ISA_ARCOMPACT)
   482		switch (reg) {
   483		case 0 ... 12:
   484			p = &regs->r0;
   485			p[-reg] = val;
   486			break;
   487		case 13 ... 25:
   488			if (cregs) {
   489				p = &cregs->r13;
   490				p[13 - reg] = val;
   491			}
   492			break;
   493		case 26:
 > 494			regs->gp = val;
   495			break;
   496		case 27:
   497			regs->fp = val;
   498			break;
   499		case 28:
   500			regs->sp = val;
   501			break;
   502		case 31:
   503			regs->blink = val;
   504			break;
   505		default:
   506			break;
   507		}
   508	#else /* CONFIG_ISA_ARCV2 */
   509		switch (reg) {
   510		case 0 ... 11:
   511			p = &regs->r0;
   512			p[reg] = val;
   513			break;
   514		case 12:
   515			regs->r12 = val;
   516			break;
   517		case 13 ... 25:
   518			if (cregs) {
   519				p = &cregs->r13;
   520				p[13 - reg] = val;
   521			}
   522			break;
   523		case 26:
   524			regs->r26 = val;
   525			break;
   526		case 27:
   527			regs->fp = val;
   528			break;
   529		case 28:
   530			regs->sp = val;
   531			break;
   532		case 30:
   533			regs->r30 = val;
   534			break;
   535		case 31:
   536			regs->blink = val;
   537			break;
   538	#ifdef CONFIG_ARC_HAS_ACCL_REGS
   539		case 58:
   540			regs->r58 = val;
   541			break;
   542		case 59:
   543			regs->r59 = val;
   544			break;
   545	#endif
   546		default:
   547			break;
   548		}
   549	#endif
   550	}
   551	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [vgupta-arc:for-next 3/4] arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
  2022-04-26  0:41 ` kernel test robot
@ 2022-04-26  7:31   ` Sergey Matyukevich
  -1 siblings, 0 replies; 6+ messages in thread
From: Sergey Matyukevich @ 2022-04-26  7:31 UTC (permalink / raw)
  To: linux-snps-arc; +Cc: kbuild-all, Vineet Gupta


Hello Vineet,

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git for-next
> head:   e88856183749fd59759cd4c617f9ecec8280d8fa
> commit: b08a66fb680018b621fd8be641c537c625132ab3 [3/4] ARC: disasm: handle ARCv2 case in kprobe get/set functions
> config: arc-randconfig-r012-20220425 (https://download.01.org/0day-ci/archive/20220426/202204260826.d9fdltJm-lkp@intel.com/config)
> compiler: arceb-elf-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git/commit/?id=b08a66fb680018b621fd8be641c537c625132ab3
>         git remote add vgupta-arc https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git
>         git fetch --no-tags vgupta-arc for-next
>         git checkout b08a66fb680018b621fd8be641c537c625132ab3
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    arch/arc/kernel/disasm.c: In function 'disasm_instr':
>    arch/arc/kernel/disasm.c:28:19: warning: variable 'ins_ptr' set but not used [-Wunused-but-set-variable]
>       28 |         uint16_t *ins_ptr;
>          |                   ^~~~~~~
>    arch/arc/kernel/disasm.c: In function 'set_reg':
> >> arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
>      494 |                 regs->gp = val;
>          |                       ^~
>          |                       fp

I have just sent a fixup for this snafu:
https://lore.kernel.org/linux-snps-arc/20220426072447.125975-1-geomatsi@gmail.com/T/#u

IIUC, you have not yet sent a pull-request for next release. So probably
it makes sense to squash this commit with b08a66fb680018b6 ("ARC: disasm:
handle ARCv2 case in kprobe get/set functions").

Regards,
Sergey

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [vgupta-arc:for-next 3/4] arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
@ 2022-04-26  7:31   ` Sergey Matyukevich
  0 siblings, 0 replies; 6+ messages in thread
From: Sergey Matyukevich @ 2022-04-26  7:31 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 2241 bytes --]


Hello Vineet,

> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git for-next
> head:   e88856183749fd59759cd4c617f9ecec8280d8fa
> commit: b08a66fb680018b621fd8be641c537c625132ab3 [3/4] ARC: disasm: handle ARCv2 case in kprobe get/set functions
> config: arc-randconfig-r012-20220425 (https://download.01.org/0day-ci/archive/20220426/202204260826.d9fdltJm-lkp(a)intel.com/config)
> compiler: arceb-elf-gcc (GCC) 11.3.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git/commit/?id=b08a66fb680018b621fd8be641c537c625132ab3
>         git remote add vgupta-arc https://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc.git
>         git fetch --no-tags vgupta-arc for-next
>         git checkout b08a66fb680018b621fd8be641c537c625132ab3
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    arch/arc/kernel/disasm.c: In function 'disasm_instr':
>    arch/arc/kernel/disasm.c:28:19: warning: variable 'ins_ptr' set but not used [-Wunused-but-set-variable]
>       28 |         uint16_t *ins_ptr;
>          |                   ^~~~~~~
>    arch/arc/kernel/disasm.c: In function 'set_reg':
> >> arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
>      494 |                 regs->gp = val;
>          |                       ^~
>          |                       fp

I have just sent a fixup for this snafu:
https://lore.kernel.org/linux-snps-arc/20220426072447.125975-1-geomatsi(a)gmail.com/T/#u

IIUC, you have not yet sent a pull-request for next release. So probably
it makes sense to squash this commit with b08a66fb680018b6 ("ARC: disasm:
handle ARCv2 case in kprobe get/set functions").

Regards,
Sergey

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [vgupta-arc:for-next 3/4] arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
  2022-04-26  7:31   ` Sergey Matyukevich
@ 2022-04-27  4:04     ` Vineet Gupta
  -1 siblings, 0 replies; 6+ messages in thread
From: Vineet Gupta @ 2022-04-27  4:04 UTC (permalink / raw)
  To: Sergey Matyukevich, linux-snps-arc; +Cc: kbuild-all, Vineet Gupta

On 4/26/22 00:31, Sergey Matyukevich wrote:
> I have just sent a fixup for this snafu:
> https://lore.kernel.org/linux-snps-arc/20220426072447.125975-1-geomatsi@gmail.com/T/#u
>
> IIUC, you have not yet sent a pull-request for next release. So probably
> it makes sense to squash this commit with b08a66fb680018b6 ("ARC: disasm:
> handle ARCv2 case in kprobe get/set functions").

Yes this is merge-window stuff so will go in next cycle.
I've added a fixup and push for-next.

Thx,
-Vineet

_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [vgupta-arc:for-next 3/4] arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'?
@ 2022-04-27  4:04     ` Vineet Gupta
  0 siblings, 0 replies; 6+ messages in thread
From: Vineet Gupta @ 2022-04-27  4:04 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 503 bytes --]

On 4/26/22 00:31, Sergey Matyukevich wrote:
> I have just sent a fixup for this snafu:
> https://lore.kernel.org/linux-snps-arc/20220426072447.125975-1-geomatsi(a)gmail.com/T/#u
>
> IIUC, you have not yet sent a pull-request for next release. So probably
> it makes sense to squash this commit with b08a66fb680018b6 ("ARC: disasm:
> handle ARCv2 case in kprobe get/set functions").

Yes this is merge-window stuff so will go in next cycle.
I've added a fixup and push for-next.

Thx,
-Vineet

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-04-27  4:04 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26  0:41 [vgupta-arc:for-next 3/4] arch/arc/kernel/disasm.c:494:23: error: 'struct pt_regs' has no member named 'gp'; did you mean 'fp'? kernel test robot
2022-04-26  0:41 ` kernel test robot
2022-04-26  7:31 ` Sergey Matyukevich
2022-04-26  7:31   ` Sergey Matyukevich
2022-04-27  4:04   ` Vineet Gupta
2022-04-27  4:04     ` Vineet Gupta

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.