All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Luba <l.luba@partner.samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: b.zolnierkie@samsung.com, krzk@kernel.org, robh+dt@kernel.org,
	mark.rutland@arm.com, kyungmin.park@samsung.com,
	m.szyprowski@samsung.com, s.nawrocki@samsung.com,
	myungjoo.ham@samsung.com, kgene@kernel.org,
	willy.mh.wolff.ml@gmail.com
Subject: Re: [PATCH v3 4/4] DT: arm: exynos4412: add event data type which is monitored
Date: Tue, 30 Apr 2019 23:24:27 +0200	[thread overview]
Message-ID: <f8873863-9524-1ef0-9633-868edc3b56d3@partner.samsung.com> (raw)
In-Reply-To: <cee7b5a2-377e-59d6-7c6e-b6f9b3140d4f@samsung.com>



On 4/30/19 8:10 AM, Chanwoo Choi wrote:
> Hi,
> 
> On 19. 4. 19. 오후 10:48, Lukasz Luba wrote:
>> The patch adds new field in the PPMU event which shows explicitly
>> what kind of data the event is monitoring. It is possible to change it
>> using defined values in exynos_ppmu.h file.
>>
>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi b/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>> index 3a3b2fa..549faba 100644
>> --- a/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>> @@ -6,12 +6,16 @@
>>    * Author: Chanwoo Choi <cw00.choi@samsung.com>
>>    */
>>   
>> +#include <dt-bindings/pmu/exynos_ppmu.h>
>> +
>>   &ppmu_dmc0 {
>>          status = "okay";
>>   
>>          events {
>>   	       ppmu_dmc0_3: ppmu-event3-dmc0 {
>>   		       event-name = "ppmu-event3-dmc0";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>> @@ -22,6 +26,8 @@
>>          events {
>>   	       ppmu_dmc1_3: ppmu-event3-dmc1 {
>>   		       event-name = "ppmu-event3-dmc1";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>> @@ -32,6 +38,8 @@
>>          events {
>>   	       ppmu_leftbus_3: ppmu-event3-leftbus {
>>   		       event-name = "ppmu-event3-leftbus";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>> @@ -42,6 +50,8 @@
>>          events {
>>   	       ppmu_rightbus_3: ppmu-event3-rightbus {
>>   		       event-name = "ppmu-event3-rightbus";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>>
> 
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Thank you, added to the patch.

Regards,
Lukasz
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Lukasz Luba <l.luba@partner.samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: mark.rutland@arm.com, willy.mh.wolff.ml@gmail.com,
	kgene@kernel.org, b.zolnierkie@samsung.com, krzk@kernel.org,
	kyungmin.park@samsung.com, robh+dt@kernel.org,
	myungjoo.ham@samsung.com, s.nawrocki@samsung.com,
	m.szyprowski@samsung.com
Subject: Re: [PATCH v3 4/4] DT: arm: exynos4412: add event data type which is monitored
Date: Tue, 30 Apr 2019 23:24:27 +0200	[thread overview]
Message-ID: <f8873863-9524-1ef0-9633-868edc3b56d3@partner.samsung.com> (raw)
In-Reply-To: <cee7b5a2-377e-59d6-7c6e-b6f9b3140d4f@samsung.com>



On 4/30/19 8:10 AM, Chanwoo Choi wrote:
> Hi,
> 
> On 19. 4. 19. 오후 10:48, Lukasz Luba wrote:
>> The patch adds new field in the PPMU event which shows explicitly
>> what kind of data the event is monitoring. It is possible to change it
>> using defined values in exynos_ppmu.h file.
>>
>> Signed-off-by: Lukasz Luba <l.luba@partner.samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos4412-ppmu-common.dtsi | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi b/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>> index 3a3b2fa..549faba 100644
>> --- a/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>> +++ b/arch/arm/boot/dts/exynos4412-ppmu-common.dtsi
>> @@ -6,12 +6,16 @@
>>    * Author: Chanwoo Choi <cw00.choi@samsung.com>
>>    */
>>   
>> +#include <dt-bindings/pmu/exynos_ppmu.h>
>> +
>>   &ppmu_dmc0 {
>>          status = "okay";
>>   
>>          events {
>>   	       ppmu_dmc0_3: ppmu-event3-dmc0 {
>>   		       event-name = "ppmu-event3-dmc0";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>> @@ -22,6 +26,8 @@
>>          events {
>>   	       ppmu_dmc1_3: ppmu-event3-dmc1 {
>>   		       event-name = "ppmu-event3-dmc1";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>> @@ -32,6 +38,8 @@
>>          events {
>>   	       ppmu_leftbus_3: ppmu-event3-leftbus {
>>   		       event-name = "ppmu-event3-leftbus";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>> @@ -42,6 +50,8 @@
>>          events {
>>   	       ppmu_rightbus_3: ppmu-event3-rightbus {
>>   		       event-name = "ppmu-event3-rightbus";
>> +		       event-data-type = <(PPMU_RO_DATA_CNT |
>> +					   PPMU_WO_DATA_CNT)>;
>>   	       };
>>          };
>>   };
>>
> 
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
Thank you, added to the patch.

Regards,
Lukasz
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-04-30 21:24 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190419134818eucas1p1d121f99f6c018c27254f0af8cab5ea64@eucas1p1.samsung.com>
2019-04-19 13:48 ` [PATCH v3 0/4] Exynos Performance Monitoring Counters enhancements Lukasz Luba
2019-04-19 13:48   ` Lukasz Luba
2019-04-19 13:48   ` Lukasz Luba
     [not found]   ` <CGME20190419134820eucas1p154e839769af0e1b8bae17ce3efa0ba93@eucas1p1.samsung.com>
2019-04-19 13:48     ` [PATCH v3 1/4] include: dt-bindings: add Performance Monitoring Unit for Exynos Lukasz Luba
2019-04-19 13:48       ` Lukasz Luba
2019-04-19 13:48       ` Lukasz Luba
2019-04-30  4:56       ` Chanwoo Choi
2019-04-30  4:56         ` Chanwoo Choi
2019-04-30 20:36         ` Lukasz Luba
2019-04-30 20:36           ` Lukasz Luba
2019-04-30 22:33       ` Rob Herring
2019-04-30 22:33         ` Rob Herring
2019-04-30 22:33         ` Rob Herring
2019-05-02  9:16         ` Lukasz Luba
2019-05-02  9:16           ` Lukasz Luba
     [not found]   ` <CGME20190419134821eucas1p2461a27e28387ff2b87c149f09582d2a0@eucas1p2.samsung.com>
2019-04-19 13:48     ` [PATCH v3 2/4] drivers: devfreq: events: extend events by type of counted data Lukasz Luba
2019-04-19 13:48       ` Lukasz Luba
2019-04-19 13:48       ` Lukasz Luba
2019-04-30  7:34       ` Chanwoo Choi
2019-04-30  7:34         ` Chanwoo Choi
2019-04-30 21:19         ` Lukasz Luba
2019-04-30 21:19           ` Lukasz Luba
2019-05-02  1:25           ` Chanwoo Choi
2019-05-02  1:25             ` Chanwoo Choi
2019-05-02  9:07             ` Lukasz Luba
2019-05-02  9:07               ` Lukasz Luba
     [not found]   ` <CGME20190419134822eucas1p29c6eff0f500311749b33c4f556123cf0@eucas1p2.samsung.com>
2019-04-19 13:48     ` [PATCH v3 3/4] Documentation: devicetree: add PPMU events description Lukasz Luba
2019-04-19 13:48       ` Lukasz Luba
2019-04-19 13:48       ` Lukasz Luba
2019-04-30  6:16       ` Chanwoo Choi
2019-04-30  6:16         ` Chanwoo Choi
2019-04-30 21:23         ` Lukasz Luba
2019-04-30 21:23           ` Lukasz Luba
2019-05-02 10:11         ` Lukasz Luba
2019-05-02 10:11           ` Lukasz Luba
2019-04-30 22:36       ` Rob Herring
2019-04-30 22:36         ` Rob Herring
2019-05-02  8:52         ` Lukasz Luba
2019-05-02  8:52           ` Lukasz Luba
2019-05-02 20:24           ` Rob Herring
2019-05-02 20:24             ` Rob Herring
2019-05-02 20:24             ` Rob Herring
2019-05-06 10:29             ` Lukasz Luba
2019-05-06 10:29               ` Lukasz Luba
2019-05-06 10:29               ` Lukasz Luba
2019-05-07  9:05               ` Lukasz Luba
2019-05-07  9:05                 ` Lukasz Luba
2019-05-07  9:05                 ` Lukasz Luba
2019-05-07 16:50                 ` Rob Herring
2019-05-07 16:50                   ` Rob Herring
2019-05-07 16:50                   ` Rob Herring
2019-05-08  8:28                   ` Lukasz Luba
2019-05-08  8:28                     ` Lukasz Luba
2019-05-08  8:28                     ` Lukasz Luba
     [not found]   ` <CGME20190419134823eucas1p1ff852194b1db655ed2dbce72b5f7f3a6@eucas1p1.samsung.com>
2019-04-19 13:48     ` [PATCH v3 4/4] DT: arm: exynos4412: add event data type which is monitored Lukasz Luba
2019-04-19 13:48       ` Lukasz Luba
2019-04-19 13:48       ` Lukasz Luba
2019-04-30  6:10       ` Chanwoo Choi
2019-04-30  6:10         ` Chanwoo Choi
2019-04-30 21:24         ` Lukasz Luba [this message]
2019-04-30 21:24           ` Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8873863-9524-1ef0-9633-868edc3b56d3@partner.samsung.com \
    --to=l.luba@partner.samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kgene@kernel.org \
    --cc=krzk@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mark.rutland@arm.com \
    --cc=myungjoo.ham@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=willy.mh.wolff.ml@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.