[PATCH] mt76x2: add a polling delay in mt76x2_mac_stop routine

[PATCH] mt76x2: add a polling delay in mt76x2_mac_stop routine

[Lorenzo Bianconi]

Add a usleep_range in mt76x2_mac_stop routine in order to add
a polling delay checking values of MT_MAC_STATUS and IBI_R12 registers

Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
 drivers/net/wireless/mediatek/mt76/mt76x2_init.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt76x2_init.c b/drivers/net/wireless/mediatek/mt76/mt76x2_init.c
index d21e4a7c1bb9..dd4c1127797e 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x2_init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x2_init.c
@@ -370,12 +370,12 @@ void mt76x2_mac_stop(struct mt76x2_dev *dev, bool force)
 
 	/* Wait for MAC to become idle */
 	for (i = 0; i < 300; i++) {
-		if (mt76_rr(dev, MT_MAC_STATUS) &
-		    (MT_MAC_STATUS_RX | MT_MAC_STATUS_TX))
-			continue;
-
-		if (mt76_rr(dev, MT_BBP(IBI, 12)))
+		if ((mt76_rr(dev, MT_MAC_STATUS) &
+		     (MT_MAC_STATUS_RX | MT_MAC_STATUS_TX)) ||
+		    mt76_rr(dev, MT_BBP(IBI, 12))) {
+			usleep_range(10, 20);
 			continue;
+		}
 
 		stopped = true;
 		break;
-- 
2.14.3

Re: [PATCH] mt76x2: add a polling delay in mt76x2_mac_stop routine

[Felix Fietkau]

On 2018-05-10 16:06, Lorenzo Bianconi wrote:
> Add a usleep_range in mt76x2_mac_stop routine in order to add
> a polling delay checking values of MT_MAC_STATUS and IBI_R12 registers
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Acked-by: Felix Fietkau <nbd@nbd.name>

Re: mt76x2: add a polling delay in mt76x2_mac_stop routine

[Kalle Valo]

Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote:

> Add a usleep_range in mt76x2_mac_stop routine in order to add
> a polling delay checking values of MT_MAC_STATUS and IBI_R12 registers
> 
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> Acked-by: Felix Fietkau <nbd@nbd.name>

Patch applied to wireless-drivers-next.git, thanks.

6823dc0d91e5 mt76x2: add a polling delay in mt76x2_mac_stop routine

-- 
https://patchwork.kernel.org/patch/10391839/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches