* [PATCH] xen, fbfront: mark expected switch fall-through
@ 2019-02-27 20:53 ` Gustavo A. R. Silva
0 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-27 20:53 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: dri-devel, linux-fbdev, linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (dev->state == XenbusStateClosed)
^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
case XenbusStateClosing:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/video/fbdev/xen-fbfront.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 6a4bbc9e1fb0..a3d6b6db221b 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
case XenbusStateClosed:
if (dev->state == XenbusStateClosed)
break;
- /* Missed the backend's CLOSING state -- fallthrough */
+ /* fall through - Missed the backend's CLOSING state. */
case XenbusStateClosing:
xenbus_frontend_closed(dev);
break;
--
2.21.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] xen, fbfront: mark expected switch fall-through
@ 2019-02-27 20:53 ` Gustavo A. R. Silva
0 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2019-02-27 20:53 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz
Cc: dri-devel, linux-fbdev, linux-kernel, Gustavo A. R. Silva, Kees Cook
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.
This patch fixes the following warning:
drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
if (dev->state = XenbusStateClosed)
^
drivers/video/fbdev/xen-fbfront.c:681:2: note: here
case XenbusStateClosing:
^~~~
Warning level 3 was used: -Wimplicit-fallthrough=3
Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.
This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
drivers/video/fbdev/xen-fbfront.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
index 6a4bbc9e1fb0..a3d6b6db221b 100644
--- a/drivers/video/fbdev/xen-fbfront.c
+++ b/drivers/video/fbdev/xen-fbfront.c
@@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
case XenbusStateClosed:
if (dev->state = XenbusStateClosed)
break;
- /* Missed the backend's CLOSING state -- fallthrough */
+ /* fall through - Missed the backend's CLOSING state. */
case XenbusStateClosing:
xenbus_frontend_closed(dev);
break;
--
2.21.0
^ permalink raw reply related [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
2019-02-27 20:53 ` Gustavo A. R. Silva
@ 2019-02-28 11:51 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 15+ messages in thread
From: Oleksandr Andrushchenko @ 2019-02-28 11:51 UTC (permalink / raw)
To: Gustavo A. R. Silva, Bartlomiej Zolnierkiewicz
Cc: Kees Cook, linux-fbdev, linux-kernel, dri-devel, xen-devel
+Xen-devel list
On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
> drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->state == XenbusStateClosed)
> ^
> drivers/video/fbdev/xen-fbfront.c:681:2: note: here
> case XenbusStateClosing:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/video/fbdev/xen-fbfront.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index 6a4bbc9e1fb0..a3d6b6db221b 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
> case XenbusStateClosed:
> if (dev->state == XenbusStateClosed)
> break;
> - /* Missed the backend's CLOSING state -- fallthrough */
> + /* fall through - Missed the backend's CLOSING state. */
> case XenbusStateClosing:
> xenbus_frontend_closed(dev);
> break;
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
@ 2019-02-28 11:51 ` Oleksandr Andrushchenko
0 siblings, 0 replies; 15+ messages in thread
From: Oleksandr Andrushchenko @ 2019-02-28 11:51 UTC (permalink / raw)
To: Gustavo A. R. Silva, Bartlomiej Zolnierkiewicz
Cc: Kees Cook, linux-fbdev, linux-kernel, dri-devel, xen-devel
+Xen-devel list
On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
> drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->state = XenbusStateClosed)
> ^
> drivers/video/fbdev/xen-fbfront.c:681:2: note: here
> case XenbusStateClosing:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/video/fbdev/xen-fbfront.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index 6a4bbc9e1fb0..a3d6b6db221b 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
> case XenbusStateClosed:
> if (dev->state = XenbusStateClosed)
> break;
> - /* Missed the backend's CLOSING state -- fallthrough */
> + /* fall through - Missed the backend's CLOSING state. */
> case XenbusStateClosing:
> xenbus_frontend_closed(dev);
> break;
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
2019-02-27 20:53 ` Gustavo A. R. Silva
(?)
@ 2019-02-28 11:51 ` Oleksandr Andrushchenko
-1 siblings, 0 replies; 15+ messages in thread
From: Oleksandr Andrushchenko @ 2019-02-28 11:51 UTC (permalink / raw)
To: Gustavo A. R. Silva, Bartlomiej Zolnierkiewicz
Cc: xen-devel, linux-fbdev, Kees Cook, dri-devel, linux-kernel
+Xen-devel list
On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wimplicit-fallthrough, mark switch
> cases where we are expecting to fall through.
>
> This patch fixes the following warning:
>
> drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
> drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
> if (dev->state == XenbusStateClosed)
> ^
> drivers/video/fbdev/xen-fbfront.c:681:2: note: here
> case XenbusStateClosing:
> ^~~~
>
> Warning level 3 was used: -Wimplicit-fallthrough=3
>
> Notice that, in this particular case, the code comment is modified
> in accordance with what GCC is expecting to find.
>
> This patch is part of the ongoing efforts to enable
> -Wimplicit-fallthrough.
>
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> drivers/video/fbdev/xen-fbfront.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
> index 6a4bbc9e1fb0..a3d6b6db221b 100644
> --- a/drivers/video/fbdev/xen-fbfront.c
> +++ b/drivers/video/fbdev/xen-fbfront.c
> @@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
> case XenbusStateClosed:
> if (dev->state == XenbusStateClosed)
> break;
> - /* Missed the backend's CLOSING state -- fallthrough */
> + /* fall through - Missed the backend's CLOSING state. */
> case XenbusStateClosing:
> xenbus_frontend_closed(dev);
> break;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
2019-02-28 11:51 ` Oleksandr Andrushchenko
(?)
@ 2019-03-20 20:08 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-20 20:08 UTC (permalink / raw)
To: Oleksandr Andrushchenko, Bartlomiej Zolnierkiewicz
Cc: Kees Cook, linux-fbdev, linux-kernel, dri-devel, xen-devel
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
On 2/28/19 5:51 AM, Oleksandr Andrushchenko wrote:
> +Xen-devel list
>
> On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
>> drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (dev->state == XenbusStateClosed)
>> ^
>> drivers/video/fbdev/xen-fbfront.c:681:2: note: here
>> case XenbusStateClosing:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/video/fbdev/xen-fbfront.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
>> index 6a4bbc9e1fb0..a3d6b6db221b 100644
>> --- a/drivers/video/fbdev/xen-fbfront.c
>> +++ b/drivers/video/fbdev/xen-fbfront.c
>> @@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
>> case XenbusStateClosed:
>> if (dev->state == XenbusStateClosed)
>> break;
>> - /* Missed the backend's CLOSING state -- fallthrough */
>> + /* fall through - Missed the backend's CLOSING state. */
>> case XenbusStateClosing:
>> xenbus_frontend_closed(dev);
>> break;
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
@ 2019-03-20 20:08 ` Gustavo A. R. Silva
0 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-20 20:08 UTC (permalink / raw)
To: Oleksandr Andrushchenko, Bartlomiej Zolnierkiewicz
Cc: xen-devel, linux-fbdev, Kees Cook, dri-devel, linux-kernel
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
On 2/28/19 5:51 AM, Oleksandr Andrushchenko wrote:
> +Xen-devel list
>
> On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
>> drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (dev->state = XenbusStateClosed)
>> ^
>> drivers/video/fbdev/xen-fbfront.c:681:2: note: here
>> case XenbusStateClosing:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/video/fbdev/xen-fbfront.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
>> index 6a4bbc9e1fb0..a3d6b6db221b 100644
>> --- a/drivers/video/fbdev/xen-fbfront.c
>> +++ b/drivers/video/fbdev/xen-fbfront.c
>> @@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
>> case XenbusStateClosed:
>> if (dev->state = XenbusStateClosed)
>> break;
>> - /* Missed the backend's CLOSING state -- fallthrough */
>> + /* fall through - Missed the backend's CLOSING state. */
>> case XenbusStateClosing:
>> xenbus_frontend_closed(dev);
>> break;
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
@ 2019-03-20 20:08 ` Gustavo A. R. Silva
0 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-20 20:08 UTC (permalink / raw)
To: Oleksandr Andrushchenko, Bartlomiej Zolnierkiewicz
Cc: xen-devel, linux-fbdev, Kees Cook, dri-devel, linux-kernel
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
On 2/28/19 5:51 AM, Oleksandr Andrushchenko wrote:
> +Xen-devel list
>
> On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
>> drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (dev->state == XenbusStateClosed)
>> ^
>> drivers/video/fbdev/xen-fbfront.c:681:2: note: here
>> case XenbusStateClosing:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/video/fbdev/xen-fbfront.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
>> index 6a4bbc9e1fb0..a3d6b6db221b 100644
>> --- a/drivers/video/fbdev/xen-fbfront.c
>> +++ b/drivers/video/fbdev/xen-fbfront.c
>> @@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
>> case XenbusStateClosed:
>> if (dev->state == XenbusStateClosed)
>> break;
>> - /* Missed the backend's CLOSING state -- fallthrough */
>> + /* fall through - Missed the backend's CLOSING state. */
>> case XenbusStateClosing:
>> xenbus_frontend_closed(dev);
>> break;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
2019-02-28 11:51 ` Oleksandr Andrushchenko
(?)
(?)
@ 2019-03-20 20:08 ` Gustavo A. R. Silva
-1 siblings, 0 replies; 15+ messages in thread
From: Gustavo A. R. Silva @ 2019-03-20 20:08 UTC (permalink / raw)
To: Oleksandr Andrushchenko, Bartlomiej Zolnierkiewicz
Cc: xen-devel, linux-fbdev, Kees Cook, dri-devel, linux-kernel
Hi all,
Friendly ping:
Who can take this?
Thanks
--
Gustavo
On 2/28/19 5:51 AM, Oleksandr Andrushchenko wrote:
> +Xen-devel list
>
> On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>> cases where we are expecting to fall through.
>>
>> This patch fixes the following warning:
>>
>> drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
>> drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>> if (dev->state == XenbusStateClosed)
>> ^
>> drivers/video/fbdev/xen-fbfront.c:681:2: note: here
>> case XenbusStateClosing:
>> ^~~~
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> Notice that, in this particular case, the code comment is modified
>> in accordance with what GCC is expecting to find.
>>
>> This patch is part of the ongoing efforts to enable
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>> drivers/video/fbdev/xen-fbfront.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
>> index 6a4bbc9e1fb0..a3d6b6db221b 100644
>> --- a/drivers/video/fbdev/xen-fbfront.c
>> +++ b/drivers/video/fbdev/xen-fbfront.c
>> @@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
>> case XenbusStateClosed:
>> if (dev->state == XenbusStateClosed)
>> break;
>> - /* Missed the backend's CLOSING state -- fallthrough */
>> + /* fall through - Missed the backend's CLOSING state. */
>> case XenbusStateClosing:
>> xenbus_frontend_closed(dev);
>> break;
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
2019-03-20 20:08 ` Gustavo A. R. Silva
@ 2019-03-21 11:03 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 15+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-03-21 11:03 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Oleksandr Andrushchenko, Kees Cook, linux-fbdev, linux-kernel,
dri-devel, xen-devel
Hi,
On 03/20/2019 09:08 PM, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping:
>
> Who can take this?
I'll take this for v5.2.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> Thanks
> --
> Gustavo
>
> On 2/28/19 5:51 AM, Oleksandr Andrushchenko wrote:
>> +Xen-devel list
>>
>> On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
>>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>>> cases where we are expecting to fall through.
>>>
>>> This patch fixes the following warning:
>>>
>>> drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
>>> drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>> if (dev->state == XenbusStateClosed)
>>> ^
>>> drivers/video/fbdev/xen-fbfront.c:681:2: note: here
>>> case XenbusStateClosing:
>>> ^~~~
>>>
>>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>>
>>> Notice that, in this particular case, the code comment is modified
>>> in accordance with what GCC is expecting to find.
>>>
>>> This patch is part of the ongoing efforts to enable
>>> -Wimplicit-fallthrough.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>> ---
>>> drivers/video/fbdev/xen-fbfront.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
>>> index 6a4bbc9e1fb0..a3d6b6db221b 100644
>>> --- a/drivers/video/fbdev/xen-fbfront.c
>>> +++ b/drivers/video/fbdev/xen-fbfront.c
>>> @@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
>>> case XenbusStateClosed:
>>> if (dev->state == XenbusStateClosed)
>>> break;
>>> - /* Missed the backend's CLOSING state -- fallthrough */
>>> + /* fall through - Missed the backend's CLOSING state. */
>>> case XenbusStateClosing:
>>> xenbus_frontend_closed(dev);
>>> break;
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
@ 2019-03-21 11:03 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 15+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-03-21 11:03 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Oleksandr Andrushchenko, Kees Cook, linux-fbdev, linux-kernel,
dri-devel, xen-devel
Hi,
On 03/20/2019 09:08 PM, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping:
>
> Who can take this?
I'll take this for v5.2.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> Thanks
> --
> Gustavo
>
> On 2/28/19 5:51 AM, Oleksandr Andrushchenko wrote:
>> +Xen-devel list
>>
>> On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
>>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>>> cases where we are expecting to fall through.
>>>
>>> This patch fixes the following warning:
>>>
>>> drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
>>> drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>> if (dev->state = XenbusStateClosed)
>>> ^
>>> drivers/video/fbdev/xen-fbfront.c:681:2: note: here
>>> case XenbusStateClosing:
>>> ^~~~
>>>
>>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>>
>>> Notice that, in this particular case, the code comment is modified
>>> in accordance with what GCC is expecting to find.
>>>
>>> This patch is part of the ongoing efforts to enable
>>> -Wimplicit-fallthrough.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>> ---
>>> drivers/video/fbdev/xen-fbfront.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
>>> index 6a4bbc9e1fb0..a3d6b6db221b 100644
>>> --- a/drivers/video/fbdev/xen-fbfront.c
>>> +++ b/drivers/video/fbdev/xen-fbfront.c
>>> @@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
>>> case XenbusStateClosed:
>>> if (dev->state = XenbusStateClosed)
>>> break;
>>> - /* Missed the backend's CLOSING state -- fallthrough */
>>> + /* fall through - Missed the backend's CLOSING state. */
>>> case XenbusStateClosing:
>>> xenbus_frontend_closed(dev);
>>> break;
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
2019-03-20 20:08 ` Gustavo A. R. Silva
` (2 preceding siblings ...)
(?)
@ 2019-03-21 11:03 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 15+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-03-21 11:03 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: linux-fbdev, Kees Cook, Oleksandr Andrushchenko, linux-kernel,
dri-devel, xen-devel
Hi,
On 03/20/2019 09:08 PM, Gustavo A. R. Silva wrote:
> Hi all,
>
> Friendly ping:
>
> Who can take this?
I'll take this for v5.2.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> Thanks
> --
> Gustavo
>
> On 2/28/19 5:51 AM, Oleksandr Andrushchenko wrote:
>> +Xen-devel list
>>
>> On 2/27/19 10:53 PM, Gustavo A. R. Silva wrote:
>>> In preparation to enabling -Wimplicit-fallthrough, mark switch
>>> cases where we are expecting to fall through.
>>>
>>> This patch fixes the following warning:
>>>
>>> drivers/video/fbdev/xen-fbfront.c: In function ‘xenfb_backend_changed’:
>>> drivers/video/fbdev/xen-fbfront.c:678:6: warning: this statement may fall through [-Wimplicit-fallthrough=]
>>> if (dev->state == XenbusStateClosed)
>>> ^
>>> drivers/video/fbdev/xen-fbfront.c:681:2: note: here
>>> case XenbusStateClosing:
>>> ^~~~
>>>
>>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>>
>>> Notice that, in this particular case, the code comment is modified
>>> in accordance with what GCC is expecting to find.
>>>
>>> This patch is part of the ongoing efforts to enable
>>> -Wimplicit-fallthrough.
>>>
>>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>>> ---
>>> drivers/video/fbdev/xen-fbfront.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/video/fbdev/xen-fbfront.c b/drivers/video/fbdev/xen-fbfront.c
>>> index 6a4bbc9e1fb0..a3d6b6db221b 100644
>>> --- a/drivers/video/fbdev/xen-fbfront.c
>>> +++ b/drivers/video/fbdev/xen-fbfront.c
>>> @@ -677,7 +677,7 @@ static void xenfb_backend_changed(struct xenbus_device *dev,
>>> case XenbusStateClosed:
>>> if (dev->state == XenbusStateClosed)
>>> break;
>>> - /* Missed the backend's CLOSING state -- fallthrough */
>>> + /* fall through - Missed the backend's CLOSING state. */
>>> case XenbusStateClosing:
>>> xenbus_frontend_closed(dev);
>>> break;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
2019-03-21 11:03 ` Bartlomiej Zolnierkiewicz
@ 2019-04-01 12:54 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 15+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-04-01 12:54 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Oleksandr Andrushchenko, Kees Cook, linux-fbdev, linux-kernel,
dri-devel, xen-devel
On 03/21/2019 12:03 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On 03/20/2019 09:08 PM, Gustavo A. R. Silva wrote:
>> Hi all,
>>
>> Friendly ping:
>>
>> Who can take this?
>
> I'll take this for v5.2.
Patch queued for v5.2, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
@ 2019-04-01 12:54 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 15+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-04-01 12:54 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: Oleksandr Andrushchenko, Kees Cook, linux-fbdev, linux-kernel,
dri-devel, xen-devel
On 03/21/2019 12:03 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On 03/20/2019 09:08 PM, Gustavo A. R. Silva wrote:
>> Hi all,
>>
>> Friendly ping:
>>
>> Who can take this?
>
> I'll take this for v5.2.
Patch queued for v5.2, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] xen, fbfront: mark expected switch fall-through
2019-03-21 11:03 ` Bartlomiej Zolnierkiewicz
(?)
(?)
@ 2019-04-01 12:54 ` Bartlomiej Zolnierkiewicz
-1 siblings, 0 replies; 15+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-04-01 12:54 UTC (permalink / raw)
To: Gustavo A. R. Silva
Cc: linux-fbdev, Kees Cook, Oleksandr Andrushchenko, linux-kernel,
dri-devel, xen-devel
On 03/21/2019 12:03 PM, Bartlomiej Zolnierkiewicz wrote:
>
> Hi,
>
> On 03/20/2019 09:08 PM, Gustavo A. R. Silva wrote:
>> Hi all,
>>
>> Friendly ping:
>>
>> Who can take this?
>
> I'll take this for v5.2.
Patch queued for v5.2, thanks.
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2019-04-01 12:54 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-27 20:53 [PATCH] xen, fbfront: mark expected switch fall-through Gustavo A. R. Silva
2019-02-27 20:53 ` Gustavo A. R. Silva
2019-02-28 11:51 ` Oleksandr Andrushchenko
2019-02-28 11:51 ` Oleksandr Andrushchenko
2019-02-28 11:51 ` Oleksandr Andrushchenko
2019-03-20 20:08 ` Gustavo A. R. Silva
2019-03-20 20:08 ` Gustavo A. R. Silva
2019-03-20 20:08 ` Gustavo A. R. Silva
2019-03-21 11:03 ` Bartlomiej Zolnierkiewicz
2019-03-21 11:03 ` Bartlomiej Zolnierkiewicz
2019-04-01 12:54 ` Bartlomiej Zolnierkiewicz
2019-04-01 12:54 ` Bartlomiej Zolnierkiewicz
2019-04-01 12:54 ` Bartlomiej Zolnierkiewicz
2019-03-21 11:03 ` Bartlomiej Zolnierkiewicz
2019-03-20 20:08 ` Gustavo A. R. Silva
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.