From: Joe Perches <joe@perches.com> To: Julia Lawall <julia.lawall@lip6.fr> Cc: cocci <cocci@systeme.lip6.fr>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] Date: Tue, 23 Jul 2019 21:37:51 -0700 [thread overview] Message-ID: <f909b4b31f123c7d88535db397a04421077ed0ab.camel@perches.com> (raw) In-Reply-To: <alpine.DEB.2.21.1907232326360.2539@hadrien> On Tue, 2019-07-23 at 23:27 -0500, Julia Lawall wrote: > > On Tue, 23 Jul 2019, Joe Perches wrote: > > > On Tue, 2019-07-23 at 22:54 -0500, Julia Lawall wrote: > > > A seantic patch and the resulting output for the case where the third > > > arugument is a constant is attached. Likewise the resulting output on a > > > recent linux-next. > > > > > > julia > > > > Nice. Thanks Julia > > > > A couple issues: > > > > There is a problem with conversions with assignments > > of strlcpy() so ideally the cocci script should make sure > > any return value was not used before conversion. > > > > This is not a provably good conversion: > > > > drivers/s390/char/sclp_ftp.c > > @@ -114,8 +114,7 @@ static int sclp_ftp_et7(const struct hmc > > sccb->evbuf.mdd.ftp.length = ftp->len; > > sccb->evbuf.mdd.ftp.bufaddr = virt_to_phys(ftp->buf); > > > > - len = strlcpy(sccb->evbuf.mdd.ftp.fident, ftp->fname, > > - HMCDRV_FTP_FIDENT_MAX); > > + len = stracpy(sccb->evbuf.mdd.ftp.fident, ftp->fname); > > Sorry, I don't understand the issue here. What specifically should I be > looking for? The return value of strlcpy differs from (strscpy or stracpy). strlcpy returns the length of the src string str[sa]cpy returns the length of the src string if it fits in dest or -E2BIG if src is truncated by the size of dest or -E2BIG if dest is 0 length Any use of the strlcpy return value should not be converted because the logic after an assignment or use of the return value can not be assured to have the same behavior. > > And: > > > > I would have expected the bit below to find and convert uses like > > drivers/hwmon/adc128d818.c: strlcpy(info->type, "adc128d818", I2C_NAME_SIZE); > > but it seems none of those were converted. > > OK, thanks. I will check on it. Thanks again. > julia > > > I don't know why. > > > > //------------------------------------------ > > @r1@ > > struct i1 *e1; > > expression e2; > > identifier f,i1,i2; > > position p; > > @@ > > \(strscpy\|strlcpy\)(e1->f, e2, i2)@p > > > > @@ > > identifier r1.i1,r1.i2; > > type T; > > @@ > > struct i1 { ... T i1[i2]; ... } > > > > @@ > > identifier f,i2; > > expression e1,e2; > > position r1.p; > > @@ > > ( > > -strscpy > > +stracpy > > -strlcpy > > +stracpy > > )(e1->f, e2 > > - , i2 > > )@p > > //------------------------------------------ > > > > to find > > > >
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com> To: Julia Lawall <julia.lawall@lip6.fr> Cc: cocci <cocci@systeme.lip6.fr>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [Cocci] [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] Date: Tue, 23 Jul 2019 21:37:51 -0700 [thread overview] Message-ID: <f909b4b31f123c7d88535db397a04421077ed0ab.camel@perches.com> (raw) In-Reply-To: <alpine.DEB.2.21.1907232326360.2539@hadrien> On Tue, 2019-07-23 at 23:27 -0500, Julia Lawall wrote: > > On Tue, 23 Jul 2019, Joe Perches wrote: > > > On Tue, 2019-07-23 at 22:54 -0500, Julia Lawall wrote: > > > A seantic patch and the resulting output for the case where the third > > > arugument is a constant is attached. Likewise the resulting output on a > > > recent linux-next. > > > > > > julia > > > > Nice. Thanks Julia > > > > A couple issues: > > > > There is a problem with conversions with assignments > > of strlcpy() so ideally the cocci script should make sure > > any return value was not used before conversion. > > > > This is not a provably good conversion: > > > > drivers/s390/char/sclp_ftp.c > > @@ -114,8 +114,7 @@ static int sclp_ftp_et7(const struct hmc > > sccb->evbuf.mdd.ftp.length = ftp->len; > > sccb->evbuf.mdd.ftp.bufaddr = virt_to_phys(ftp->buf); > > > > - len = strlcpy(sccb->evbuf.mdd.ftp.fident, ftp->fname, > > - HMCDRV_FTP_FIDENT_MAX); > > + len = stracpy(sccb->evbuf.mdd.ftp.fident, ftp->fname); > > Sorry, I don't understand the issue here. What specifically should I be > looking for? The return value of strlcpy differs from (strscpy or stracpy). strlcpy returns the length of the src string str[sa]cpy returns the length of the src string if it fits in dest or -E2BIG if src is truncated by the size of dest or -E2BIG if dest is 0 length Any use of the strlcpy return value should not be converted because the logic after an assignment or use of the return value can not be assured to have the same behavior. > > And: > > > > I would have expected the bit below to find and convert uses like > > drivers/hwmon/adc128d818.c: strlcpy(info->type, "adc128d818", I2C_NAME_SIZE); > > but it seems none of those were converted. > > OK, thanks. I will check on it. Thanks again. > julia > > > I don't know why. > > > > //------------------------------------------ > > @r1@ > > struct i1 *e1; > > expression e2; > > identifier f,i1,i2; > > position p; > > @@ > > \(strscpy\|strlcpy\)(e1->f, e2, i2)@p > > > > @@ > > identifier r1.i1,r1.i2; > > type T; > > @@ > > struct i1 { ... T i1[i2]; ... } > > > > @@ > > identifier f,i2; > > expression e1,e2; > > position r1.p; > > @@ > > ( > > -strscpy > > +stracpy > > -strlcpy > > +stracpy > > )(e1->f, e2 > > - , i2 > > )@p > > //------------------------------------------ > > > > to find > > > > _______________________________________________ Cocci mailing list Cocci@systeme.lip6.fr https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-07-24 4:37 UTC|newest] Thread overview: 82+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-07-23 0:38 [PATCH 0/2] string: Add stracpy and stracpy_pad Joe Perches 2019-07-23 0:38 ` [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms Joe Perches 2019-07-23 0:46 ` [Cocci] [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] Joe Perches 2019-07-23 20:52 ` Julia Lawall 2019-07-23 20:52 ` [Cocci] " Julia Lawall 2019-07-23 23:42 ` Joe Perches 2019-07-23 23:42 ` [Cocci] " Joe Perches 2019-07-24 3:54 ` Julia Lawall 2019-07-24 3:54 ` [Cocci] " Julia Lawall 2019-07-24 4:19 ` Joe Perches 2019-07-24 4:19 ` [Cocci] " Joe Perches 2019-07-24 4:27 ` Julia Lawall 2019-07-24 4:27 ` [Cocci] " Julia Lawall 2019-07-24 4:37 ` Joe Perches [this message] 2019-07-24 4:37 ` Joe Perches 2019-07-24 10:28 ` David Laight 2019-07-24 10:28 ` [Cocci] " David Laight 2019-07-24 10:43 ` Joe Perches 2019-07-24 10:43 ` [Cocci] " Joe Perches 2019-07-24 11:45 ` Julia Lawall 2019-07-24 11:45 ` [Cocci] " Julia Lawall 2019-07-25 1:42 ` Julia Lawall 2019-07-25 1:42 ` [Cocci] " Julia Lawall 2019-07-25 7:46 ` [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms Markus Elfring 2019-07-25 7:46 ` [Cocci] " Markus Elfring 2019-07-25 7:46 ` Markus Elfring 2019-07-25 11:34 ` Julia Lawall 2019-07-25 11:34 ` [Cocci] " Julia Lawall 2019-07-25 11:34 ` Julia Lawall 2019-07-25 12:40 ` [1/2] " Markus Elfring 2019-07-25 12:40 ` [Cocci] " Markus Elfring 2019-07-25 12:40 ` Markus Elfring 2019-07-25 13:45 ` [PATCH 1/2] " Markus Elfring 2019-07-25 13:45 ` [Cocci] " Markus Elfring 2019-07-25 13:45 ` Markus Elfring 2019-07-25 13:48 ` Julia Lawall 2019-07-25 13:48 ` [Cocci] " Julia Lawall 2019-07-25 13:48 ` Julia Lawall 2019-07-25 14:48 ` [1/2] " Markus Elfring 2019-07-25 14:48 ` [Cocci] " Markus Elfring 2019-07-25 14:48 ` Markus Elfring 2019-07-25 13:50 ` [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] Joe Perches 2019-07-25 13:50 ` [Cocci] " Joe Perches 2019-07-25 13:58 ` Julia Lawall 2019-07-25 13:58 ` [Cocci] " Julia Lawall 2019-07-25 14:12 ` Joe Perches 2019-07-25 14:12 ` [Cocci] " Joe Perches 2019-07-25 22:51 ` Julia Lawall 2019-07-25 22:51 ` [Cocci] " Julia Lawall 2019-07-26 6:15 ` [1/2] string: Add stracpy and stracpy_pad mechanisms Markus Elfring 2019-07-26 6:15 ` [Cocci] " Markus Elfring 2019-07-26 6:15 ` Markus Elfring 2019-07-29 14:07 ` [Fwd: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms] Julia Lawall 2019-07-29 14:07 ` [Cocci] " Julia Lawall 2019-07-29 16:28 ` Joe Perches 2019-07-29 16:28 ` [Cocci] " Joe Perches 2019-07-23 4:35 ` [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms Andrew Morton 2019-07-23 4:42 ` Joe Perches 2019-07-23 4:42 ` Joe Perches 2019-07-23 21:29 ` Kees Cook 2019-07-23 6:55 ` Rasmus Villemoes 2019-07-23 15:41 ` David Laight 2019-07-23 15:41 ` David Laight 2019-07-23 15:50 ` Joe Perches 2019-07-23 15:50 ` Joe Perches 2019-07-23 21:34 ` Kees Cook 2019-07-23 21:34 ` Kees Cook 2019-07-24 12:05 ` Yann Droneaud 2019-07-24 12:05 ` Yann Droneaud 2019-07-24 13:09 ` Rasmus Villemoes 2019-07-24 13:09 ` Rasmus Villemoes 2019-07-24 17:08 ` Linus Torvalds 2019-07-24 17:08 ` Linus Torvalds 2019-07-25 20:03 ` Kees Cook 2019-07-25 20:03 ` Kees Cook 2019-07-26 2:46 ` Joe Perches 2019-07-26 2:46 ` Joe Perches 2019-07-23 21:36 ` Kees Cook 2019-07-24 11:40 ` Joe Perches 2019-07-24 11:40 ` Joe Perches 2019-07-23 0:38 ` [PATCH 2/2] kernel-doc: core-api: Include string.h into core-api Joe Perches 2019-07-23 21:28 ` Kees Cook
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f909b4b31f123c7d88535db397a04421077ed0ab.camel@perches.com \ --to=joe@perches.com \ --cc=cocci@systeme.lip6.fr \ --cc=julia.lawall@lip6.fr \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.