* [PATCH] x86/shutdown: add fall-through comment
@ 2016-11-07 9:26 Jan Beulich
2016-11-07 10:23 ` Andrew Cooper
2016-11-07 10:42 ` Wei Liu
0 siblings, 2 replies; 3+ messages in thread
From: Jan Beulich @ 2016-11-07 9:26 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Wei Liu
[-- Attachment #1: Type: text/plain, Size: 432 bytes --]
Coverity ID: 1362037
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -541,6 +541,7 @@ void machine_restart(unsigned int delay_
{
case BOOT_INVALID:
ASSERT_UNREACHABLE();
+ /* fall through */
case BOOT_KBD:
/* Pulse the keyboard reset line. */
for ( i = 0; i < 100; i++ )
[-- Attachment #2: x86-shutdown-fallthrough.patch --]
[-- Type: text/plain, Size: 468 bytes --]
x86/shutdown: add fall-through comment
Coverity ID: 1362037
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/shutdown.c
+++ b/xen/arch/x86/shutdown.c
@@ -541,6 +541,7 @@ void machine_restart(unsigned int delay_
{
case BOOT_INVALID:
ASSERT_UNREACHABLE();
+ /* fall through */
case BOOT_KBD:
/* Pulse the keyboard reset line. */
for ( i = 0; i < 100; i++ )
[-- Attachment #3: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/shutdown: add fall-through comment
2016-11-07 9:26 [PATCH] x86/shutdown: add fall-through comment Jan Beulich
@ 2016-11-07 10:23 ` Andrew Cooper
2016-11-07 10:42 ` Wei Liu
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cooper @ 2016-11-07 10:23 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Wei Liu
On 07/11/16 09:26, Jan Beulich wrote:
> Coverity ID: 1362037
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/shutdown.c
> +++ b/xen/arch/x86/shutdown.c
> @@ -541,6 +541,7 @@ void machine_restart(unsigned int delay_
> {
> case BOOT_INVALID:
> ASSERT_UNREACHABLE();
> + /* fall through */
> case BOOT_KBD:
> /* Pulse the keyboard reset line. */
> for ( i = 0; i < 100; i++ )
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] x86/shutdown: add fall-through comment
2016-11-07 9:26 [PATCH] x86/shutdown: add fall-through comment Jan Beulich
2016-11-07 10:23 ` Andrew Cooper
@ 2016-11-07 10:42 ` Wei Liu
1 sibling, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-11-07 10:42 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Wei Liu, Andrew Cooper
On Mon, Nov 07, 2016 at 02:26:11AM -0700, Jan Beulich wrote:
> Coverity ID: 1362037
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/shutdown.c
> +++ b/xen/arch/x86/shutdown.c
> @@ -541,6 +541,7 @@ void machine_restart(unsigned int delay_
> {
> case BOOT_INVALID:
> ASSERT_UNREACHABLE();
> + /* fall through */
> case BOOT_KBD:
> /* Pulse the keyboard reset line. */
> for ( i = 0; i < 100; i++ )
>
>
>
> x86/shutdown: add fall-through comment
>
> Coverity ID: 1362037
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-07 10:55 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-07 9:26 [PATCH] x86/shutdown: add fall-through comment Jan Beulich
2016-11-07 10:23 ` Andrew Cooper
2016-11-07 10:42 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.