From: Eric Blake <eblake@redhat.com>
To: "Markus Armbruster" <armbru@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Stefan Hajnoczi" <stefanha@gmail.com>,
qemu-devel@nongnu.org, "Liviu Ionescu" <ilg@livius.net>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Michal Suchánek" <msuchanek@suse.de>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Aleksandar Markovic" <aleksandar.m.mail@gmail.com>
Subject: Re: [PATCH v2] configure: warn if not using a separate build directory
Date: Tue, 31 Mar 2020 12:12:02 -0500 [thread overview]
Message-ID: <f9330c17-79da-a120-f13f-0a6b51c31235@redhat.com> (raw)
In-Reply-To: <87wo70sdnr.fsf@dusky.pond.sub.org>
On 3/31/20 11:16 AM, Markus Armbruster wrote:
> Daniel P. Berrangé <berrange@redhat.com> writes:
>
>> Running configure directly from the source directory is a build
>> configuration that will go away in future. It is also not currently
>> covered by any automated testing. Display a deprecation warning if
>> the user attempts to use an in-srcdir build setup, so that they are
>> aware that they're building QEMU in an undesirable manner.
>>
>> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
>> ---
>>
>> +if test "$in_srcdir" = "yes"; then
>> + echo
>> + echo "WARNING: SUPPORT FOR IN SOURCE DIR BUILDS IS DEPRECATED"
>
> I don't like shouted warnings, but it's consistent with what we have.
The grammar is also a bit awkward to parse; maybe:
support for building in the source directory is deprecated
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
prev parent reply other threads:[~2020-03-31 17:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 15:51 [PATCH v2] configure: warn if not using a separate build directory Daniel P. Berrangé
2020-03-31 16:05 ` Eric Blake
2020-03-31 16:12 ` Peter Maydell
2020-03-31 16:18 ` Daniel P. Berrangé
2020-03-31 16:16 ` Markus Armbruster
2020-03-31 17:12 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f9330c17-79da-a120-f13f-0a6b51c31235@redhat.com \
--to=eblake@redhat.com \
--cc=aleksandar.m.mail@gmail.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=ilg@livius.net \
--cc=kwolf@redhat.com \
--cc=msuchanek@suse.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.