* [PATCH mptcp-next] mptcp: drop unused sk in mptcp_push_release
@ 2021-10-18 3:39 Geliang Tang
2021-10-18 17:04 ` Matthieu Baerts
0 siblings, 1 reply; 2+ messages in thread
From: Geliang Tang @ 2021-10-18 3:39 UTC (permalink / raw)
To: mptcp; +Cc: Geliang Tang
Since mptcp_set_timeout() had removed from mptcp_push_release() in
commit 33d41c9cd74c5 ("mptcp: more accurate timeout"), the argument
sk in mptcp_push_release() became useless. Let's drop it.
Signed-off-by: Geliang Tang <geliang.tang@suse.com>
---
net/mptcp/protocol.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index 33b94f705096..7803b0dbb1be 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -1469,8 +1469,7 @@ static struct sock *mptcp_subflow_get_send(struct mptcp_sock *msk)
return NULL;
}
-static void mptcp_push_release(struct sock *sk, struct sock *ssk,
- struct mptcp_sendmsg_info *info)
+static void mptcp_push_release(struct sock *ssk, struct mptcp_sendmsg_info *info)
{
tcp_push(ssk, 0, info->mss_now, tcp_sk(ssk)->nonagle, info->size_goal);
release_sock(ssk);
@@ -1533,7 +1532,7 @@ void __mptcp_push_pending(struct sock *sk, unsigned int flags)
* the last round, release prev_ssk
*/
if (ssk != prev_ssk && prev_ssk)
- mptcp_push_release(sk, prev_ssk, &info);
+ mptcp_push_release(prev_ssk, &info);
if (!ssk)
goto out;
@@ -1546,7 +1545,7 @@ void __mptcp_push_pending(struct sock *sk, unsigned int flags)
ret = mptcp_sendmsg_frag(sk, ssk, dfrag, &info);
if (ret <= 0) {
- mptcp_push_release(sk, ssk, &info);
+ mptcp_push_release(ssk, &info);
goto out;
}
@@ -1561,7 +1560,7 @@ void __mptcp_push_pending(struct sock *sk, unsigned int flags)
/* at this point we held the socket lock for the last subflow we used */
if (ssk)
- mptcp_push_release(sk, ssk, &info);
+ mptcp_push_release(ssk, &info);
out:
/* ensure the rtx timer is running */
--
2.31.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH mptcp-next] mptcp: drop unused sk in mptcp_push_release
2021-10-18 3:39 [PATCH mptcp-next] mptcp: drop unused sk in mptcp_push_release Geliang Tang
@ 2021-10-18 17:04 ` Matthieu Baerts
0 siblings, 0 replies; 2+ messages in thread
From: Matthieu Baerts @ 2021-10-18 17:04 UTC (permalink / raw)
To: Geliang Tang; +Cc: mptcp
Hi Geliang,
On 18/10/2021 05:39, Geliang Tang wrote:
> Since mptcp_set_timeout() had removed from mptcp_push_release() in
> commit 33d41c9cd74c5 ("mptcp: more accurate timeout"), the argument
> sk in mptcp_push_release() became useless. Let's drop it.
Good catch and thank you for the patch!
It is now in our tree (for net-next) with a Fixes tag.
- 04e012677aa1: mptcp: drop unused sk in mptcp_push_release
- Results: 2c9a91c34b69..cec4678228e9
Builds and tests are now in progress:
https://cirrus-ci.com/github/multipath-tcp/mptcp_net-next/export/20211018T170406
https://github.com/multipath-tcp/mptcp_net-next/actions/workflows/build-validation.yml?query=branch:export/20211018T170406
Cheers,
Matt
--
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-18 17:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18 3:39 [PATCH mptcp-next] mptcp: drop unused sk in mptcp_push_release Geliang Tang
2021-10-18 17:04 ` Matthieu Baerts
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.