All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: vigneshr@ti.com, kristo@kernel.org, srk@ti.com,
	r-gunasekaran@ti.com, linux-arm-kernel@lists.infradead.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: Enable Type-C port for USB0
Date: Wed, 29 Mar 2023 10:06:11 +0300	[thread overview]
Message-ID: <f9352150-9d2f-71f7-fc60-bd09b6de0522@kernel.org> (raw)
In-Reply-To: <20230328215234.ug7x34rjfiv7ixhi@trimness>



On 29/03/2023 00:52, Nishanth Menon wrote:
> On 22:46-20230328, Roger Quadros wrote:
> [...]
>>>>> 	How about sk-lp ?
>>>>
>>>> moved it to sk-lp. see above in this patch.
>>>>
>>>
>>> A bit confused. Looking at [1] vs [2], it seems to indicate pd controller at
>>> 0x3f as well? Am I misreading the schematics?
>>>
>>> [1] https://www.ti.com/tool/SK-AM62-LP#design-files
>>> [2] https://www.ti.com/tool/SK-AM62#design-files
>>
>> Yes PD controller is at 0x3f for both boards but IRQ is not routed on AM62-LP.
>> I tried to explain this the cover letter. ;)
>>
>> Pasting here for convenience.
>>
>>> Although k3-am625-lp-sk USB is exactly the same as on k3-am625-sk,
>>> it is missing the IRQ line from Type-C chip which is currently
>>> required as per chip's DT binding. So we don't add Type-C support
>>> for k3-am625-lp-sk till h/w is fixed or polling mode support for
>>> Type-C chip is accepted [2]
>>>
>>> [2] - https://lore.kernel.org/lkml/20230324133741.43408-1-rogerq@kernel.org/T/
> 
> Thanks, This thread does seem to be progressing? Since LP-SK is already
> in production, it might do good to hold on to this series a little
> longer instead of shuttling dts nodes back and forth.
> 

I agree. This will need a re-spin.

cheers,
-roger

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: vigneshr@ti.com, kristo@kernel.org, srk@ti.com,
	r-gunasekaran@ti.com, linux-arm-kernel@lists.infradead.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: Enable Type-C port for USB0
Date: Wed, 29 Mar 2023 10:06:11 +0300	[thread overview]
Message-ID: <f9352150-9d2f-71f7-fc60-bd09b6de0522@kernel.org> (raw)
In-Reply-To: <20230328215234.ug7x34rjfiv7ixhi@trimness>



On 29/03/2023 00:52, Nishanth Menon wrote:
> On 22:46-20230328, Roger Quadros wrote:
> [...]
>>>>> 	How about sk-lp ?
>>>>
>>>> moved it to sk-lp. see above in this patch.
>>>>
>>>
>>> A bit confused. Looking at [1] vs [2], it seems to indicate pd controller at
>>> 0x3f as well? Am I misreading the schematics?
>>>
>>> [1] https://www.ti.com/tool/SK-AM62-LP#design-files
>>> [2] https://www.ti.com/tool/SK-AM62#design-files
>>
>> Yes PD controller is at 0x3f for both boards but IRQ is not routed on AM62-LP.
>> I tried to explain this the cover letter. ;)
>>
>> Pasting here for convenience.
>>
>>> Although k3-am625-lp-sk USB is exactly the same as on k3-am625-sk,
>>> it is missing the IRQ line from Type-C chip which is currently
>>> required as per chip's DT binding. So we don't add Type-C support
>>> for k3-am625-lp-sk till h/w is fixed or polling mode support for
>>> Type-C chip is accepted [2]
>>>
>>> [2] - https://lore.kernel.org/lkml/20230324133741.43408-1-rogerq@kernel.org/T/
> 
> Thanks, This thread does seem to be progressing? Since LP-SK is already
> in production, it might do good to hold on to this series a little
> longer instead of shuttling dts nodes back and forth.
> 

I agree. This will need a re-spin.

cheers,
-roger

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-03-29  7:07 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-28 12:43 [PATCH v2 0/2] arm64: dts: ti: k3-am625-sk: Enable Type-C dual-role Roger Quadros
2023-03-28 12:43 ` Roger Quadros
2023-03-28 12:43 ` [PATCH v2 1/2] arm64: dts: ti: k3-am625-sk: Add ti,vbus-divider property to usbss1 Roger Quadros
2023-03-28 12:43   ` Roger Quadros
2023-03-28 12:43 ` [PATCH v2 2/2] arm64: dts: ti: k3-am625-sk: Enable Type-C port for USB0 Roger Quadros
2023-03-28 12:43   ` Roger Quadros
2023-03-28 13:18   ` Nishanth Menon
2023-03-28 13:18     ` Nishanth Menon
2023-03-28 13:20     ` Roger Quadros
2023-03-28 13:20       ` Roger Quadros
2023-03-28 13:30       ` Nishanth Menon
2023-03-28 13:30         ` Nishanth Menon
2023-03-28 19:46         ` Roger Quadros
2023-03-28 19:46           ` Roger Quadros
2023-03-28 21:52           ` Nishanth Menon
2023-03-28 21:52             ` Nishanth Menon
2023-03-29  7:06             ` Roger Quadros [this message]
2023-03-29  7:06               ` Roger Quadros
2023-03-30  2:16 ` (subset) [PATCH v2 0/2] arm64: dts: ti: k3-am625-sk: Enable Type-C dual-role Nishanth Menon
2023-03-30  2:16   ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9352150-9d2f-71f7-fc60-bd09b6de0522@kernel.org \
    --to=rogerq@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=kristo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=r-gunasekaran@ti.com \
    --cc=srk@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.