All of lore.kernel.org
 help / color / mirror / Atom feed
* dma: axi-dmac: assign `copy_align` property
@ 2019-02-26  7:19 Ardelean, Alexandru
  0 siblings, 0 replies; 4+ messages in thread
From: Ardelean, Alexandru @ 2019-02-26  7:19 UTC (permalink / raw)
  To: vkoul; +Cc: dmaengine

On Mon, 2019-02-25 at 12:25 +0530, Vinod Koul wrote:
> [External]
> 
> 
> On 15-02-19, 13:02, Alexandru Ardelean wrote:
> > The `copy_align` property is a generic property that describes
> > alignment
> > for DMA memcpy & sg ops.
> > It serves mostly an informational purpose, and can be used in DMA
> > tests, to
> > pass the info to know what alignment to expect.
> 
> This looks fine but fails to apply for me. When sending patches please
> send against the tree you wish this patch to be applied to..

Weird, I remember patching this into one of the brances from here:
https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git/

I forget which one [probably the `next` branch ?]

I'll re-visit this.

> 
> Also please fix the subsystem tag..

Ack

> 
> --
> ~Vinod

^ permalink raw reply	[flat|nested] 4+ messages in thread

* dma: axi-dmac: assign `copy_align` property
@ 2019-02-26  8:03 Vinod Koul
  0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2019-02-26  8:03 UTC (permalink / raw)
  To: Ardelean, Alexandru; +Cc: dmaengine

On 26-02-19, 07:19, Ardelean, Alexandru wrote:
> On Mon, 2019-02-25 at 12:25 +0530, Vinod Koul wrote:
> > [External]
> > 
> > 
> > On 15-02-19, 13:02, Alexandru Ardelean wrote:
> > > The `copy_align` property is a generic property that describes
> > > alignment
> > > for DMA memcpy & sg ops.
> > > It serves mostly an informational purpose, and can be used in DMA
> > > tests, to
> > > pass the info to know what alignment to expect.
> > 
> > This looks fine but fails to apply for me. When sending patches please
> > send against the tree you wish this patch to be applied to..
> 
> Weird, I remember patching this into one of the brances from here:
> https://git.kernel.org/pub/scm/linux/kernel/git/vkoul/slave-dma.git/
> 
> I forget which one [probably the `next` branch ?]

next one is typically fine.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* dma: axi-dmac: assign `copy_align` property
@ 2019-02-25  6:55 Vinod Koul
  0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2019-02-25  6:55 UTC (permalink / raw)
  To: Alexandru Ardelean; +Cc: dmaengine

On 15-02-19, 13:02, Alexandru Ardelean wrote:
> The `copy_align` property is a generic property that describes alignment
> for DMA memcpy & sg ops.
> It serves mostly an informational purpose, and can be used in DMA tests, to
> pass the info to know what alignment to expect.

This looks fine but fails to apply for me. When sending patches please
send against the tree you wish this patch to be applied to..

Also please fix the subsystem tag..

^ permalink raw reply	[flat|nested] 4+ messages in thread

* dma: axi-dmac: assign `copy_align` property
@ 2019-02-15 11:02 Alexandru Ardelean
  0 siblings, 0 replies; 4+ messages in thread
From: Alexandru Ardelean @ 2019-02-15 11:02 UTC (permalink / raw)
  To: dmaengine, vkoul; +Cc: Alexandru Ardelean

The `copy_align` property is a generic property that describes alignment
for DMA memcpy & sg ops.
It serves mostly an informational purpose, and can be used in DMA tests, to
pass the info to know what alignment to expect.

Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
 drivers/dma/dma-axi-dmac.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c
index a54157ab00b2..a58aee7090dd 100644
--- a/drivers/dma/dma-axi-dmac.c
+++ b/drivers/dma/dma-axi-dmac.c
@@ -814,6 +814,8 @@ static int axi_dmac_probe(struct platform_device *pdev)
 	if (ret)
 		goto err_clk_disable;
 
+	dma_dev->copy_align = (dmac->chan.address_align_mask + 1);
+
 	axi_dmac_write(dmac, AXI_DMAC_REG_IRQ_MASK, 0x00);
 
 	ret = dma_async_device_register(dma_dev);

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-02-26  8:03 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-26  7:19 dma: axi-dmac: assign `copy_align` property Ardelean, Alexandru
  -- strict thread matches above, loose matches on Subject: below --
2019-02-26  8:03 Vinod Koul
2019-02-25  6:55 Vinod Koul
2019-02-15 11:02 Alexandru Ardelean

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.