All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/dfu-util: allow to build it for the target as well
@ 2017-09-20 15:31 Wolfgang Grandegger
  2017-09-21 21:09 ` Arnout Vandecappelle
  0 siblings, 1 reply; 3+ messages in thread
From: Wolfgang Grandegger @ 2017-09-20 15:31 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
---
 package/Config.in            | 1 +
 package/dfu-util/Config.in   | 8 ++++++++
 package/dfu-util/dfu-util.mk | 2 ++
 3 files changed, 11 insertions(+)
 create mode 100644 package/dfu-util/Config.in

diff --git a/package/Config.in b/package/Config.in
index 48d1381..b493201 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -389,6 +389,7 @@ endmenu
 	source "package/dbus-python/Config.in"
 	source "package/dbus-triggerd/Config.in"
 	source "package/devmem2/Config.in"
+	source "package/dfu-util/Config.in"
 	source "package/dmidecode/Config.in"
 	source "package/dmraid/Config.in"
 	source "package/dt-utils/Config.in"
diff --git a/package/dfu-util/Config.in b/package/dfu-util/Config.in
new file mode 100644
index 0000000..77b7f2d
--- /dev/null
+++ b/package/dfu-util/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_DFU_UTIL
+	bool "dfu-util"
+	help
+	  Dfu-util is the host side implementation of the DFU 1.0
+	  specification of the USB forum. DFU is intended to download
+	  and upload firmware to devices connected over USB.
+
+	  http://dfu-util.sourceforge.net/
diff --git a/package/dfu-util/dfu-util.mk b/package/dfu-util/dfu-util.mk
index c494485..5e8ba5a 100644
--- a/package/dfu-util/dfu-util.mk
+++ b/package/dfu-util/dfu-util.mk
@@ -9,6 +9,8 @@ DFU_UTIL_SITE = http://dfu-util.sourceforge.net/releases
 DFU_UTIL_LICENSE = GPL-2.0+
 DFU_UTIL_LICENSE_FILES = COPYING
 
+DFU_UTIL_DEPENDENCIES = libusb
 HOST_DFU_UTIL_DEPENDENCIES = host-libusb
 
+$(eval $(autotools-package))
 $(eval $(host-autotools-package))
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/dfu-util: allow to build it for the target as well
  2017-09-20 15:31 [Buildroot] [PATCH] package/dfu-util: allow to build it for the target as well Wolfgang Grandegger
@ 2017-09-21 21:09 ` Arnout Vandecappelle
  2017-09-22  6:20   ` Wolfgang Grandegger
  0 siblings, 1 reply; 3+ messages in thread
From: Arnout Vandecappelle @ 2017-09-21 21:09 UTC (permalink / raw)
  To: buildroot



On 20-09-17 17:31, Wolfgang Grandegger wrote:
> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>

 Have you tested this at all?

Makefile:537: *** libusb is in the dependency chain of dfu-util that has added
it to its _DEPENDENCIES variable without selecting it or depending on it from
Config.in.  Stop.

 And therefore you also need to propagate the threads dependency and add a comment.

 Regards,
 Arnout


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] package/dfu-util: allow to build it for the target as well
  2017-09-21 21:09 ` Arnout Vandecappelle
@ 2017-09-22  6:20   ` Wolfgang Grandegger
  0 siblings, 0 replies; 3+ messages in thread
From: Wolfgang Grandegger @ 2017-09-22  6:20 UTC (permalink / raw)
  To: buildroot

Hello Arnout,

Am 21.09.2017 um 23:09 schrieb Arnout Vandecappelle:
> 
> 
> On 20-09-17 17:31, Wolfgang Grandegger wrote:
>> Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
> 
>   Have you tested this at all?
> 
> Makefile:537: *** libusb is in the dependency chain of dfu-util that has added
> it to its _DEPENDENCIES variable without selecting it or depending on it from
> Config.in.  Stop.
> 
>   And therefore you also need to propagate the threads dependency and add a comment.

Ah, yes, a build from scratch does show that issue, sorry! Will send v2.

Wolfgang.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-09-22  6:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-20 15:31 [Buildroot] [PATCH] package/dfu-util: allow to build it for the target as well Wolfgang Grandegger
2017-09-21 21:09 ` Arnout Vandecappelle
2017-09-22  6:20   ` Wolfgang Grandegger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.