Re: [PATCH 1/4] client: special case daemon interface for non-interactive

Re: [PATCH 1/4] client: special case daemon interface for non-interactive

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

Hi James,

On 11/2/21 2:57 PM, James Prestwood wrote:
> In non-interactive mode, when a dbus method call returns the process
> exits. This is true for all methods except agent requests since e.g.
> Connect() call automatically requests credentials and the client must
> wait for that to return before exiting. The new daemon interface must
> also be treated in the same way and not exit.
> ---
>   client/dbus-proxy.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 

All applied, thanks.

Regards,
-Denis

[PATCH 1/4] client: special case daemon interface for non-interactive

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 936 bytes --]

In non-interactive mode, when a dbus method call returns the process
exits. This is true for all methods except agent requests since e.g.
Connect() call automatically requests credentials and the client must
wait for that to return before exiting. The new daemon interface must
also be treated in the same way and not exit.
---
 client/dbus-proxy.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/client/dbus-proxy.c b/client/dbus-proxy.c
index ab9fb5a5..0373a3df 100644
--- a/client/dbus-proxy.c
+++ b/client/dbus-proxy.c
@@ -315,7 +315,8 @@ static void proxy_callback(struct l_dbus_message *message, void *user_data)
 	}
 
 	proxy = callback_data->user_data;
-	if (!strcmp(proxy->type->interface, IWD_AGENT_MANAGER_INTERFACE))
+	if (!strcmp(proxy->type->interface, IWD_AGENT_MANAGER_INTERFACE) ||
+			!strcmp(proxy->type->interface, IWD_DAEMON_INTERFACE))
 		return;
 
 quit:
-- 
2.31.1