* [PATCH net-next v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
@ 2024-02-15 15:22 ` Diogo Ivo
0 siblings, 0 replies; 6+ messages in thread
From: Diogo Ivo @ 2024-02-15 15:22 UTC (permalink / raw)
To: danishanwar, rogerq, davem, edumazet, kuba, pabeni, andrew,
jan.kiszka, dan.carpenter, robh
Cc: Diogo Ivo, linux-arm-kernel, netdev
Remove the duplicate calls to prueth_emac_stop() and
prueth_cleanup_tx_chns() in emac_ndo_stop().
Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
---
Changes in v2:
- Removed Fixes: tags
- Added Reviewed-by's
drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 411898a4f38c..cf7b73f8f450 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -1489,9 +1489,6 @@ static int emac_ndo_stop(struct net_device *ndev)
/* Destroying the queued work in ndo_stop() */
cancel_delayed_work_sync(&emac->stats_work);
- /* stop PRUs */
- prueth_emac_stop(emac);
-
if (prueth->emacs_initialized == 1)
icss_iep_exit(emac->iep);
@@ -1502,7 +1499,6 @@ static int emac_ndo_stop(struct net_device *ndev)
free_irq(emac->rx_chns.irq[rx_flow], emac);
prueth_ndev_del_tx_napi(emac, emac->tx_ch_num);
- prueth_cleanup_tx_chns(emac);
prueth_cleanup_rx_chns(emac, &emac->rx_chns, max_rx_flows);
prueth_cleanup_tx_chns(emac);
--
2.43.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
@ 2024-02-15 15:22 ` Diogo Ivo
0 siblings, 0 replies; 6+ messages in thread
From: Diogo Ivo @ 2024-02-15 15:22 UTC (permalink / raw)
To: danishanwar, rogerq, davem, edumazet, kuba, pabeni, andrew,
jan.kiszka, dan.carpenter, robh
Cc: Diogo Ivo, linux-arm-kernel, netdev
Remove the duplicate calls to prueth_emac_stop() and
prueth_cleanup_tx_chns() in emac_ndo_stop().
Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
---
Changes in v2:
- Removed Fixes: tags
- Added Reviewed-by's
drivers/net/ethernet/ti/icssg/icssg_prueth.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/ti/icssg/icssg_prueth.c b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
index 411898a4f38c..cf7b73f8f450 100644
--- a/drivers/net/ethernet/ti/icssg/icssg_prueth.c
+++ b/drivers/net/ethernet/ti/icssg/icssg_prueth.c
@@ -1489,9 +1489,6 @@ static int emac_ndo_stop(struct net_device *ndev)
/* Destroying the queued work in ndo_stop() */
cancel_delayed_work_sync(&emac->stats_work);
- /* stop PRUs */
- prueth_emac_stop(emac);
-
if (prueth->emacs_initialized == 1)
icss_iep_exit(emac->iep);
@@ -1502,7 +1499,6 @@ static int emac_ndo_stop(struct net_device *ndev)
free_irq(emac->rx_chns.irq[rx_flow], emac);
prueth_ndev_del_tx_napi(emac, emac->tx_ch_num);
- prueth_cleanup_tx_chns(emac);
prueth_cleanup_rx_chns(emac, &emac->rx_chns, max_rx_flows);
prueth_cleanup_tx_chns(emac);
--
2.43.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
2024-02-15 15:22 ` Diogo Ivo
@ 2024-02-15 16:52 ` Dan Carpenter
-1 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2024-02-15 16:52 UTC (permalink / raw)
To: Diogo Ivo
Cc: danishanwar, rogerq, davem, edumazet, kuba, pabeni, andrew,
jan.kiszka, robh, linux-arm-kernel, netdev
On Thu, Feb 15, 2024 at 03:22:01PM +0000, Diogo Ivo wrote:
> Remove the duplicate calls to prueth_emac_stop() and
> prueth_cleanup_tx_chns() in emac_ndo_stop().
>
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
> ---
> Changes in v2:
> - Removed Fixes: tags
> - Added Reviewed-by's
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
@ 2024-02-15 16:52 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2024-02-15 16:52 UTC (permalink / raw)
To: Diogo Ivo
Cc: danishanwar, rogerq, davem, edumazet, kuba, pabeni, andrew,
jan.kiszka, robh, linux-arm-kernel, netdev
On Thu, Feb 15, 2024 at 03:22:01PM +0000, Diogo Ivo wrote:
> Remove the duplicate calls to prueth_emac_stop() and
> prueth_cleanup_tx_chns() in emac_ndo_stop().
>
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
> ---
> Changes in v2:
> - Removed Fixes: tags
> - Added Reviewed-by's
Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
2024-02-15 15:22 ` Diogo Ivo
@ 2024-02-16 12:00 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-16 12:00 UTC (permalink / raw)
To: Diogo Ivo
Cc: danishanwar, rogerq, davem, edumazet, kuba, pabeni, andrew,
jan.kiszka, dan.carpenter, robh, linux-arm-kernel, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 15 Feb 2024 15:22:01 +0000 you wrote:
> Remove the duplicate calls to prueth_emac_stop() and
> prueth_cleanup_tx_chns() in emac_ndo_stop().
>
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
>
> [...]
Here is the summary with links:
- [net-next,v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
https://git.kernel.org/netdev/net-next/c/1d085e9ce384
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
@ 2024-02-16 12:00 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 6+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-16 12:00 UTC (permalink / raw)
To: Diogo Ivo
Cc: danishanwar, rogerq, davem, edumazet, kuba, pabeni, andrew,
jan.kiszka, dan.carpenter, robh, linux-arm-kernel, netdev
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 15 Feb 2024 15:22:01 +0000 you wrote:
> Remove the duplicate calls to prueth_emac_stop() and
> prueth_cleanup_tx_chns() in emac_ndo_stop().
>
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
> Reviewed-by: Roger Quadros <rogerq@kernel.org>
> Reviewed-by: MD Danish Anwar <danishanwar@ti.com>
>
> [...]
Here is the summary with links:
- [net-next,v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop()
https://git.kernel.org/netdev/net-next/c/1d085e9ce384
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-02-16 12:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-15 15:22 [PATCH net-next v2] net: ti: icssg-prueth: Remove duplicate cleanup calls in emac_ndo_stop() Diogo Ivo
2024-02-15 15:22 ` Diogo Ivo
2024-02-15 16:52 ` Dan Carpenter
2024-02-15 16:52 ` Dan Carpenter
2024-02-16 12:00 ` patchwork-bot+netdevbpf
2024-02-16 12:00 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.