* [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM
@ 2018-10-16 8:38 Stefano Stabellini
2018-10-16 10:56 ` Julien Grall
2018-10-26 6:54 ` Juergen Gross
0 siblings, 2 replies; 6+ messages in thread
From: Stefano Stabellini @ 2018-10-16 8:38 UTC (permalink / raw)
To: boris.ostrovsky, jgross, vkuznets
Cc: xen-devel, sstabellini, Nathan.Studer, Jeff.Kubascik, Jarvis.Roach
xen_create_contiguous_region has now only an implementation if
CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but
we do have an implementation of xen_create_contiguous_region which is
required for swiotlb-xen to work correctly (although it just sets
*dma_handle).
This fixes a bug introduced by 16624390816c4c40df3d777b34665d3fd01e693d.
diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
index fd18c97..939a962 100644
--- a/include/xen/xen-ops.h
+++ b/include/xen/xen-ops.h
@@ -41,7 +41,7 @@ static inline uint32_t xen_vcpu_nr(int cpu)
extern unsigned long *xen_contiguous_bitmap;
-#ifdef CONFIG_XEN_PV
+#ifdef CONFIG_XEN_PV || CONFIG_ARM || CONFIG_ARM64
int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
unsigned int address_bits,
dma_addr_t *dma_handle);
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM
2018-10-16 8:38 [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM Stefano Stabellini
@ 2018-10-16 10:56 ` Julien Grall
2018-10-16 12:51 ` Boris Ostrovsky
2018-10-26 6:54 ` Juergen Gross
1 sibling, 1 reply; 6+ messages in thread
From: Julien Grall @ 2018-10-16 10:56 UTC (permalink / raw)
To: Stefano Stabellini, boris.ostrovsky, jgross, vkuznets
Cc: xen-devel, Nathan.Studer, Jeff.Kubascik, Jarvis.Roach
Hi,
On 10/16/2018 09:38 AM, Stefano Stabellini wrote:
> xen_create_contiguous_region has now only an implementation if
> CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but
> we do have an implementation of xen_create_contiguous_region which is
> required for swiotlb-xen to work correctly (although it just sets
> *dma_handle). >
> This fixes a bug introduced by 16624390816c4c40df3d777b34665d3fd01e693d.
Linux is using the tag "Fixes: sha1 ("commit title")" so it can be
picked up for backporting.
Acked-by: Julien Grall <julien.grall@arm.com>
Cheers,
>
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index fd18c97..939a962 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -41,7 +41,7 @@ static inline uint32_t xen_vcpu_nr(int cpu)
>
> extern unsigned long *xen_contiguous_bitmap;
>
> -#ifdef CONFIG_XEN_PV
> +#ifdef CONFIG_XEN_PV || CONFIG_ARM || CONFIG_ARM64
> int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> unsigned int address_bits,
> dma_addr_t *dma_handle);
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xenproject.org
> https://lists.xenproject.org/mailman/listinfo/xen-devel
>
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM
2018-10-16 10:56 ` Julien Grall
@ 2018-10-16 12:51 ` Boris Ostrovsky
2018-10-16 13:02 ` Stefano Stabellini
0 siblings, 1 reply; 6+ messages in thread
From: Boris Ostrovsky @ 2018-10-16 12:51 UTC (permalink / raw)
To: Julien Grall, Stefano Stabellini, jgross, vkuznets
Cc: xen-devel, Nathan.Studer, Jeff.Kubascik, Jarvis.Roach
On 10/16/18 6:56 AM, Julien Grall wrote:
> Hi,
>
> On 10/16/2018 09:38 AM, Stefano Stabellini wrote:
>> xen_create_contiguous_region has now only an implementation if
>> CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but
>> we do have an implementation of xen_create_contiguous_region which is
>> required for swiotlb-xen to work correctly (although it just sets
>> *dma_handle). >
>> This fixes a bug introduced by 16624390816c4c40df3d777b34665d3fd01e693d.
>
> Linux is using the tag "Fixes: sha1 ("commit title")" so it can be
> picked up for backporting.
SoB would also be good to have ;-)
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
>
> Acked-by: Julien Grall <julien.grall@arm.com>
>
> Cheers,
>>
>> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
>> index fd18c97..939a962 100644
>> --- a/include/xen/xen-ops.h
>> +++ b/include/xen/xen-ops.h
>> @@ -41,7 +41,7 @@ static inline uint32_t xen_vcpu_nr(int cpu)
>> extern unsigned long *xen_contiguous_bitmap;
>> -#ifdef CONFIG_XEN_PV
>> +#ifdef CONFIG_XEN_PV || CONFIG_ARM || CONFIG_ARM64
>> int xen_create_contiguous_region(phys_addr_t pstart, unsigned int
>> order,
>> unsigned int address_bits,
>> dma_addr_t *dma_handle);
>>
>> _______________________________________________
>> Xen-devel mailing list
>> Xen-devel@lists.xenproject.org
>> https://lists.xenproject.org/mailman/listinfo/xen-devel
>>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM
2018-10-16 12:51 ` Boris Ostrovsky
@ 2018-10-16 13:02 ` Stefano Stabellini
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Stabellini @ 2018-10-16 13:02 UTC (permalink / raw)
To: Boris Ostrovsky
Cc: jgross, Stefano Stabellini, Jeff.Kubascik, Julien Grall,
Nathan.Studer, xen-devel, vkuznets, Jarvis.Roach
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1700 bytes --]
On Tue, 16 Oct 2018, Boris Ostrovsky wrote:
> On 10/16/18 6:56 AM, Julien Grall wrote:
> > Hi,
> >
> > On 10/16/2018 09:38 AM, Stefano Stabellini wrote:
> >> xen_create_contiguous_region has now only an implementation if
> >> CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but
> >> we do have an implementation of xen_create_contiguous_region which is
> >> required for swiotlb-xen to work correctly (although it just sets
> >> *dma_handle). >
> >> This fixes a bug introduced by 16624390816c4c40df3d777b34665d3fd01e693d.
> >
> > Linux is using the tag "Fixes: sha1 ("commit title")" so it can be
> > picked up for backporting.
>
>
> SoB would also be good to have ;-)
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Ooops, here it comes:
Signed-off-by: Stefano Stabellini <stefanos@xilinx.com>
> >
> > Acked-by: Julien Grall <julien.grall@arm.com>
> >
> > Cheers,
> >>
> >> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> >> index fd18c97..939a962 100644
> >> --- a/include/xen/xen-ops.h
> >> +++ b/include/xen/xen-ops.h
> >> @@ -41,7 +41,7 @@ static inline uint32_t xen_vcpu_nr(int cpu)
> >> extern unsigned long *xen_contiguous_bitmap;
> >> -#ifdef CONFIG_XEN_PV
> >> +#ifdef CONFIG_XEN_PV || CONFIG_ARM || CONFIG_ARM64
> >> int xen_create_contiguous_region(phys_addr_t pstart, unsigned int
> >> order,
> >> unsigned int address_bits,
> >> dma_addr_t *dma_handle);
> >>
> >> _______________________________________________
> >> Xen-devel mailing list
> >> Xen-devel@lists.xenproject.org
> >> https://lists.xenproject.org/mailman/listinfo/xen-devel
> >>
> >
>
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM
2018-10-16 8:38 [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM Stefano Stabellini
2018-10-16 10:56 ` Julien Grall
@ 2018-10-26 6:54 ` Juergen Gross
2018-10-26 17:55 ` Stefano Stabellini
1 sibling, 1 reply; 6+ messages in thread
From: Juergen Gross @ 2018-10-26 6:54 UTC (permalink / raw)
To: Stefano Stabellini, boris.ostrovsky, vkuznets
Cc: xen-devel, Nathan.Studer, Jeff.Kubascik, Jarvis.Roach
On 16/10/2018 10:38, Stefano Stabellini wrote:
> xen_create_contiguous_region has now only an implementation if
> CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but
> we do have an implementation of xen_create_contiguous_region which is
> required for swiotlb-xen to work correctly (although it just sets
> *dma_handle).
>
> This fixes a bug introduced by 16624390816c4c40df3d777b34665d3fd01e693d.
>
> diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> index fd18c97..939a962 100644
> --- a/include/xen/xen-ops.h
> +++ b/include/xen/xen-ops.h
> @@ -41,7 +41,7 @@ static inline uint32_t xen_vcpu_nr(int cpu)
>
> extern unsigned long *xen_contiguous_bitmap;
>
> -#ifdef CONFIG_XEN_PV
> +#ifdef CONFIG_XEN_PV || CONFIG_ARM || CONFIG_ARM64
> int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> unsigned int address_bits,
> dma_addr_t *dma_handle);
>
>
Could you please test your patch before sending? It doesn't even compile
without warning and it is missing SoB, correct "Fixes:" tag and looks as
if it has been assembled by hand instead of using a proper tool like
"git format-patch" (no "---" delimiter, extra empty lines at the end).
Juergen
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM
2018-10-26 6:54 ` Juergen Gross
@ 2018-10-26 17:55 ` Stefano Stabellini
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Stabellini @ 2018-10-26 17:55 UTC (permalink / raw)
To: Juergen Gross
Cc: Stefano Stabellini, Jeff.Kubascik, Nathan.Studer, xen-devel,
boris.ostrovsky, vkuznets, Jarvis.Roach
On Fri, 26 Oct 2018, Juergen Gross wrote:
> On 16/10/2018 10:38, Stefano Stabellini wrote:
> > xen_create_contiguous_region has now only an implementation if
> > CONFIG_XEN_PV is defined. However, on ARM we never set CONFIG_XEN_PV but
> > we do have an implementation of xen_create_contiguous_region which is
> > required for swiotlb-xen to work correctly (although it just sets
> > *dma_handle).
> >
> > This fixes a bug introduced by 16624390816c4c40df3d777b34665d3fd01e693d.
> >
> > diff --git a/include/xen/xen-ops.h b/include/xen/xen-ops.h
> > index fd18c97..939a962 100644
> > --- a/include/xen/xen-ops.h
> > +++ b/include/xen/xen-ops.h
> > @@ -41,7 +41,7 @@ static inline uint32_t xen_vcpu_nr(int cpu)
> >
> > extern unsigned long *xen_contiguous_bitmap;
> >
> > -#ifdef CONFIG_XEN_PV
> > +#ifdef CONFIG_XEN_PV || CONFIG_ARM || CONFIG_ARM64
> > int xen_create_contiguous_region(phys_addr_t pstart, unsigned int order,
> > unsigned int address_bits,
> > dma_addr_t *dma_handle);
> >
> >
>
> Could you please test your patch before sending? It doesn't even compile
> without warning and it is missing SoB, correct "Fixes:" tag and looks as
> if it has been assembled by hand instead of using a proper tool like
> "git format-patch" (no "---" delimiter, extra empty lines at the end).
Sorry Juergen, I must have been distracted or maybe I was working on an
older version. Anyway, I'll send a new patch, rebased on master.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-26 17:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-16 8:38 [PATCH] CONFIG_XEN_PV breaks xen_create_contiguous_region on ARM Stefano Stabellini
2018-10-16 10:56 ` Julien Grall
2018-10-16 12:51 ` Boris Ostrovsky
2018-10-16 13:02 ` Stefano Stabellini
2018-10-26 6:54 ` Juergen Gross
2018-10-26 17:55 ` Stefano Stabellini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.