All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, qemu-s390x@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary
Date: Sat, 27 Mar 2021 15:54:29 +0100	[thread overview]
Message-ID: <f9c5e949-1790-31ae-54c7-ccfdc3c16ae9@amsat.org> (raw)
In-Reply-To: <20210327082804.2259480-1-thuth@redhat.com>

Hi Thomas,

On 3/27/21 9:28 AM, Thomas Huth wrote:
> Many files include hw/sysbus.h without needing it. Remove the superfluous
> include statements.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  hw/arm/cubieboard.c         | 1 -
>  hw/arm/orangepi.c           | 1 -
>  hw/char/riscv_htif.c        | 1 -
>  hw/char/sifive_uart.c       | 1 -
>  hw/char/virtio-serial-bus.c | 1 -
>  hw/core/generic-loader.c    | 1 -
>  hw/core/guest-loader.c      | 1 -
>  hw/ide/ahci_internal.h      | 1 -
>  hw/input/lasips2.c          | 1 -
>  hw/intc/arm_gic_kvm.c       | 1 -
>  hw/intc/arm_gicv3.c         | 1 -
>  hw/intc/arm_gicv3_kvm.c     | 1 -
>  hw/intc/s390_flic_kvm.c     | 1 -
>  hw/isa/lpc_ich9.c           | 1 -
>  hw/isa/piix4.c              | 1 -
>  hw/moxie/moxiesim.c         | 1 -
>  hw/nios2/generic_nommu.c    | 1 -
>  hw/nubus/nubus-bus.c        | 1 -
>  hw/nvram/spapr_nvram.c      | 1 -
>  hw/rx/rx-gdbsim.c           | 1 -
>  hw/s390x/s390-ccw.c         | 1 -
>  hw/s390x/virtio-ccw.c       | 1 -
>  hw/timer/mips_gictimer.c    | 1 -
>  hw/usb/xen-usb.c            | 1 -
>  hw/vfio/ap.c                | 1 -
>  hw/vfio/ccw.c               | 1 -
>  hw/xen/xen-bus-helper.c     | 1 -
>  27 files changed, 27 deletions(-)

$ git grep -l '#include "hw/sysbus.h"' hw \
  | xargs git grep -L sysbus_ \
  | xargs git grep -L 'SysBusDevice\s\+\w'

hw/arm/cubieboard.c
hw/arm/orangepi.c
hw/char/riscv_htif.c
hw/char/sifive_uart.c
hw/char/virtio-serial-bus.c
hw/core/generic-loader.c
hw/core/guest-loader.c
hw/hyperv/vmbus.c
hw/i386/x86-iommu.c
hw/ide/ahci_internal.h
hw/input/lasips2.c
hw/intc/arm_gic_kvm.c
hw/intc/arm_gicv3.c
hw/intc/arm_gicv3_kvm.c
hw/intc/s390_flic_kvm.c
hw/isa/lpc_ich9.c
hw/isa/piix4.c
hw/moxie/moxiesim.c
hw/nios2/generic_nommu.c
hw/nubus/nubus-bridge.c
hw/nubus/nubus-bus.c
hw/nvram/spapr_nvram.c
hw/ppc/spapr_pci.c
hw/riscv/riscv_hart.c
hw/rx/rx-gdbsim.c
hw/s390x/s390-ccw.c
hw/s390x/virtio-ccw.c
hw/timer/mips_gictimer.c
hw/tricore/tc27x_soc.c
hw/usb/xen-usb.c
hw/vfio/ap.c
hw/vfio/ccw.c
hw/xen/xen-bus-helper.c

diff with your set:

@@ -5,6 +5,8 @@
 hw/char/virtio-serial-bus.c
 hw/core/generic-loader.c
 hw/core/guest-loader.c
+hw/hyperv/vmbus.c
+hw/i386/x86-iommu.c
 hw/ide/ahci_internal.h
 hw/input/lasips2.c
 hw/intc/arm_gic_kvm.c
@@ -15,12 +17,16 @@
 hw/isa/piix4.c
 hw/moxie/moxiesim.c
 hw/nios2/generic_nommu.c
+hw/nubus/nubus-bridge.c
 hw/nubus/nubus-bus.c
 hw/nvram/spapr_nvram.c
+hw/ppc/spapr_pci.c
+hw/riscv/riscv_hart.c
 hw/rx/rx-gdbsim.c
 hw/s390x/s390-ccw.c
 hw/s390x/virtio-ccw.c
 hw/timer/mips_gictimer.c
+hw/tricore/tc27x_soc.c
 hw/usb/xen-usb.c
 hw/vfio/ap.c
 hw/vfio/ccw.c

6 more candidates?


  reply	other threads:[~2021-03-27 14:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27  8:28 [PATCH] hw: Do not include hw/sysbus.h if it is not necessary Thomas Huth
2021-03-27 14:54 ` Philippe Mathieu-Daudé [this message]
2021-03-27 18:19   ` Thomas Huth
2021-03-27 18:35     ` Philippe Mathieu-Daudé
2021-03-27 18:37       ` Philippe Mathieu-Daudé
2021-04-30 16:27 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9c5e949-1790-31ae-54c7-ccfdc3c16ae9@amsat.org \
    --to=f4bug@amsat.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.