All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, qemu-s390x@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [PATCH] hw: Do not include hw/sysbus.h if it is not necessary
Date: Sat, 27 Mar 2021 19:37:05 +0100	[thread overview]
Message-ID: <b6e70ae9-cfbf-62e9-86f0-5cd98384d976@amsat.org> (raw)
In-Reply-To: <39afc328-73bc-2168-52a7-44914a87a799@amsat.org>

On 3/27/21 7:35 PM, Philippe Mathieu-Daudé wrote:
> On 3/27/21 7:19 PM, Thomas Huth wrote:
>> On 27/03/2021 15.54, Philippe Mathieu-Daudé wrote:
>>> Hi Thomas,
>>>

>>> 6 more candidates?
>>
>> No, since those use TYPE_SYS_BUS_DEVICE and thus require hw/sysbus.h.
> 
> Ah indeed, this line matches your patch changes:
> 
> $ git grep -l '#include "hw/sysbus.h"' hw \
>    | xargs git grep -L sysbus_ \
>    | xargs git grep -L 'SysBusDevice\s\+\w' \
>    | xargs grep -L SYS_BUS_DEVICE

I missed the 'git' while copy/pasting, I meant:

     | xargs git grep -L SYS_BUS_DEVICE

> 
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> 


  reply	other threads:[~2021-03-27 18:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-27  8:28 [PATCH] hw: Do not include hw/sysbus.h if it is not necessary Thomas Huth
2021-03-27 14:54 ` Philippe Mathieu-Daudé
2021-03-27 18:19   ` Thomas Huth
2021-03-27 18:35     ` Philippe Mathieu-Daudé
2021-03-27 18:37       ` Philippe Mathieu-Daudé [this message]
2021-04-30 16:27 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b6e70ae9-cfbf-62e9-86f0-5cd98384d976@amsat.org \
    --to=f4bug@amsat.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.