From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Vinod Polimera <quic_vpolimer@quicinc.com>, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, robdclark@gmail.com, dianders@chromium.org, swboyd@chromium.org, quic_kalyant@quicinc.com, quic_abhinavk@quicinc.com Subject: Re: [PATCH v2] drm/msm/disp/dpu1: avoid clearing hw interrupts if hw_intr is null during drm uninit Date: Mon, 2 May 2022 20:12:04 +0300 [thread overview] Message-ID: <f9dbdfc1-117c-b713-7f1d-40de9726baa1@linaro.org> (raw) In-Reply-To: <1651509846-4842-1-git-send-email-quic_vpolimer@quicinc.com> On 02/05/2022 19:44, Vinod Polimera wrote: > If edp modeset init is failed due to panel being not ready and > probe defers during drm bind, avoid clearing irqs and derefernce > hw_intr when hw_intr is null. > > BUG: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 > > Call trace: > dpu_core_irq_uninstall+0x50/0xb0 > dpu_irq_uninstall+0x18/0x24 > msm_drm_uninit+0xd8/0x16c > msm_drm_bind+0x580/0x5fc > try_to_bring_up_master+0x168/0x1c0 > __component_add+0xb4/0x178 > component_add+0x1c/0x28 > dp_display_probe+0x38c/0x400 > platform_probe+0xb0/0xd0 > really_probe+0xcc/0x2c8 > __driver_probe_device+0xbc/0xe8 > driver_probe_device+0x48/0xf0 > __device_attach_driver+0xa0/0xc8 > bus_for_each_drv+0x8c/0xd8 > __device_attach+0xc4/0x150 > device_initial_probe+0x1c/0x28 > > Changes in V2: > - Update commit message and coreect fixes tag. > > Fixes: f25f656608e3 ("drm/msm/dpu: merge struct dpu_irq into struct dpu_hw_intr") > Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > index c515b7c..ab28577 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > @@ -599,6 +599,9 @@ void dpu_core_irq_uninstall(struct dpu_kms *dpu_kms) > { > int i; > > + if (!dpu_kms->hw_intr) > + return; > + > pm_runtime_get_sync(&dpu_kms->pdev->dev); > for (i = 0; i < dpu_kms->hw_intr->total_irqs; i++) > if (!list_empty(&dpu_kms->hw_intr->irq_cb_tbl[i])) -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Vinod Polimera <quic_vpolimer@quicinc.com>, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org Cc: quic_kalyant@quicinc.com, dianders@chromium.org, quic_abhinavk@quicinc.com, linux-kernel@vger.kernel.org, swboyd@chromium.org Subject: Re: [PATCH v2] drm/msm/disp/dpu1: avoid clearing hw interrupts if hw_intr is null during drm uninit Date: Mon, 2 May 2022 20:12:04 +0300 [thread overview] Message-ID: <f9dbdfc1-117c-b713-7f1d-40de9726baa1@linaro.org> (raw) In-Reply-To: <1651509846-4842-1-git-send-email-quic_vpolimer@quicinc.com> On 02/05/2022 19:44, Vinod Polimera wrote: > If edp modeset init is failed due to panel being not ready and > probe defers during drm bind, avoid clearing irqs and derefernce > hw_intr when hw_intr is null. > > BUG: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 > > Call trace: > dpu_core_irq_uninstall+0x50/0xb0 > dpu_irq_uninstall+0x18/0x24 > msm_drm_uninit+0xd8/0x16c > msm_drm_bind+0x580/0x5fc > try_to_bring_up_master+0x168/0x1c0 > __component_add+0xb4/0x178 > component_add+0x1c/0x28 > dp_display_probe+0x38c/0x400 > platform_probe+0xb0/0xd0 > really_probe+0xcc/0x2c8 > __driver_probe_device+0xbc/0xe8 > driver_probe_device+0x48/0xf0 > __device_attach_driver+0xa0/0xc8 > bus_for_each_drv+0x8c/0xd8 > __device_attach+0xc4/0x150 > device_initial_probe+0x1c/0x28 > > Changes in V2: > - Update commit message and coreect fixes tag. > > Fixes: f25f656608e3 ("drm/msm/dpu: merge struct dpu_irq into struct dpu_hw_intr") > Signed-off-by: Vinod Polimera <quic_vpolimer@quicinc.com> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > index c515b7c..ab28577 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c > @@ -599,6 +599,9 @@ void dpu_core_irq_uninstall(struct dpu_kms *dpu_kms) > { > int i; > > + if (!dpu_kms->hw_intr) > + return; > + > pm_runtime_get_sync(&dpu_kms->pdev->dev); > for (i = 0; i < dpu_kms->hw_intr->total_irqs; i++) > if (!list_empty(&dpu_kms->hw_intr->irq_cb_tbl[i])) -- With best wishes Dmitry
next prev parent reply other threads:[~2022-05-02 17:12 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-02 16:44 [PATCH v2] drm/msm/disp/dpu1: avoid clearing hw interrupts if hw_intr is null during drm uninit Vinod Polimera 2022-05-02 16:44 ` Vinod Polimera 2022-05-02 17:12 ` Dmitry Baryshkov [this message] 2022-05-02 17:12 ` Dmitry Baryshkov 2022-05-02 20:42 ` Stephen Boyd 2022-05-02 20:42 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f9dbdfc1-117c-b713-7f1d-40de9726baa1@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=devicetree@vger.kernel.org \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_kalyant@quicinc.com \ --cc=quic_vpolimer@quicinc.com \ --cc=robdclark@gmail.com \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.