From: Matheus Castello <matheus@castello.eng.br> To: "Andreas Färber" <afaerber@suse.de> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, mark.rutland@arm.com, robh+dt@kernel.org, edgar.righi@lsitec.org.br, igor.lima@lsitec.org.br, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-actions@lists.infradead.org Subject: Re: [PATCH v3 3/3] ARM: dts: Add Caninos Loucos Labrador Date: Sun, 26 Apr 2020 13:27:27 -0300 [thread overview] Message-ID: <f9e48fba-0da8-7ba9-d44a-7909067a1df1@castello.eng.br> (raw) In-Reply-To: <2dca5a4e-933c-0a43-e86f-21b55d75a586@suse.de> Hi Andreas, thanks for the review. Em 4/26/20 8:58 AM, Andreas Färber escreveu: > Hi Matheus, > > Am 23.04.20 um 17:20 schrieb Matheus Castello: >> Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu: >>> On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote: >>>> Add Device Trees for Caninos Loucos Labrador CoM and base board. >>>> Based on the work of Andreas Färber on Lemaker Guitar device tree. >>>> >>>> Signed-off-by: Matheus Castello <matheus@castello.eng.br> >>> >>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >>> >>> Will queue the series for v5.8 once Andreas is happy with it. >> >> do you have any more concerns about these patches? Let me know. > > I've reviewed the preceding two patches. This one here looks okay, > > Reviewed-by: Andreas Färber <afaerber@suse.de> > > but see 2/3 - model here does contain M and your .dtsi is named -v2 - > what's the difference to v1? If it's big enough to warrant a separate > .dtsi, you should consider whether a versioned compatible string may be > needed, too (likely in addition to, not instead of a generic one). No v1 > info on the website. > The difference between v1 and v2 is the model and vendor of the DRAM and storage eMMC. But that had no impact on the software. Checking examples on "/Documentation/devicetree/bindings/arm/" I saw that some add enum descriptions for both the base board and system on module, keeping in const only the vendor prefix of the SoC. And in the device tree both have the model property description. I liked this example, I think I will follow it in v4. About "-bb-" in the file name and description: on PCB is written "Labrador Base-M v1.0a", so with that I think it is better to leave only base on the name. I will send the v4, thank you very much for the review. BR, Matheus Castello > Thanks, > Andreas >
WARNING: multiple messages have this Message-ID (diff)
From: Matheus Castello <matheus@castello.eng.br> To: "Andreas Färber" <afaerber@suse.de> Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>, igor.lima@lsitec.org.br, edgar.righi@lsitec.org.br, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 3/3] ARM: dts: Add Caninos Loucos Labrador Date: Sun, 26 Apr 2020 13:27:27 -0300 [thread overview] Message-ID: <f9e48fba-0da8-7ba9-d44a-7909067a1df1@castello.eng.br> (raw) In-Reply-To: <2dca5a4e-933c-0a43-e86f-21b55d75a586@suse.de> Hi Andreas, thanks for the review. Em 4/26/20 8:58 AM, Andreas Färber escreveu: > Hi Matheus, > > Am 23.04.20 um 17:20 schrieb Matheus Castello: >> Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu: >>> On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote: >>>> Add Device Trees for Caninos Loucos Labrador CoM and base board. >>>> Based on the work of Andreas Färber on Lemaker Guitar device tree. >>>> >>>> Signed-off-by: Matheus Castello <matheus@castello.eng.br> >>> >>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >>> >>> Will queue the series for v5.8 once Andreas is happy with it. >> >> do you have any more concerns about these patches? Let me know. > > I've reviewed the preceding two patches. This one here looks okay, > > Reviewed-by: Andreas Färber <afaerber@suse.de> > > but see 2/3 - model here does contain M and your .dtsi is named -v2 - > what's the difference to v1? If it's big enough to warrant a separate > .dtsi, you should consider whether a versioned compatible string may be > needed, too (likely in addition to, not instead of a generic one). No v1 > info on the website. > The difference between v1 and v2 is the model and vendor of the DRAM and storage eMMC. But that had no impact on the software. Checking examples on "/Documentation/devicetree/bindings/arm/" I saw that some add enum descriptions for both the base board and system on module, keeping in const only the vendor prefix of the SoC. And in the device tree both have the model property description. I liked this example, I think I will follow it in v4. About "-bb-" in the file name and description: on PCB is written "Labrador Base-M v1.0a", so with that I think it is better to leave only base on the name. I will send the v4, thank you very much for the review. BR, Matheus Castello > Thanks, > Andreas > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-26 16:52 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-27 20:15 [PATCH v1 0/2] Add Caninos Loucos Labrador SoM and Base Board Device Tree Matheus Castello 2020-02-27 20:15 ` Matheus Castello 2020-02-27 20:15 ` [PATCH v1 1/2] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello 2020-02-27 20:15 ` Matheus Castello 2020-02-29 10:43 ` Manivannan Sadhasivam 2020-02-29 10:43 ` Manivannan Sadhasivam 2020-03-07 0:24 ` [PATCH v2 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree Matheus Castello 2020-03-07 0:24 ` Matheus Castello 2020-03-07 0:24 ` [PATCH v2 1/3] dt-bindings: Add vendor prefix for Caninos Loucos Matheus Castello 2020-03-07 0:24 ` Matheus Castello 2020-03-07 12:34 ` Andreas Färber 2020-03-07 12:34 ` Andreas Färber 2020-03-11 4:04 ` Matheus Castello 2020-03-11 4:04 ` Matheus Castello 2020-03-07 0:24 ` [PATCH v2 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello 2020-03-07 0:24 ` Matheus Castello 2020-03-07 0:24 ` [PATCH v2 3/3] ARM: dts: Add " Matheus Castello 2020-03-07 0:24 ` Matheus Castello 2020-03-20 3:51 ` [PATCH v3 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree Matheus Castello 2020-03-20 3:51 ` Matheus Castello 2020-03-20 3:51 ` [PATCH v3 1/3] dt-bindings: Add vendor prefix for Caninos Loucos Matheus Castello 2020-03-20 3:51 ` Matheus Castello 2020-03-30 23:23 ` Rob Herring 2020-03-30 23:23 ` Rob Herring 2020-04-26 10:53 ` Andreas Färber 2020-04-26 10:53 ` Andreas Färber 2020-03-20 3:51 ` [PATCH v3 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello 2020-03-20 3:51 ` Matheus Castello 2020-03-30 23:23 ` Rob Herring 2020-03-30 23:23 ` Rob Herring 2020-04-26 11:50 ` Andreas Färber 2020-04-26 11:50 ` Andreas Färber 2020-03-20 3:51 ` [PATCH v3 3/3] ARM: dts: Add " Matheus Castello 2020-03-20 3:51 ` Matheus Castello 2020-04-05 6:51 ` Manivannan Sadhasivam 2020-04-05 6:51 ` Manivannan Sadhasivam 2020-04-23 15:20 ` Matheus Castello 2020-04-23 15:20 ` Matheus Castello 2020-04-26 11:58 ` Andreas Färber 2020-04-26 11:58 ` Andreas Färber 2020-04-26 16:27 ` Matheus Castello [this message] 2020-04-26 16:27 ` Matheus Castello 2020-04-26 16:58 ` [PATCH v4 0/3] Add Caninos Loucos Labrador CoM and Base Board Device Tree Matheus Castello 2020-04-26 16:58 ` Matheus Castello 2020-04-26 16:58 ` [PATCH v4 1/3] dt-bindings: Add vendor prefix for Caninos Loucos Matheus Castello 2020-04-26 16:58 ` Matheus Castello 2020-04-26 16:58 ` [PATCH v4 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador Matheus Castello 2020-04-26 16:58 ` Matheus Castello 2020-04-27 21:32 ` Rob Herring 2020-04-27 21:32 ` Rob Herring 2020-04-26 16:58 ` [PATCH v4 3/3] ARM: dts: Add " Matheus Castello 2020-04-26 16:58 ` Matheus Castello 2020-02-27 20:15 ` [PATCH v1 2/2] " Matheus Castello 2020-02-27 20:15 ` Matheus Castello 2020-02-29 10:42 ` Manivannan Sadhasivam 2020-02-29 10:42 ` Manivannan Sadhasivam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f9e48fba-0da8-7ba9-d44a-7909067a1df1@castello.eng.br \ --to=matheus@castello.eng.br \ --cc=afaerber@suse.de \ --cc=devicetree@vger.kernel.org \ --cc=edgar.righi@lsitec.org.br \ --cc=igor.lima@lsitec.org.br \ --cc=linux-actions@lists.infradead.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=manivannan.sadhasivam@linaro.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.