* Missing XSM permission for livepatch sysctl
@ 2017-02-06 12:51 Wei Liu
2017-02-06 12:53 ` Wei Liu
0 siblings, 1 reply; 5+ messages in thread
From: Wei Liu @ 2017-02-06 12:51 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Daniel De Graaf; +Cc: Xen-devel, Wei Liu
When running XTF with a XSM-enabled Xen (generated by one of my osstest
flight for testing something else).
Executing 'xl create -F
tests/livepatch-priv-check/test-hvm32-livepatch-priv-check.cfg'
--- Xen Test Framework ---
Environment: HVM 32bit (No paging)
Live Patch Privilege Check
Fail: test_upload: Unexpected return code -13
Fail: test_list: Unexpected return code -13
Fail: test_get: Unexpected return code -13
Fail: test_action: Unexpected return code -13
Fail: test_action: Unexpected return code -13
Fail: test_action: Unexpected return code -13
Fail: test_action: Unexpected return code -13
Test result: FAILURE
-13 is EACCESS.
Should be easy to fix.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Missing XSM permission for livepatch sysctl
2017-02-06 12:51 Missing XSM permission for livepatch sysctl Wei Liu
@ 2017-02-06 12:53 ` Wei Liu
2017-02-06 14:50 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 5+ messages in thread
From: Wei Liu @ 2017-02-06 12:53 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk, Daniel De Graaf; +Cc: Xen-devel, Wei Liu
On Mon, Feb 06, 2017 at 12:51:45PM +0000, Wei Liu wrote:
> When running XTF with a XSM-enabled Xen (generated by one of my osstest
> flight for testing something else).
>
> Executing 'xl create -F
> tests/livepatch-priv-check/test-hvm32-livepatch-priv-check.cfg'
> --- Xen Test Framework ---
> Environment: HVM 32bit (No paging)
> Live Patch Privilege Check
> Fail: test_upload: Unexpected return code -13
> Fail: test_list: Unexpected return code -13
> Fail: test_get: Unexpected return code -13
> Fail: test_action: Unexpected return code -13
> Fail: test_action: Unexpected return code -13
> Fail: test_action: Unexpected return code -13
> Fail: test_action: Unexpected return code -13
> Test result: FAILURE
>
> -13 is EACCESS.
>
> Should be easy to fix.
But but but there is already livepatch_op in dom0.te, so I'm baffled.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Missing XSM permission for livepatch sysctl
2017-02-06 12:53 ` Wei Liu
@ 2017-02-06 14:50 ` Konrad Rzeszutek Wilk
2017-02-06 14:53 ` Wei Liu
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Rzeszutek Wilk @ 2017-02-06 14:50 UTC (permalink / raw)
To: Wei Liu; +Cc: Xen-devel, Daniel De Graaf
On Mon, Feb 06, 2017 at 12:53:56PM +0000, Wei Liu wrote:
> On Mon, Feb 06, 2017 at 12:51:45PM +0000, Wei Liu wrote:
> > When running XTF with a XSM-enabled Xen (generated by one of my osstest
> > flight for testing something else).
> >
> > Executing 'xl create -F
> > tests/livepatch-priv-check/test-hvm32-livepatch-priv-check.cfg'
> > --- Xen Test Framework ---
> > Environment: HVM 32bit (No paging)
> > Live Patch Privilege Check
> > Fail: test_upload: Unexpected return code -13
> > Fail: test_list: Unexpected return code -13
> > Fail: test_get: Unexpected return code -13
> > Fail: test_action: Unexpected return code -13
> > Fail: test_action: Unexpected return code -13
> > Fail: test_action: Unexpected return code -13
> > Fail: test_action: Unexpected return code -13
> > Test result: FAILURE
> >
> > -13 is EACCESS.
> >
> > Should be easy to fix.
>
> But but but there is already livepatch_op in dom0.te, so I'm baffled.
43 if ( op->interface_version != XEN_SYSCTL_INTERFACE_VERSION )
44 return -EACCES;
in do_sysctl
>
> Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Missing XSM permission for livepatch sysctl
2017-02-06 14:50 ` Konrad Rzeszutek Wilk
@ 2017-02-06 14:53 ` Wei Liu
2017-02-06 15:05 ` Andrew Cooper
0 siblings, 1 reply; 5+ messages in thread
From: Wei Liu @ 2017-02-06 14:53 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: Xen-devel, Daniel De Graaf, Wei Liu
On Mon, Feb 06, 2017 at 09:50:32AM -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Feb 06, 2017 at 12:53:56PM +0000, Wei Liu wrote:
> > On Mon, Feb 06, 2017 at 12:51:45PM +0000, Wei Liu wrote:
> > > When running XTF with a XSM-enabled Xen (generated by one of my osstest
> > > flight for testing something else).
> > >
> > > Executing 'xl create -F
> > > tests/livepatch-priv-check/test-hvm32-livepatch-priv-check.cfg'
> > > --- Xen Test Framework ---
> > > Environment: HVM 32bit (No paging)
> > > Live Patch Privilege Check
> > > Fail: test_upload: Unexpected return code -13
> > > Fail: test_list: Unexpected return code -13
> > > Fail: test_get: Unexpected return code -13
> > > Fail: test_action: Unexpected return code -13
> > > Fail: test_action: Unexpected return code -13
> > > Fail: test_action: Unexpected return code -13
> > > Fail: test_action: Unexpected return code -13
> > > Test result: FAILURE
> > >
> > > -13 is EACCESS.
> > >
> > > Should be easy to fix.
> >
> > But but but there is already livepatch_op in dom0.te, so I'm baffled.
>
> 43 if ( op->interface_version != XEN_SYSCTL_INTERFACE_VERSION )
> 44 return -EACCES;
>
> in do_sysctl
>
They are supposed to be the same version. I didn't modify Xen source
code at all and the test box was freshly installed. The non-XSM build
passed.
Wei.
>
> >
> > Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Missing XSM permission for livepatch sysctl
2017-02-06 14:53 ` Wei Liu
@ 2017-02-06 15:05 ` Andrew Cooper
0 siblings, 0 replies; 5+ messages in thread
From: Andrew Cooper @ 2017-02-06 15:05 UTC (permalink / raw)
To: Wei Liu, Konrad Rzeszutek Wilk; +Cc: Xen-devel, Daniel De Graaf
On 06/02/17 14:53, Wei Liu wrote:
> On Mon, Feb 06, 2017 at 09:50:32AM -0500, Konrad Rzeszutek Wilk wrote:
>> On Mon, Feb 06, 2017 at 12:53:56PM +0000, Wei Liu wrote:
>>> On Mon, Feb 06, 2017 at 12:51:45PM +0000, Wei Liu wrote:
>>>> When running XTF with a XSM-enabled Xen (generated by one of my osstest
>>>> flight for testing something else).
>>>>
>>>> Executing 'xl create -F
>>>> tests/livepatch-priv-check/test-hvm32-livepatch-priv-check.cfg'
>>>> --- Xen Test Framework ---
>>>> Environment: HVM 32bit (No paging)
>>>> Live Patch Privilege Check
>>>> Fail: test_upload: Unexpected return code -13
>>>> Fail: test_list: Unexpected return code -13
>>>> Fail: test_get: Unexpected return code -13
>>>> Fail: test_action: Unexpected return code -13
>>>> Fail: test_action: Unexpected return code -13
>>>> Fail: test_action: Unexpected return code -13
>>>> Fail: test_action: Unexpected return code -13
>>>> Test result: FAILURE
>>>>
>>>> -13 is EACCESS.
>>>>
>>>> Should be easy to fix.
>>> But but but there is already livepatch_op in dom0.te, so I'm baffled.
>> 43 if ( op->interface_version != XEN_SYSCTL_INTERFACE_VERSION )
>> 44 return -EACCES;
>>
>> in do_sysctl
>>
> They are supposed to be the same version. I didn't modify Xen source
> code at all and the test box was freshly installed. The non-XSM build
> passed.
XTF already probes for the SYSCTL_INTERFACE_VERSION in use by the
hypervisor, and that check succeeds by virtue of the test not exiting early.
(P.S. This test is a very good reason why we shouldn't have unstable
ABIs. It makes testing basically impossible to do correctly.)
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-02-06 15:06 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-06 12:51 Missing XSM permission for livepatch sysctl Wei Liu
2017-02-06 12:53 ` Wei Liu
2017-02-06 14:50 ` Konrad Rzeszutek Wilk
2017-02-06 14:53 ` Wei Liu
2017-02-06 15:05 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.