From: Oleksandr Andrushchenko <andr2000@gmail.com> To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, "Oleksandr_Andrushchenko@epam.com" <Oleksandr_Andrushchenko@epam.com>, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, jgross@suse.com, konrad.wilk@oracle.com Cc: daniel.vetter@intel.com, dongwon.kim@intel.com, matthew.d.roper@intel.com Subject: Re: [PATCH 0/8] xen: dma-buf support for grant device Date: Fri, 1 Jun 2018 08:42:23 +0300 [thread overview] Message-ID: <fa050c85-f236-2f70-414b-80c095d825cb@gmail.com> (raw) In-Reply-To: <00c0eabc-3a5e-5335-5a7e-2cebce5387c9@oracle.com> On 05/31/2018 11:25 PM, Boris Ostrovsky wrote: > On 05/31/2018 10:41 AM, Oleksandr Andrushchenko wrote: >> On 05/31/2018 08:51 AM, Oleksandr Andrushchenko wrote: >>> On 05/31/2018 04:46 AM, Boris Ostrovsky wrote: >>>> >>>> On 05/25/2018 11:33 AM, Oleksandr Andrushchenko wrote: >>>> >>>>> Oleksandr Andrushchenko (8): >>>>> xen/grant-table: Make set/clear page private code shared >>>>> xen/balloon: Move common memory reservation routines to a module >>>>> xen/grant-table: Allow allocating buffers suitable for DMA >>>>> xen/gntdev: Allow mappings for DMA buffers >>>>> xen/gntdev: Add initial support for dma-buf UAPI >>>>> xen/gntdev: Implement dma-buf export functionality >>>>> xen/gntdev: Implement dma-buf import functionality >>>>> xen/gntdev: Expose gntdev's dma-buf API for in-kernel use >>>>> >>>>> drivers/xen/Kconfig | 23 + >>>>> drivers/xen/Makefile | 1 + >>>>> drivers/xen/balloon.c | 71 +-- >>>>> drivers/xen/gntdev.c | 1025 >>>>> ++++++++++++++++++++++++++++++++- >>>> >>>> I think this calls for gntdev_dma.c. >>> I assume you mean as a separate file (part of gntdev driver)? >>>> I only had a quick look over gntdev changes but they very much are >>>> concentrated in dma-specific routines. >>>> >>> I tried to do that, but there are some dependencies between the >>> gntdev.c and gntdev_dma.c, >>> so finally I decided to put it all together. >>>> You essentially only share file_operations entry points with >>>> original gntdev code, right? >>>> >>> fops + mappings done by gntdev (struct grant_map) and I need to >>> release map on dma_buf .release >>> callback which makes some cross-dependencies between modules which >>> seemed to be not cute >>> (gntdev keeps its all structs and functions inside, so I cannot >>> easily access those w/o >>> helpers). >>> >>> But I'll try one more time and move all DMA specific stuff into >>> gntdev_dma.c >> Could you please take a quick look at the way I re-structured the >> sources here [1]? >> If this is what you meant. > > I looked at final gntdev.c code and I think at least one of the chunks > there ("DMA buffer export support. ") can also be moved out. It still > have a bit too many ifdefs but it looks better to my eye than jamming > everything into a single file (and I think more code can be moved out, > but we can talk about it when you post the patches so that we can see > context). Sure, will send v2 after I re-check all the patches and run some smoke tests again > > BTW, I believe it won't build with !CONFIG_XEN_GNTDEV_DMABUF --- > gntdev_remove_map() is defined under this option and is referenced later > without it. Will check, thank you > > -boris > > >> Thank you, >> Oleksandr >>>> -boris >>>> >>> Thank you, >>> Oleksandr >>>>> drivers/xen/grant-table.c | 176 +++++- >>>>> drivers/xen/mem-reservation.c | 134 +++++ >>>>> include/uapi/xen/gntdev.h | 106 ++++ >>>>> include/xen/grant_dev.h | 37 ++ >>>>> include/xen/grant_table.h | 28 + >>>>> include/xen/mem_reservation.h | 29 + >>>>> 10 files changed, 1527 insertions(+), 103 deletions(-) >>>>> create mode 100644 drivers/xen/mem-reservation.c >>>>> create mode 100644 include/xen/grant_dev.h >>>>> create mode 100644 include/xen/mem_reservation.h >>>>> >> [1] >> https://github.com/andr2000/linux/commits/xen_tip_linux_next_xen_dma_buf_v2
WARNING: multiple messages have this Message-ID (diff)
From: Oleksandr Andrushchenko <andr2000@gmail.com> To: Boris Ostrovsky <boris.ostrovsky@oracle.com>, "Oleksandr_Andrushchenko@epam.com" <Oleksandr_Andrushchenko@epam.com>, xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, jgross@suse.com, konrad.wilk@oracle.com Cc: daniel.vetter@intel.com, dongwon.kim@intel.com Subject: Re: [PATCH 0/8] xen: dma-buf support for grant device Date: Fri, 1 Jun 2018 08:42:23 +0300 [thread overview] Message-ID: <fa050c85-f236-2f70-414b-80c095d825cb@gmail.com> (raw) In-Reply-To: <00c0eabc-3a5e-5335-5a7e-2cebce5387c9@oracle.com> On 05/31/2018 11:25 PM, Boris Ostrovsky wrote: > On 05/31/2018 10:41 AM, Oleksandr Andrushchenko wrote: >> On 05/31/2018 08:51 AM, Oleksandr Andrushchenko wrote: >>> On 05/31/2018 04:46 AM, Boris Ostrovsky wrote: >>>> >>>> On 05/25/2018 11:33 AM, Oleksandr Andrushchenko wrote: >>>> >>>>> Oleksandr Andrushchenko (8): >>>>> xen/grant-table: Make set/clear page private code shared >>>>> xen/balloon: Move common memory reservation routines to a module >>>>> xen/grant-table: Allow allocating buffers suitable for DMA >>>>> xen/gntdev: Allow mappings for DMA buffers >>>>> xen/gntdev: Add initial support for dma-buf UAPI >>>>> xen/gntdev: Implement dma-buf export functionality >>>>> xen/gntdev: Implement dma-buf import functionality >>>>> xen/gntdev: Expose gntdev's dma-buf API for in-kernel use >>>>> >>>>> drivers/xen/Kconfig | 23 + >>>>> drivers/xen/Makefile | 1 + >>>>> drivers/xen/balloon.c | 71 +-- >>>>> drivers/xen/gntdev.c | 1025 >>>>> ++++++++++++++++++++++++++++++++- >>>> >>>> I think this calls for gntdev_dma.c. >>> I assume you mean as a separate file (part of gntdev driver)? >>>> I only had a quick look over gntdev changes but they very much are >>>> concentrated in dma-specific routines. >>>> >>> I tried to do that, but there are some dependencies between the >>> gntdev.c and gntdev_dma.c, >>> so finally I decided to put it all together. >>>> You essentially only share file_operations entry points with >>>> original gntdev code, right? >>>> >>> fops + mappings done by gntdev (struct grant_map) and I need to >>> release map on dma_buf .release >>> callback which makes some cross-dependencies between modules which >>> seemed to be not cute >>> (gntdev keeps its all structs and functions inside, so I cannot >>> easily access those w/o >>> helpers). >>> >>> But I'll try one more time and move all DMA specific stuff into >>> gntdev_dma.c >> Could you please take a quick look at the way I re-structured the >> sources here [1]? >> If this is what you meant. > > I looked at final gntdev.c code and I think at least one of the chunks > there ("DMA buffer export support. ") can also be moved out. It still > have a bit too many ifdefs but it looks better to my eye than jamming > everything into a single file (and I think more code can be moved out, > but we can talk about it when you post the patches so that we can see > context). Sure, will send v2 after I re-check all the patches and run some smoke tests again > > BTW, I believe it won't build with !CONFIG_XEN_GNTDEV_DMABUF --- > gntdev_remove_map() is defined under this option and is referenced later > without it. Will check, thank you > > -boris > > >> Thank you, >> Oleksandr >>>> -boris >>>> >>> Thank you, >>> Oleksandr >>>>> drivers/xen/grant-table.c | 176 +++++- >>>>> drivers/xen/mem-reservation.c | 134 +++++ >>>>> include/uapi/xen/gntdev.h | 106 ++++ >>>>> include/xen/grant_dev.h | 37 ++ >>>>> include/xen/grant_table.h | 28 + >>>>> include/xen/mem_reservation.h | 29 + >>>>> 10 files changed, 1527 insertions(+), 103 deletions(-) >>>>> create mode 100644 drivers/xen/mem-reservation.c >>>>> create mode 100644 include/xen/grant_dev.h >>>>> create mode 100644 include/xen/mem_reservation.h >>>>> >> [1] >> https://github.com/andr2000/linux/commits/xen_tip_linux_next_xen_dma_buf_v2 _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-06-01 5:42 UTC|newest] Thread overview: 116+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-25 15:33 [PATCH 0/8] xen: dma-buf support for grant device Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-25 15:33 ` [PATCH 1/8] xen/grant-table: Make set/clear page private code shared Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-29 17:39 ` Boris Ostrovsky 2018-05-29 17:39 ` Boris Ostrovsky 2018-05-30 4:24 ` Juergen Gross 2018-05-30 5:27 ` Oleksandr Andrushchenko 2018-05-30 5:27 ` Oleksandr Andrushchenko 2018-05-30 4:24 ` Juergen Gross 2018-05-30 21:34 ` Dongwon Kim 2018-05-30 21:34 ` Dongwon Kim 2018-05-31 5:37 ` Oleksandr Andrushchenko 2018-05-31 5:37 ` Oleksandr Andrushchenko 2018-05-31 5:37 ` Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-25 15:33 ` [PATCH 2/8] xen/balloon: Move common memory reservation routines to a module Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-29 18:04 ` Boris Ostrovsky 2018-05-29 18:04 ` Boris Ostrovsky 2018-05-29 18:22 ` Oleksandr Andrushchenko 2018-05-29 18:22 ` Oleksandr Andrushchenko 2018-05-29 20:03 ` Boris Ostrovsky 2018-05-29 20:03 ` Boris Ostrovsky 2018-05-30 8:29 ` Oleksandr Andrushchenko 2018-05-30 15:54 ` Boris Ostrovsky 2018-05-30 15:54 ` Boris Ostrovsky 2018-05-30 17:46 ` Oleksandr Andrushchenko 2018-05-30 17:46 ` Oleksandr Andrushchenko 2018-05-30 19:24 ` Boris Ostrovsky 2018-05-30 19:24 ` Boris Ostrovsky 2018-05-31 7:51 ` Oleksandr Andrushchenko 2018-05-31 7:51 ` Oleksandr Andrushchenko 2018-05-31 14:29 ` Oleksandr Andrushchenko 2018-05-31 14:29 ` Oleksandr Andrushchenko 2018-05-31 7:51 ` Oleksandr Andrushchenko 2018-05-30 8:29 ` Oleksandr Andrushchenko 2018-05-29 18:22 ` Oleksandr Andrushchenko 2018-05-29 18:24 ` Boris Ostrovsky 2018-05-29 18:24 ` Boris Ostrovsky 2018-05-29 18:23 ` Oleksandr Andrushchenko 2018-05-29 18:23 ` Oleksandr Andrushchenko 2018-05-29 18:23 ` Oleksandr Andrushchenko 2018-05-30 4:32 ` Juergen Gross 2018-05-30 5:30 ` Oleksandr Andrushchenko 2018-05-30 5:30 ` Oleksandr Andrushchenko 2018-05-30 4:32 ` Juergen Gross 2018-05-25 15:33 ` [PATCH 3/8] xen/grant-table: Allow allocating buffers suitable for DMA Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-29 19:10 ` Boris Ostrovsky 2018-05-30 6:34 ` Oleksandr Andrushchenko 2018-05-30 6:34 ` Oleksandr Andrushchenko 2018-05-30 15:20 ` Boris Ostrovsky 2018-05-30 15:20 ` Boris Ostrovsky 2018-05-30 17:49 ` Oleksandr Andrushchenko 2018-05-30 17:49 ` Oleksandr Andrushchenko 2018-05-30 19:25 ` Boris Ostrovsky 2018-05-30 19:25 ` Boris Ostrovsky 2018-05-30 6:34 ` Oleksandr Andrushchenko 2018-05-29 19:10 ` Boris Ostrovsky 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-25 15:33 ` [PATCH 4/8] xen/gntdev: Allow mappings for DMA buffers Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-29 21:52 ` Boris Ostrovsky 2018-05-30 6:47 ` Oleksandr Andrushchenko 2018-05-30 6:47 ` Oleksandr Andrushchenko 2018-05-30 6:47 ` Oleksandr Andrushchenko 2018-05-29 21:52 ` Boris Ostrovsky 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-25 15:33 ` [PATCH 5/8] xen/gntdev: Add initial support for dma-buf UAPI Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-29 22:34 ` Boris Ostrovsky 2018-05-30 6:52 ` Oleksandr Andrushchenko 2018-05-30 6:52 ` Oleksandr Andrushchenko 2018-05-30 6:52 ` Oleksandr Andrushchenko 2018-05-29 22:34 ` Boris Ostrovsky 2018-05-30 6:52 ` Oleksandr Andrushchenko 2018-05-30 6:52 ` Oleksandr Andrushchenko 2018-05-30 6:52 ` Oleksandr Andrushchenko 2018-05-25 15:33 ` [PATCH 6/8] xen/gntdev: Implement dma-buf export functionality Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-30 23:10 ` Dongwon Kim 2018-05-30 23:10 ` Dongwon Kim 2018-05-31 5:55 ` Oleksandr Andrushchenko 2018-05-31 5:55 ` Oleksandr Andrushchenko 2018-05-31 14:32 ` Oleksandr Andrushchenko 2018-05-31 14:32 ` Oleksandr Andrushchenko 2018-05-31 14:32 ` Oleksandr Andrushchenko 2018-05-31 5:55 ` Oleksandr Andrushchenko 2018-05-30 23:10 ` Dongwon Kim 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-25 15:33 ` [PATCH 7/8] xen/gntdev: Implement dma-buf import functionality Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-25 15:33 ` [PATCH 8/8] xen/gntdev: Expose gntdev's dma-buf API for in-kernel use Oleksandr Andrushchenko 2018-05-25 15:33 ` Oleksandr Andrushchenko 2018-05-30 8:32 ` Oleksandr Andrushchenko 2018-05-30 8:32 ` Oleksandr Andrushchenko 2018-05-31 1:46 ` [PATCH 0/8] xen: dma-buf support for grant device Boris Ostrovsky 2018-05-31 5:51 ` Oleksandr Andrushchenko 2018-05-31 5:51 ` Oleksandr Andrushchenko 2018-05-31 14:41 ` Oleksandr Andrushchenko 2018-05-31 14:41 ` Oleksandr Andrushchenko 2018-05-31 20:25 ` Boris Ostrovsky 2018-05-31 20:25 ` Boris Ostrovsky 2018-06-01 5:42 ` Oleksandr Andrushchenko [this message] 2018-06-01 5:42 ` Oleksandr Andrushchenko 2018-06-01 5:42 ` Oleksandr Andrushchenko 2018-05-31 14:41 ` Oleksandr Andrushchenko 2018-05-31 19:36 ` Boris Ostrovsky 2018-05-31 19:36 ` Boris Ostrovsky 2018-05-31 5:51 ` Oleksandr Andrushchenko 2018-05-31 1:46 ` Boris Ostrovsky 2018-05-25 15:33 Oleksandr Andrushchenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=fa050c85-f236-2f70-414b-80c095d825cb@gmail.com \ --to=andr2000@gmail.com \ --cc=Oleksandr_Andrushchenko@epam.com \ --cc=boris.ostrovsky@oracle.com \ --cc=daniel.vetter@intel.com \ --cc=dongwon.kim@intel.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=jgross@suse.com \ --cc=konrad.wilk@oracle.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=matthew.d.roper@intel.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.