All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Chris Morgan <macroalpha82@gmail.com>, devicetree@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org, lee.jones@linaro.org,
	robh+dt@kernel.org, heiko@sntech.de, strit@manjaro.org,
	mbrugger@suse.com, arnaud.ferraris@collabora.com,
	knaerzche@gmail.com, zyw@rock-chips.com,
	zhangqing@rock-chips.com, Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 2/3 v4] dts: rockchip: Add #clock-cells value for rk805
Date: Thu, 3 Mar 2022 11:58:24 +0000	[thread overview]
Message-ID: <fa051752-c98a-df6f-27a3-dd4c0de1caf5@arm.com> (raw)
In-Reply-To: <20220302232612.25455-3-macroalpha82@gmail.com>

On 2022-03-02 23:26, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Based on a brief discussion on the mailing list it was determined that
> clock-cells should be a required parameter in the event that a consumer
> of the clock gets added in an overlay.

Reviewed-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>   arch/arm/boot/dts/rv1108-elgin-r1.dts      | 1 +
>   arch/arm/boot/dts/rv1108-evb.dts           | 1 +
>   arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 1 +
>   3 files changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rv1108-elgin-r1.dts
> index f62c9f7af79d..0c99a5934ebf 100644
> --- a/arch/arm/boot/dts/rv1108-elgin-r1.dts
> +++ b/arch/arm/boot/dts/rv1108-elgin-r1.dts
> @@ -72,6 +72,7 @@ rk805: pmic@18 {
>   		interrupt-parent = <&gpio0>;
>   		interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>;
>   		rockchip,system-power-controller;
> +		#clock-cells = <0>;
>   
>   		vcc1-supply = <&vcc_sys>;
>   		vcc2-supply = <&vcc_sys>;
> diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
> index fe5fc9bf75c9..46cad7cb94bf 100644
> --- a/arch/arm/boot/dts/rv1108-evb.dts
> +++ b/arch/arm/boot/dts/rv1108-evb.dts
> @@ -85,6 +85,7 @@ rk805: pmic@18 {
>   		interrupt-parent = <&gpio0>;
>   		interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>;
>   		rockchip,system-power-controller;
> +		#clock-cells = <0>;
>   
>   		vcc1-supply = <&vcc_sys>;
>   		vcc2-supply = <&vcc_sys>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> index de2d3e88e27f..40bf808642b9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> @@ -160,6 +160,7 @@ pmic@18 {
>   		pinctrl-0 = <&pmic_int_l>;
>   		rockchip,system-power-controller;
>   		wakeup-source;
> +		#clock-cells = <0>;
>   
>   		vcc1-supply = <&vcc_sys>;
>   		vcc2-supply = <&vcc_sys>;

WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Chris Morgan <macroalpha82@gmail.com>, devicetree@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org, lee.jones@linaro.org,
	robh+dt@kernel.org, heiko@sntech.de, strit@manjaro.org,
	mbrugger@suse.com, arnaud.ferraris@collabora.com,
	knaerzche@gmail.com, zyw@rock-chips.com,
	zhangqing@rock-chips.com, Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH 2/3 v4] dts: rockchip: Add #clock-cells value for rk805
Date: Thu, 3 Mar 2022 11:58:24 +0000	[thread overview]
Message-ID: <fa051752-c98a-df6f-27a3-dd4c0de1caf5@arm.com> (raw)
In-Reply-To: <20220302232612.25455-3-macroalpha82@gmail.com>

On 2022-03-02 23:26, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
> 
> Based on a brief discussion on the mailing list it was determined that
> clock-cells should be a required parameter in the event that a consumer
> of the clock gets added in an overlay.

Reviewed-by: Robin Murphy <robin.murphy@arm.com>

> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>   arch/arm/boot/dts/rv1108-elgin-r1.dts      | 1 +
>   arch/arm/boot/dts/rv1108-evb.dts           | 1 +
>   arch/arm64/boot/dts/rockchip/rk3328-a1.dts | 1 +
>   3 files changed, 3 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rv1108-elgin-r1.dts b/arch/arm/boot/dts/rv1108-elgin-r1.dts
> index f62c9f7af79d..0c99a5934ebf 100644
> --- a/arch/arm/boot/dts/rv1108-elgin-r1.dts
> +++ b/arch/arm/boot/dts/rv1108-elgin-r1.dts
> @@ -72,6 +72,7 @@ rk805: pmic@18 {
>   		interrupt-parent = <&gpio0>;
>   		interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>;
>   		rockchip,system-power-controller;
> +		#clock-cells = <0>;
>   
>   		vcc1-supply = <&vcc_sys>;
>   		vcc2-supply = <&vcc_sys>;
> diff --git a/arch/arm/boot/dts/rv1108-evb.dts b/arch/arm/boot/dts/rv1108-evb.dts
> index fe5fc9bf75c9..46cad7cb94bf 100644
> --- a/arch/arm/boot/dts/rv1108-evb.dts
> +++ b/arch/arm/boot/dts/rv1108-evb.dts
> @@ -85,6 +85,7 @@ rk805: pmic@18 {
>   		interrupt-parent = <&gpio0>;
>   		interrupts = <RK_PB4 IRQ_TYPE_LEVEL_LOW>;
>   		rockchip,system-power-controller;
> +		#clock-cells = <0>;
>   
>   		vcc1-supply = <&vcc_sys>;
>   		vcc2-supply = <&vcc_sys>;
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> index de2d3e88e27f..40bf808642b9 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-a1.dts
> @@ -160,6 +160,7 @@ pmic@18 {
>   		pinctrl-0 = <&pmic_int_l>;
>   		rockchip,system-power-controller;
>   		wakeup-source;
> +		#clock-cells = <0>;
>   
>   		vcc1-supply = <&vcc_sys>;
>   		vcc2-supply = <&vcc_sys>;

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2022-03-03 11:58 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-02 23:26 [PATCH 0/3 v4] rk808: Convert bindings to yaml Chris Morgan
2022-03-02 23:26 ` Chris Morgan
2022-03-02 23:26 ` [PATCH 1/3 v4] arm64: dts: rockchip: Remove vcc13 and vcc14 for rk808 Chris Morgan
2022-03-02 23:26   ` Chris Morgan
2022-03-03 11:57   ` Robin Murphy
2022-03-03 11:57     ` Robin Murphy
2022-03-02 23:26 ` [PATCH 2/3 v4] dts: rockchip: Add #clock-cells value for rk805 Chris Morgan
2022-03-02 23:26   ` Chris Morgan
2022-03-03 11:58   ` Robin Murphy [this message]
2022-03-03 11:58     ` Robin Murphy
2022-03-02 23:26 ` [PATCH 3/3 v4] dt-bindings: mfd: rk808: Convert bindings to yaml Chris Morgan
2022-03-02 23:26   ` Chris Morgan
2022-03-03 13:44   ` Rob Herring
2022-03-03 13:44     ` Rob Herring
2022-03-03 19:18     ` Chris Morgan
2022-03-03 19:18       ` Chris Morgan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa051752-c98a-df6f-27a3-dd4c0de1caf5@arm.com \
    --to=robin.murphy@arm.com \
    --cc=arnaud.ferraris@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=knaerzche@gmail.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=macroalpha82@gmail.com \
    --cc=macromorgan@hotmail.com \
    --cc=mbrugger@suse.com \
    --cc=robh+dt@kernel.org \
    --cc=strit@manjaro.org \
    --cc=zhangqing@rock-chips.com \
    --cc=zyw@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.