All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brad Smith <brad@comstyle.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>,
	"Stefan Weil" <sw@weilnetz.de>,
	qemu-devel@nongnu.org
Cc: "Daniel P . Berrangé" <berrange@redhat.com>
Subject: Re: [PATCH] meson.build: Support ncurses on MacOS
Date: Mon, 14 Jun 2021 21:53:06 -0400	[thread overview]
Message-ID: <fa1b9eb9-e707-4dd1-78be-dce4c55c5004@comstyle.com> (raw)
In-Reply-To: <ff5fc830-8df8-7bd6-32df-3e8627edd74b@amsat.org>

On 6/14/2021 1:45 AM, Philippe Mathieu-Daudé wrote:
> On 6/13/21 8:33 AM, Stefan Weil wrote:
>> Am 13.06.21 um 03:40 schrieb Brad Smith:
>>
>>> This same problem also applies to OpenBSD as we have the same
>>> version of ncurses with support for wide characters. I have a similar
>>> patch in our QEMU port.
>>
>> Then we should either extend the conditional statement to handle OpenBSD
>> as well, or simply define both macros unconditionally:
>>
>>      # Newer versions of curses use NCURSES_WIDECHAR.
>>      # Older versions (e. g. on MacOS, OpenBSD) still require
>> _XOPEN_SOURCE_EXTENDED.
>>      curses_compile_args = ['-DNCURSES_WIDECHAR=1',
>> '-D_XOPEN_SOURCE_EXTENDED=1']
>>
>> Defining only _XOPEN_SOURCE_EXTENDED would also work with old and new
>> versions, so that's another option.
> It is simpler to ask Brad to upstream the OpenBSD patch :)

That doesn't answer his question and that's the part that actually matters.


  reply	other threads:[~2021-06-15  1:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12  8:03 [PATCH] meson.build: Support ncurses on MacOS Stefan Weil
2021-06-13  1:40 ` Brad Smith
2021-06-13  6:33   ` Stefan Weil
2021-06-14  5:45     ` Philippe Mathieu-Daudé
2021-06-15  1:53       ` Brad Smith [this message]
2021-11-09 17:49         ` Stefan Weil
2021-11-09 18:30           ` Daniel P. Berrangé
2021-06-12  8:51 Stefan Weil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fa1b9eb9-e707-4dd1-78be-dce4c55c5004@comstyle.com \
    --to=brad@comstyle.com \
    --cc=berrange@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.