* [PATCH] drm/msm/rd: Add chip-id
@ 2022-01-14 18:57 ` Rob Clark
0 siblings, 0 replies; 4+ messages in thread
From: Rob Clark @ 2022-01-14 18:57 UTC (permalink / raw)
To: dri-devel
Cc: freedreno, linux-arm-msm, Rob Clark, Rob Clark, Sean Paul,
Abhinav Kumar, David Airlie, Daniel Vetter, open list
From: Rob Clark <robdclark@chromium.org>
For newer devices which deprecate gpu-id and do matching based on
chip-id, we need this information in cmdstream dumps so that the
decoding tools know how to decode them.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/msm_rd.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c
index 81432ec07012..7e4d6460719e 100644
--- a/drivers/gpu/drm/msm/msm_rd.c
+++ b/drivers/gpu/drm/msm/msm_rd.c
@@ -62,6 +62,7 @@ enum rd_sect_type {
RD_FRAG_SHADER,
RD_BUFFER_CONTENTS,
RD_GPU_ID,
+ RD_CHIP_ID,
};
#define BUF_SZ 512 /* should be power of 2 */
@@ -202,6 +203,9 @@ static int rd_open(struct inode *inode, struct file *file)
rd_write_section(rd, RD_GPU_ID, &gpu_id, sizeof(gpu_id));
+ gpu->funcs->get_param(gpu, MSM_PARAM_CHIP_ID, &val);
+ rd_write_section(rd, RD_CHIP_ID, &val, sizeof(val));
+
out:
mutex_unlock(&gpu->lock);
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/msm/rd: Add chip-id
@ 2022-01-14 18:57 ` Rob Clark
0 siblings, 0 replies; 4+ messages in thread
From: Rob Clark @ 2022-01-14 18:57 UTC (permalink / raw)
To: dri-devel
Cc: Rob Clark, David Airlie, linux-arm-msm, Abhinav Kumar, open list,
Sean Paul, freedreno
From: Rob Clark <robdclark@chromium.org>
For newer devices which deprecate gpu-id and do matching based on
chip-id, we need this information in cmdstream dumps so that the
decoding tools know how to decode them.
Signed-off-by: Rob Clark <robdclark@chromium.org>
---
drivers/gpu/drm/msm/msm_rd.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c
index 81432ec07012..7e4d6460719e 100644
--- a/drivers/gpu/drm/msm/msm_rd.c
+++ b/drivers/gpu/drm/msm/msm_rd.c
@@ -62,6 +62,7 @@ enum rd_sect_type {
RD_FRAG_SHADER,
RD_BUFFER_CONTENTS,
RD_GPU_ID,
+ RD_CHIP_ID,
};
#define BUF_SZ 512 /* should be power of 2 */
@@ -202,6 +203,9 @@ static int rd_open(struct inode *inode, struct file *file)
rd_write_section(rd, RD_GPU_ID, &gpu_id, sizeof(gpu_id));
+ gpu->funcs->get_param(gpu, MSM_PARAM_CHIP_ID, &val);
+ rd_write_section(rd, RD_CHIP_ID, &val, sizeof(val));
+
out:
mutex_unlock(&gpu->lock);
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm/rd: Add chip-id
2022-01-14 18:57 ` Rob Clark
@ 2022-02-09 22:25 ` Dmitry Baryshkov
-1 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-02-09 22:25 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: Rob Clark, freedreno, David Airlie, linux-arm-msm, Abhinav Kumar,
open list, Sean Paul
On 14/01/2022 21:57, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> For newer devices which deprecate gpu-id and do matching based on
> chip-id, we need this information in cmdstream dumps so that the
> decoding tools know how to decode them.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_rd.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c
> index 81432ec07012..7e4d6460719e 100644
> --- a/drivers/gpu/drm/msm/msm_rd.c
> +++ b/drivers/gpu/drm/msm/msm_rd.c
> @@ -62,6 +62,7 @@ enum rd_sect_type {
> RD_FRAG_SHADER,
> RD_BUFFER_CONTENTS,
> RD_GPU_ID,
> + RD_CHIP_ID,
> };
>
> #define BUF_SZ 512 /* should be power of 2 */
> @@ -202,6 +203,9 @@ static int rd_open(struct inode *inode, struct file *file)
>
> rd_write_section(rd, RD_GPU_ID, &gpu_id, sizeof(gpu_id));
>
> + gpu->funcs->get_param(gpu, MSM_PARAM_CHIP_ID, &val);
> + rd_write_section(rd, RD_CHIP_ID, &val, sizeof(val));
> +
> out:
> mutex_unlock(&gpu->lock);
> return ret;
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/msm/rd: Add chip-id
@ 2022-02-09 22:25 ` Dmitry Baryshkov
0 siblings, 0 replies; 4+ messages in thread
From: Dmitry Baryshkov @ 2022-02-09 22:25 UTC (permalink / raw)
To: Rob Clark, dri-devel
Cc: freedreno, linux-arm-msm, Rob Clark, Sean Paul, Abhinav Kumar,
David Airlie, Daniel Vetter, open list
On 14/01/2022 21:57, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> For newer devices which deprecate gpu-id and do matching based on
> chip-id, we need this information in cmdstream dumps so that the
> decoding tools know how to decode them.
>
> Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_rd.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c
> index 81432ec07012..7e4d6460719e 100644
> --- a/drivers/gpu/drm/msm/msm_rd.c
> +++ b/drivers/gpu/drm/msm/msm_rd.c
> @@ -62,6 +62,7 @@ enum rd_sect_type {
> RD_FRAG_SHADER,
> RD_BUFFER_CONTENTS,
> RD_GPU_ID,
> + RD_CHIP_ID,
> };
>
> #define BUF_SZ 512 /* should be power of 2 */
> @@ -202,6 +203,9 @@ static int rd_open(struct inode *inode, struct file *file)
>
> rd_write_section(rd, RD_GPU_ID, &gpu_id, sizeof(gpu_id));
>
> + gpu->funcs->get_param(gpu, MSM_PARAM_CHIP_ID, &val);
> + rd_write_section(rd, RD_CHIP_ID, &val, sizeof(val));
> +
> out:
> mutex_unlock(&gpu->lock);
> return ret;
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-09 22:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-14 18:57 [PATCH] drm/msm/rd: Add chip-id Rob Clark
2022-01-14 18:57 ` Rob Clark
2022-02-09 22:25 ` Dmitry Baryshkov
2022-02-09 22:25 ` Dmitry Baryshkov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.