* [PATCH next] powerpc/5200: fix building GPT driver without sysfs
@ 2009-03-16 16:17 Alexander Beregalov
2009-03-16 16:22 ` Grant Likely
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Beregalov @ 2009-03-16 16:17 UTC (permalink / raw)
To: grant.likely, linuxppc-dev, linux-next
arch/powerpc/platforms/52xx/mpc52xx_gpt.c: In function 'mpc52xx_gpt_create_attribs':
arch/powerpc/platforms/52xx/mpc52xx_gpt.c:373: error: parameter name omitted
arch/powerpc/platforms/52xx/mpc52xx_gpt.c:373: warning: 'return' with a value, in function returning void
Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
---
arch/powerpc/platforms/52xx/mpc52xx_gpt.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
index cb038dc..ef81cce 100644
--- a/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
+++ b/arch/powerpc/platforms/52xx/mpc52xx_gpt.c
@@ -370,7 +370,7 @@ static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *gpt)
}
#else /* defined(CONFIG_SYSFS) */
-static void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *) { return 0; }
+static inline void mpc52xx_gpt_create_attribs(struct mpc52xx_gpt_priv *gpt) {}
#endif /* defined(CONFIG_SYSFS) */
/* ---------------------------------------------------------------------
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH next] powerpc/5200: fix building GPT driver without sysfs
2009-03-16 16:17 [PATCH next] powerpc/5200: fix building GPT driver without sysfs Alexander Beregalov
@ 2009-03-16 16:22 ` Grant Likely
0 siblings, 0 replies; 2+ messages in thread
From: Grant Likely @ 2009-03-16 16:22 UTC (permalink / raw)
To: Alexander Beregalov; +Cc: linuxppc-dev, linux-next
On Mon, Mar 16, 2009 at 10:17 AM, Alexander Beregalov
<a.beregalov@gmail.com> wrote:
> arch/powerpc/platforms/52xx/mpc52xx_gpt.c: In function 'mpc52xx_gpt_create_attribs':
> arch/powerpc/platforms/52xx/mpc52xx_gpt.c:373: error: parameter name omitted
> arch/powerpc/platforms/52xx/mpc52xx_gpt.c:373: warning: 'return' with a value, in function returning void
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
A patch has already been queued in the next branch of
git://git.secretlab.ca/git/linux-2.6-mpc52xx which removes the sysfs
code from this driver entirely. Ben just hasn't pulled it into his
-next branch yet.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-03-16 16:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-16 16:17 [PATCH next] powerpc/5200: fix building GPT driver without sysfs Alexander Beregalov
2009-03-16 16:22 ` Grant Likely
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.