From: heyunlei <heyunlei@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid IO split due to mixed WB_SYNC_ALL and WB_SYNC_NONE
Date: Fri, 31 Mar 2017 11:41:54 +0800 [thread overview]
Message-ID: <fa85e856-723e-e6eb-acff-888934a979b6@huawei.com> (raw)
In-Reply-To: <20170329204815.9175-2-jaegeuk@kernel.org>
Hi Jaegeuk,
I try this patch and find it can fix below case:
kworker/u16:3-423 [002] .... 183.812347: submit_bio: kworker/u16:3(423): WRITE block 104749352 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812380: submit_bio: fio(2122): WRITE block 104749360 on mmcblk0p50 (24 sectors)
kworker/u16:3-423 [002] .... 183.812388: submit_bio: kworker/u16:3(423): WRITE block 104749384 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812403: submit_bio: fio(2122): WRITE block 104749392 on mmcblk0p50 (8 sectors)
kworker/u16:3-423 [002] .... 183.812404: submit_bio: kworker/u16:3(423): WRITE block 104749400 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812427: submit_bio: fio(2122): WRITE block 104749408 on mmcblk0p50 (16 sectors)
kworker/u16:3-423 [002] .... 183.812429: submit_bio: kworker/u16:3(423): WRITE block 104749424 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812450: submit_bio: fio(2122): WRITE block 104749432 on mmcblk0p50 (16 sectors)
kworker/u16:3-423 [002] .... 183.812455: submit_bio: kworker/u16:3(423): WRITE block 104749448 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812470: submit_bio: fio(2122): WRITE block 104749456 on mmcblk0p50 (8 sectors)
kworker/u16:3-423 [002] .... 183.812476: submit_bio: kworker/u16:3(423): WRITE block 104749464 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812492: submit_bio: fio(2122): WRITE block 104749472 on mmcblk0p50 (16 sectors)
kworker/u16:3-423 [002] .... 183.812497: submit_bio: kworker/u16:3(423): WRITE block 104749488 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812512: submit_bio: fio(2122): WRITE block 104749496 on mmcblk0p50 (8 sectors)
kworker/u16:3-423 [002] .... 183.812514: submit_bio: kworker/u16:3(423): WRITE block 104749504 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812532: submit_bio: fio(2122): WRITE block 104749512 on mmcblk0p50 (16 sectors)
... ...
Thanks.
On 2017/3/30 4:48, Jaegeuk Kim wrote:
> If two threads try to flush dirty pages in different inodes respectively,
> f2fs_write_data_pages() will produce WRITE and WRITE_SYNC one at a time,
> resulting in a lot of 4KB seperated IOs.
>
> So, this patch gives higher priority to WB_SYNC_ALL IOs and gathers write
> IOs with a big WRITE_SYNC'ed bio.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/data.c | 15 +++++++++++++--
> fs/f2fs/f2fs.h | 3 +++
> fs/f2fs/super.c | 2 ++
> 3 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 8f36080b47c4..b1cac6d85bcb 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -1605,8 +1605,10 @@ static int f2fs_write_cache_pages(struct address_space *mapping,
> last_idx = page->index;
> }
>
> - if (--wbc->nr_to_write <= 0 &&
> - wbc->sync_mode == WB_SYNC_NONE) {
> + /* give a priority to WB_SYNC threads */
> + if ((atomic_read(&F2FS_M_SB(mapping)->wb_sync_req) ||
> + --wbc->nr_to_write <= 0) &&
> + wbc->sync_mode == WB_SYNC_NONE) {
> done = 1;
> break;
> }
> @@ -1662,9 +1664,18 @@ static int f2fs_write_data_pages(struct address_space *mapping,
>
> trace_f2fs_writepages(mapping->host, wbc, DATA);
>
> + /* to avoid spliting IOs due to mixed WB_SYNC_ALL and WB_SYNC_NONE */
> + if (wbc->sync_mode == WB_SYNC_ALL)
> + atomic_inc(&sbi->wb_sync_req);
> + else if (atomic_read(&sbi->wb_sync_req))
> + goto skip_write;
> +
> blk_start_plug(&plug);
> ret = f2fs_write_cache_pages(mapping, wbc);
> blk_finish_plug(&plug);
> +
> + if (wbc->sync_mode == WB_SYNC_ALL)
> + atomic_dec(&sbi->wb_sync_req);
> /*
> * if some pages were truncated, we cannot guarantee its mapping->host
> * to detect pending bios.
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 32d6f674c114..fd39db681226 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -888,6 +888,9 @@ struct f2fs_sb_info {
> /* # of allocated blocks */
> struct percpu_counter alloc_valid_block_count;
>
> + /* writeback control */
> + atomic_t wb_sync_req; /* count # of WB_SYNC threads */
> +
> /* valid inode count */
> struct percpu_counter total_valid_inode_count;
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 2d78f3c76d18..cb65e6d0d275 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1566,6 +1566,8 @@ static void init_sb_info(struct f2fs_sb_info *sbi)
> for (i = 0; i < NR_COUNT_TYPE; i++)
> atomic_set(&sbi->nr_pages[i], 0);
>
> + atomic_set(&sbi->wb_sync_req, 0);
> +
> INIT_LIST_HEAD(&sbi->s_list);
> mutex_init(&sbi->umount_mutex);
> mutex_init(&sbi->wio_mutex[NODE]);
>
WARNING: multiple messages have this Message-ID (diff)
From: heyunlei <heyunlei@huawei.com>
To: Jaegeuk Kim <jaegeuk@kernel.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: avoid IO split due to mixed WB_SYNC_ALL and WB_SYNC_NONE
Date: Fri, 31 Mar 2017 11:41:54 +0800 [thread overview]
Message-ID: <fa85e856-723e-e6eb-acff-888934a979b6@huawei.com> (raw)
In-Reply-To: <20170329204815.9175-2-jaegeuk@kernel.org>
Hi Jaegeuk,
I try this patch and find it can fix below case:
kworker/u16:3-423 [002] .... 183.812347: submit_bio: kworker/u16:3(423): WRITE block 104749352 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812380: submit_bio: fio(2122): WRITE block 104749360 on mmcblk0p50 (24 sectors)
kworker/u16:3-423 [002] .... 183.812388: submit_bio: kworker/u16:3(423): WRITE block 104749384 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812403: submit_bio: fio(2122): WRITE block 104749392 on mmcblk0p50 (8 sectors)
kworker/u16:3-423 [002] .... 183.812404: submit_bio: kworker/u16:3(423): WRITE block 104749400 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812427: submit_bio: fio(2122): WRITE block 104749408 on mmcblk0p50 (16 sectors)
kworker/u16:3-423 [002] .... 183.812429: submit_bio: kworker/u16:3(423): WRITE block 104749424 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812450: submit_bio: fio(2122): WRITE block 104749432 on mmcblk0p50 (16 sectors)
kworker/u16:3-423 [002] .... 183.812455: submit_bio: kworker/u16:3(423): WRITE block 104749448 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812470: submit_bio: fio(2122): WRITE block 104749456 on mmcblk0p50 (8 sectors)
kworker/u16:3-423 [002] .... 183.812476: submit_bio: kworker/u16:3(423): WRITE block 104749464 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812492: submit_bio: fio(2122): WRITE block 104749472 on mmcblk0p50 (16 sectors)
kworker/u16:3-423 [002] .... 183.812497: submit_bio: kworker/u16:3(423): WRITE block 104749488 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812512: submit_bio: fio(2122): WRITE block 104749496 on mmcblk0p50 (8 sectors)
kworker/u16:3-423 [002] .... 183.812514: submit_bio: kworker/u16:3(423): WRITE block 104749504 on mmcblk0p50 (8 sectors)
fio-2122 [003] .... 183.812532: submit_bio: fio(2122): WRITE block 104749512 on mmcblk0p50 (16 sectors)
... ...
Thanks.
On 2017/3/30 4:48, Jaegeuk Kim wrote:
> If two threads try to flush dirty pages in different inodes respectively,
> f2fs_write_data_pages() will produce WRITE and WRITE_SYNC one at a time,
> resulting in a lot of 4KB seperated IOs.
>
> So, this patch gives higher priority to WB_SYNC_ALL IOs and gathers write
> IOs with a big WRITE_SYNC'ed bio.
>
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
> ---
> fs/f2fs/data.c | 15 +++++++++++++--
> fs/f2fs/f2fs.h | 3 +++
> fs/f2fs/super.c | 2 ++
> 3 files changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
> index 8f36080b47c4..b1cac6d85bcb 100644
> --- a/fs/f2fs/data.c
> +++ b/fs/f2fs/data.c
> @@ -1605,8 +1605,10 @@ static int f2fs_write_cache_pages(struct address_space *mapping,
> last_idx = page->index;
> }
>
> - if (--wbc->nr_to_write <= 0 &&
> - wbc->sync_mode == WB_SYNC_NONE) {
> + /* give a priority to WB_SYNC threads */
> + if ((atomic_read(&F2FS_M_SB(mapping)->wb_sync_req) ||
> + --wbc->nr_to_write <= 0) &&
> + wbc->sync_mode == WB_SYNC_NONE) {
> done = 1;
> break;
> }
> @@ -1662,9 +1664,18 @@ static int f2fs_write_data_pages(struct address_space *mapping,
>
> trace_f2fs_writepages(mapping->host, wbc, DATA);
>
> + /* to avoid spliting IOs due to mixed WB_SYNC_ALL and WB_SYNC_NONE */
> + if (wbc->sync_mode == WB_SYNC_ALL)
> + atomic_inc(&sbi->wb_sync_req);
> + else if (atomic_read(&sbi->wb_sync_req))
> + goto skip_write;
> +
> blk_start_plug(&plug);
> ret = f2fs_write_cache_pages(mapping, wbc);
> blk_finish_plug(&plug);
> +
> + if (wbc->sync_mode == WB_SYNC_ALL)
> + atomic_dec(&sbi->wb_sync_req);
> /*
> * if some pages were truncated, we cannot guarantee its mapping->host
> * to detect pending bios.
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 32d6f674c114..fd39db681226 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -888,6 +888,9 @@ struct f2fs_sb_info {
> /* # of allocated blocks */
> struct percpu_counter alloc_valid_block_count;
>
> + /* writeback control */
> + atomic_t wb_sync_req; /* count # of WB_SYNC threads */
> +
> /* valid inode count */
> struct percpu_counter total_valid_inode_count;
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index 2d78f3c76d18..cb65e6d0d275 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -1566,6 +1566,8 @@ static void init_sb_info(struct f2fs_sb_info *sbi)
> for (i = 0; i < NR_COUNT_TYPE; i++)
> atomic_set(&sbi->nr_pages[i], 0);
>
> + atomic_set(&sbi->wb_sync_req, 0);
> +
> INIT_LIST_HEAD(&sbi->s_list);
> mutex_init(&sbi->umount_mutex);
> mutex_init(&sbi->wio_mutex[NODE]);
>
next prev parent reply other threads:[~2017-03-31 3:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-29 20:48 [PATCH 1/2] f2fs: write small sized IO to hot log Jaegeuk Kim
2017-03-29 20:48 ` Jaegeuk Kim
2017-03-29 20:48 ` [PATCH 2/2] f2fs: avoid IO split due to mixed WB_SYNC_ALL and WB_SYNC_NONE Jaegeuk Kim
2017-03-29 20:48 ` Jaegeuk Kim
2017-03-31 3:41 ` heyunlei [this message]
2017-03-31 3:41 ` [f2fs-dev] " heyunlei
2017-03-31 3:51 ` heyunlei
2017-03-31 3:51 ` heyunlei
2017-03-31 4:18 ` Jaegeuk Kim
2017-03-31 4:18 ` Jaegeuk Kim
2017-03-31 3:38 ` [f2fs-dev] [PATCH 1/2] f2fs: write small sized IO to hot log heyunlei
2017-03-31 3:38 ` heyunlei
2017-03-31 3:54 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fa85e856-723e-e6eb-acff-888934a979b6@huawei.com \
--to=heyunlei@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.